Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-12 Thread Jeremias Maerki
I think I got it. As soon as I started working with start|end-indent wherever possible everthing started clicking in place and got simpler. Thanks again for your patience and for your helpful advice! Jeremias Maerki

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-11 Thread Jeremias Maerki
On 10.01.2005 22:00:01 Simon Pepping wrote: Section 5.3.2 of the spec is really hard to understand. I combine it with 5.1.4 about Inheritance. Then my guess is this: fo:block margin-left=1pcA test file fo:inline-container start-indent=1.5pc fo:block margin-left=1pcA test

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-11 Thread Simon Pepping
On Tue, Jan 11, 2005 at 09:25:50AM +0100, Jeremias Maerki wrote: On 10.01.2005 22:00:01 Simon Pepping wrote: There does not seem to be a need to add the inherited value later; the property maker already has done so. See IndentPropertyMaker.compute(PropertyList). It uses

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-11 Thread Finn Bock
[Simon] There does not seem to be a need to add the inherited value later; the property maker already has done so. See IndentPropertyMaker.compute(PropertyList). It uses propertyList.getInherited(baseMaker.propId).getNumeric()) to get the inherited value. Earlier FOP developers understood this

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-11 Thread Jeremias Maerki
Funny! I just came to the same conclusion a few minutes ago. Simon's last comment brought me to that. Simon: I see no mention in section 5 of the spec that the trait value for start-indent is different from the computed property value. I then checked the BlockLayoutManager and realized that what

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-10 Thread Simon Pepping
Section 5.3.2 of the spec is really hard to understand. I combine it with 5.1.4 about Inheritance. Then my guess is this: fo:block margin-left=1pcA test file fo:inline-container start-indent=1.5pc fo:block margin-left=1pcA test file/fo:block /fo:inline-container /fo:block The computed

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-10 Thread Glen Mazza
BTW, would Jeremias' proposal effect future implementation of the property value functions[1]? Thanks, Glen [1] http://www.w3.org/TR/2001/REC-xsl-20011015/slice5.html#section-N8624-Property-Value-Functions --- Simon Pepping [EMAIL PROTECTED] wrote: Section 5.3.2 of the spec is really hard to

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-10 Thread Glen Mazza
--- Glen Mazza [EMAIL PROTECTED] wrote: BTW, would Jeremias' proposal effect future ^^ oopsaffect ;) Glen

RE: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-10 Thread Goel, Nitesh
/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java BTW, would Jeremias' proposal effect future implementation of the property value functions[1]? Thanks, Glen [1] http://www.w3.org/TR/2001/REC-xsl-20011015/slice5.html#section-N8624-Pro perty-Value-Functions --- Simon

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-07 Thread Jeremias Maerki
Finn or Simon, would you please check if it is acceptable to put the inherited values directly into the CommonMarginBlock? It might have been cleaner to always get the value via the parent FO but I think in this case it helps simplifying the code in TraitSetter and BlockLayoutManager. On

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-07 Thread Finn Bock
[Jeremias] would you please check if it is acceptable to put the inherited values directly into the CommonMarginBlock? It might have been cleaner to always get the value via the parent FO but I think in this case it helps simplifying the code in TraitSetter and BlockLayoutManager. It looks wrong,

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java BlockLayoutManager.java

2005-01-07 Thread Jeremias Maerki
On 07.01.2005 10:49:02 Finn Bock wrote: [Jeremias] would you please check if it is acceptable to put the inherited values directly into the CommonMarginBlock? It might have been cleaner to always get the value via the parent FO but I think in this case it helps simplifying the code in

cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr TraitSetter.java

2004-01-29 Thread bckfnn
bckfnn 2004/01/29 11:36:04 Modified:src/java/org/apache/fop/layoutmgr TraitSetter.java Log: Added addMargins() to set the SPACE_* traits. PR: 25802. Revision ChangesPath 1.5 +26 -0 xml-fop/src/java/org/apache/fop/layoutmgr/TraitSetter.java Index: