DO NOT REPLY [Bug 23883] - SVG embedded in FO cannot handle large (6digit) translates
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23883. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23883 SVG embedded in FO cannot handle large (6digit) translates --- Additional Comments From [EMAIL PROTECTED] 2003-10-26 08:56 --- Created an attachment (id=8739) SVG result from FO2SVG transformation
Bug report for Fop [2003/10/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 635|Opn|Nor|2001-02-18|Doesn't support id= attribute in fo:page-sequence | | 953|Opn|Nor|2001-03-12|Incorrect hyperlinks area rendering in justified t| | 1063|New|Nor|2001-03-21|fop does not handle large fo files| | 1180|New|Maj|2001-04-02|Problem with monospaced font | | 1859|Opn|Min|2001-05-22|org.apache.fop.apps.Driver.reset() doesn't fully r| | 1998|New|Nor|2001-06-05|linefeed-treatment not understood | | 2150|Ass|Maj|2001-06-13|New page with a table-header but without any tabl| | 2475|Ass|Nor|2001-07-06|Borders don't appear to work in fo:table-row| | 2740|New|Maj|2001-07-23|multi-page tables sometimes render badly | | 2909|New|Maj|2001-07-30|Gradient render error | | 2964|Ass|Nor|2001-08-02|problems with height of cells in tables | | 2988|New|Maj|2001-08-03|0.19: list-item-label does not stick to list-item-| | 3044|Ass|Maj|2001-08-08|keep-together not functioning | | 3280|New|Nor|2001-08-27|PCL Renderer doesn't work | | 3305|Opn|Nor|2001-08-28|list-block overlapping footnote body | | 3497|New|Maj|2001-09-07|id already exists error when using span=all attr| | 3824|New|Blk|2001-09-25|MIF option with tables| | 4030|New|Nor|2001-10-08|IOException creating Postscript with graphics on S| | 4126|New|Nor|2001-10-12|FontState.width() returns pts instead of millipts | | 4226|New|Nor|2001-10-17|The orphans property doesn't seem to work | | 4388|New|Nor|2001-10-24|Nullpointer exception in the construction of new D| | 4415|New|Nor|2001-10-25|scaling=uniform does not work on images... | | 4510|New|Nor|2001-10-30|fo:inline common properties ignored? | | 4535|New|Maj|2001-10-31|PCL renderer 1.13 not rendering SVG | | 4614|New|Maj|2001-11-03|wrap property combined with Chinese | | 4767|New|Nor|2001-11-09|SVG text is distored in PDF output| | 5001|New|Nor|2001-11-21|content-width and content-height ignored? | | 5010|New|Enh|2001-11-21|Better error reporting needed | | 5047|Ass|Nor|2001-11-23|Dotted border style is not supported | | 5124|New|Maj|2001-11-27|fo:block-container is not rendered properly using | | 5335|Opn|Min|2001-12-10|Text with embedded CID fonts not retrievable from | | 5655|Ass|Nor|2002-01-02|text-decoration cannot take multiple values | | 6094|Opn|Maj|2002-01-29|0.20.3rc hangs in endless loop| | 6237|Opn|Nor|2002-02-05|#xFB01 (fi ligature) produces a sharp? | | 6305|New|Nor|2002-02-07|Using fo:table-and-caption results in empty output| | 6427|New|Enh|2002-02-13|Adding additional Type 1 fonts problem| | 6437|New|Maj|2002-02-13|Tables without fo:table-column don't render | | 6483|New|Nor|2002-02-15|Table, Loop, footer could not fit on page, moving| | 6844|New|Nor|2002-03-04|No line breaks inserted in list-item-label| | 6918|New|Enh|2002-03-06|reference-orientation has no effect | | 6929|New|Nor|2002-03-06|Cells border hidden by cells background | | 6997|New|Nor|2002-03-09|Row-spanned row data breaks over a page within a c| | 7140|New|Enh|2002-03-15|page-position attribute set to last on condition| | 7241|New|Nor|2002-03-19|keep-with-previous, keep-with-next only working on| | 7283|New|Nor|2002-03-20|Table border misaligned when using margin-left in | | 7337|New|Nor|2002-03-21|border around external image leaves empty space | | 7487|New|Nor|2002-03-26|break-before=page for table inserts empty page | | 7496|New|Nor|2002-03-26|The table header borders are not adjusted to the b| | 7525|New|Cri|2002-03-27|table with spans inside a list-block | | 7919|New|Cri|2002-04-10|problem to use attribute linefeed-treatment and li| | 8003|Ass|Maj|2002-04-12|FopImageFactory never releases cached images | |
cvs commit: xml-fop/src/java/org/apache/fop/render/pdf PDFRenderer.java
gmazza 2003/10/26 11:29:14
Modified:src/java/org/apache/fop/layoutmgr TraitSetter.java
src/java/org/apache/fop/render/pdf PDFRenderer.java
Log:
1. TraitSetter modified to provide padding properties for regions.
2. PDFRenderer modified to take into account region borders and region padding
when rendering text. (Possibly temporary solution--may need to move code
to base AbstractRenderer in future.) Work incomplete--will need to also reduce
line length accordingly to account for region borders and padding.
Revision ChangesPath
1.3 +20 -0 xml-fop/src/java/org/apache/fop/layoutmgr/TraitSetter.java
Index: TraitSetter.java
===
RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/layoutmgr/TraitSetter.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- TraitSetter.java 12 Aug 2003 18:02:45 - 1.2
+++ TraitSetter.java 26 Oct 2003 19:29:14 - 1.3
@@ -148,6 +148,26 @@
if (bps.width != 0) {
curBlock.addTrait(Trait.BORDER_END, bps);
}
+
+int padding = bordProps.getPadding(CommonBorderAndPadding.START, false);
+if (padding != 0) {
+curBlock.addTrait(Trait.PADDING_START, new java.lang.Integer(padding));
+}
+
+padding = bordProps.getPadding(CommonBorderAndPadding.END, false);
+if (padding != 0) {
+curBlock.addTrait(Trait.PADDING_END, new java.lang.Integer(padding));
+}
+
+padding = bordProps.getPadding(CommonBorderAndPadding.BEFORE, false);
+if (padding != 0) {
+curBlock.addTrait(Trait.PADDING_BEFORE, new java.lang.Integer(padding));
+}
+
+padding = bordProps.getPadding(CommonBorderAndPadding.AFTER, false);
+if (padding != 0) {
+curBlock.addTrait(Trait.PADDING_AFTER, new java.lang.Integer(padding));
+}
}
private static BorderProps getBorderProps(CommonBorderAndPadding bordProps, int
side) {
1.19 +63 -20xml-fop/src/java/org/apache/fop/render/pdf/PDFRenderer.java
Index: PDFRenderer.java
===
RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/render/pdf/PDFRenderer.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- PDFRenderer.java 21 Sep 2003 20:56:24 - 1.18
+++ PDFRenderer.java 26 Oct 2003 19:29:14 - 1.19
@@ -227,6 +227,16 @@
private StringBuffer wordAreaPDF = new StringBuffer();
/**
+ * Offset for rendering text, taking into account borders and padding
+ */
+protected int BPMarginOffset = 0;
+
+/**
+ * Offset for rendering text, taking into account borders and padding
+ */
+protected int IPMarginOffset = 0;
+
+/**
* create the PDF renderer
*/
public PDFRenderer() {
@@ -467,7 +477,6 @@
this.pdfDoc.output(ostream);
}
-
/**
* @see org.apache.fop.render.AbstractRenderer#startVParea(CTM)
*/
@@ -494,6 +503,21 @@
}
/**
+ * Handle block traits.
+ * The block could be any sort of block with any positioning
+ * so this should render the traits such as border and background
+ * in its position.
+ *
+ * @param block the block to render the traits
+ */
+protected void handleBlockTraits(Block block) {
+float startx = currentIPPosition / 1000f;
+float starty = currentBPPosition / 1000f;
+drawBackAndBorders(block, startx, starty,
+ block.getWidth() / 1000f, block.getHeight() / 1000f);
+}
+
+/**
* Handle the traits for a region
* This is used to draw the traits for the given page region.
* (See Sect. 6.4.1.2 of XSL-FO spec.)
@@ -510,22 +534,35 @@
Trait.Background back;
back = (Trait.Background)region.getTrait(Trait.BACKGROUND);
*/
-drawBackAndBorders(region, startx, starty, width, height);
-}
-/**
- * Handle block traits.
- * The block could be any sort of block with any positioning
- * so this should render the traits such as border and background
- * in its position.
- *
- * @param block the block to render the traits
- */
-protected void handleBlockTraits(Block block) {
-float startx = currentIPPosition / 1000f;
-float starty = currentBPPosition / 1000f;
-drawBackAndBorders(block, startx, starty,
- block.getWidth() / 1000f, block.getHeight() / 1000f);
+if (region.getRegion().getRegionClass() ==
org.apache.fop.fo.pagination.Region.BODY_CODE)
+
DO NOT REPLY [Bug 24017] - NullPointerException when using fo:list-item-label
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24017. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24017 NullPointerException when using fo:list-item-label --- Additional Comments From [EMAIL PROTECTED] 2003-10-27 03:06 --- Actually, Andreas, the WONTFIX was with reference to a bug I found while trying (unsuccessfully) to duplicate the NPE, as I described while marking it as such. Furthermore, it really is unacceptable for FOP to NPE based on an incorrect FO input, no matter how mangled the FO is--it should exit cleanly. The fact that an NPE occurred was the primary issue, not whether his FO was useful or even valid. Perhaps WORKSFORME would have been a better designation had I not have found a separate bug on my own. I thank Lars for taking the time to write this bug report. And should he be able to trip up FOP with poorly written/invalid FO files (in particular for the 1.0 version), such bugs would be highly welcome (although we may not be able to get to them immediately). It's important FOP is able to exit gracefully--or at least not NPE!--when those occur. Glen
Re: Batik hanging on FOP 0.20.x nightly/1.0 dev release.
--- Thomas DeWeese [EMAIL PROTECTED] wrote: At least one of the issues is with the PDFGraphics2D. in PDFGraphics2D.java:632 in draw(shape s). There is a check for a newTransform which inexplicably decides that if the new transform is the Identity transform there is no change. IIRC that was because the transform would have no effect. A transform in PDF appends to the current transform rather than setting the transform. Thanks, Thomas, for taking a look at the code for us. Andreas added your comments to the Bugzilla report so they won't be lost. We'll get to these issues (hopefully!) soon. Glen Keiron
