Bug report for Fop [2004/03/07]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 635|Opn|Nor|2001-02-18|Doesn't support id= attribute in fo:page-sequence | | 953|Opn|Nor|2001-03-12|Incorrect hyperlinks area rendering in justified t| | 1063|New|Nor|2001-03-21|fop does not handle large fo files| | 1180|New|Maj|2001-04-02|Problem with monospaced font | | 1859|Opn|Min|2001-05-22|org.apache.fop.apps.Driver.reset() doesn't fully r| | 1998|New|Nor|2001-06-05|linefeed-treatment not understood | | 2150|Ass|Maj|2001-06-13|New page with a table-header but without any tabl| | 2475|Ass|Nor|2001-07-06|Borders don't appear to work in fo:table-row| | 2740|New|Maj|2001-07-23|multi-page tables sometimes render badly | | 2909|New|Maj|2001-07-30|Gradient render error | | 2964|Ass|Nor|2001-08-02|problems with height of cells in tables | | 2988|New|Maj|2001-08-03|0.19: list-item-label does not stick to list-item-| | 3044|Ass|Maj|2001-08-08|keep-together not functioning | | 3280|New|Nor|2001-08-27|PCL Renderer doesn't work | | 3305|Opn|Nor|2001-08-28|list-block overlapping footnote body | | 3497|New|Maj|2001-09-07|id already exists error when using span=all attr| | 3824|New|Blk|2001-09-25|MIF option with tables| | 4030|New|Nor|2001-10-08|IOException creating Postscript with graphics on S| | 4126|New|Nor|2001-10-12|FontState.width() returns pts instead of millipts | | 4226|New|Nor|2001-10-17|The orphans property doesn't seem to work | | 4388|New|Nor|2001-10-24|Nullpointer exception in the construction of new D| | 4415|New|Nor|2001-10-25|scaling=uniform does not work on images... | | 4510|New|Nor|2001-10-30|fo:inline common properties ignored? | | 4535|New|Maj|2001-10-31|PCL renderer 1.13 not rendering SVG | | 4767|New|Nor|2001-11-09|SVG text is distored in PDF output| | 5001|New|Nor|2001-11-21|content-width and content-height ignored? | | 5010|New|Enh|2001-11-21|Better error reporting needed | | 5047|Ass|Nor|2001-11-23|Dotted border style is not supported | | 5124|New|Maj|2001-11-27|fo:block-container is not rendered properly using | | 5335|Opn|Min|2001-12-10|Text with embedded CID fonts not retrievable from | | 5655|Ass|Nor|2002-01-02|text-decoration cannot take multiple values | | 6094|Opn|Maj|2002-01-29|0.20.3rc hangs in endless loop| | 6237|Opn|Nor|2002-02-05|#xFB01 (fi ligature) produces a sharp? | | 6305|New|Nor|2002-02-07|Using fo:table-and-caption results in empty output| | 6427|New|Enh|2002-02-13|Adding additional Type 1 fonts problem| | 6437|New|Maj|2002-02-13|Tables without fo:table-column don't render | | 6483|New|Nor|2002-02-15|Table, Loop, footer could not fit on page, moving| | 6844|New|Nor|2002-03-04|No line breaks inserted in list-item-label| | 6918|New|Enh|2002-03-06|reference-orientation has no effect | | 6929|New|Nor|2002-03-06|Cells border hidden by cells background | | 6997|New|Nor|2002-03-09|[PATCH] Row-spanned row data breaks over a page wi| | 7140|New|Enh|2002-03-15|page-position attribute set to last on condition| | 7241|New|Nor|2002-03-19|keep-with-previous, keep-with-next only working on| | 7283|New|Nor|2002-03-20|Table border misaligned when using margin-left in | | 7337|New|Nor|2002-03-21|border around external image leaves empty space | | 7487|New|Nor|2002-03-26|break-before=page for table inserts empty page | | 7496|New|Nor|2002-03-26|The table header borders are not adjusted to the b| | 7525|New|Cri|2002-03-27|table with spans inside a list-block | | 7919|New|Cri|2002-04-10|problem to use attribute linefeed-treatment and li| | 8003|Ass|Maj|2002-04-12|FopImageFactory never releases cached images | | 8050|New|Nor|2002-04-13|Soft hyphen (shy;) is not handled properly | |
cvs commit: xml-fop/src/java/org/apache/fop/fo/flow Block.java
gmazza 2004/03/07 09:52:43
Modified:src/java/org/apache/fop/fo FOText.java
src/java/org/apache/fop/fo/flow Block.java
Log:
Fix of leading-space problem in HEAD. (A single leading space of the first
inline child of the block object was being incorrectly retained.)
Revision ChangesPath
1.16 +0 -4 xml-fop/src/java/org/apache/fop/fo/FOText.java
Index: FOText.java
===
RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/fo/FOText.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- FOText.java 1 Mar 2004 23:50:26 - 1.15
+++ FOText.java 7 Mar 2004 17:52:43 - 1.16
@@ -168,10 +168,6 @@
} else if (curIndex == length) {
curIndex = --length;
}
-// Temporary until leading space problem in 1.0 fixed
-// System.out.println(\n\nremove called: ca = \ +
-// new String(ca) + \, length/node length: + length
-// + , + ca.length);
}
1.13 +17 -0 xml-fop/src/java/org/apache/fop/fo/flow/Block.java
Index: Block.java
===
RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/fo/flow/Block.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- Block.java27 Feb 2004 17:44:23 - 1.12
+++ Block.java7 Mar 2004 17:52:43 - 1.13
@@ -246,6 +246,11 @@
if (firstInlineChild != null) {
boolean bInWS = false;
boolean bPrevWasLF = false;
+
+/* bSeenNonWSYet is an indicator used for trimming all leading
+ whitespace for the first inline child of the block
+*/
+boolean bSeenNonWSYet = false;
RecursiveCharIterator charIter =
new RecursiveCharIterator(this, firstInlineChild);
LFchecker lfCheck = new LFchecker(charIter);
@@ -279,7 +284,13 @@
(bPrevWasLF || lfCheck.nextIsLF( {
charIter.remove();
} else {
+// this is to retain a single space between words
bInWS = true;
+// remove the space if no word in block
+// encountered yet
+if (!bSeenNonWSYet) {
+charIter.remove();
+}
}
}
break;
@@ -300,6 +311,11 @@
} else {
if (bWScollapse) {
bInWS = true;
+// remove the linefeed if no word in block
+// encountered yet
+if (!bSeenNonWSYet) {
+charIter.remove();
+}
}
charIter.replaceChar('\u0020');
}
@@ -323,6 +339,7 @@
case CharUtilities.NONWHITESPACE:
/* Any other character */
bInWS = bPrevWasLF = false;
+bSeenNonWSYet = true;
lfCheck.reset();
break;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Clay Leeds for Committer
Clay Leeds wrote: Perhaps I might even pick up a Java book and figure out how to add command line parameters to FOP (I'm hoping I won't have to figure out the issue that Glen and Andreas raised[1] in February, though...:-p). Sure, you'll have plenty of Java coding experience if you wish--there is truly no end to it. (You may also wish to take a look at Cocoon, in particular (1) the page showing production sites using it, and (2) its interesting Hello World servlet, which shows the many output devices that Cocoon can use to render the phrase Hello World. Besides giving you better insight in how FOP is used, Cocoon can be a powerful tool for those, like you, who already have XSLT and Web Design knowledge.) Thanks for the votes of confidence! I look forward to serving the FOP community in any way that I can (and right now, I guess that means as the Web Maestro!)... BTW, another fun thing on your plate--it would nice if you could also switch us from the blue Forrest skin [1] to the white one [2]--the latter looks much more sleeker/professional I think. Comments from others? [1] http://xml.apache.org/fop/ [2] http://ws.apache.org/axis/
FOP web site update
I thought you'd like to see a brief update on the FOP web site trials and tribulations. I've uploaded the web portion of the output of a forrest run here: http://homepage.mac.com/webmaestro/xml-fop_site/site/index.html Of special note: - Breadcrumb Trail believe it or not, the breadcrumb is actually working as it is supposed to (yeah!), and we should soon have the problem fixed on our site. It looks funny, because it's in the /webmaestro/xml-fop_site/site/ path (and each dir/ leaves a 'breadcrumb'). This problem can be easily fixed, by merely uploading a new version of the breadcrumb.js file. - Whole Site HTML - Whole Site PDF kinda self-explanatory... :-) I'm still having issues with 'forrest' BUILD FAILED errors that I keep banging my head against. We're almost there, though (I can almost smell it!). Many of the errors relate to such things as having forrest pass through files untouched (like *.svg), and how to deal with them. I've also had problems with our left-side navigation on the Development, Design Alt Design tabs. Those problems mainly relate to pages which are linked in multiple tabs (Development Alt Design tabs each have some Design links in there navigation links on the left). It might be easier to re-think that system (which is confusing, and IIRC gave Victor some headaches when he was doing this). On a somewhat related note, I'd also like to update the FO templates used to create the PDFs for Forrest, as I believe they provide too much margin all around (read extra reams of paper printer when ever printing is initiated). Almost there! Web Maestro Clay
Re: FOP web site update
Nice job, Clay--I'm very happy with the whole site PDF in particular. Jeremias, would you please request write access for Clay now? Thanks, Glen Clay Leeds wrote: I thought you'd like to see a brief update on the FOP web site trials and tribulations. I've uploaded the web portion of the output of a forrest run here: http://homepage.mac.com/webmaestro/xml-fop_site/site/index.html Of special note: - Breadcrumb Trail believe it or not, the breadcrumb is actually working as it is supposed to (yeah!), and we should soon have the problem fixed on our site. It looks funny, because it's in the /webmaestro/xml-fop_site/site/ path (and each dir/ leaves a 'breadcrumb'). This problem can be easily fixed, by merely uploading a new version of the breadcrumb.js file. - Whole Site HTML - Whole Site PDF kinda self-explanatory... :-) I'm still having issues with 'forrest' BUILD FAILED errors that I keep banging my head against. We're almost there, though (I can almost smell it!). Many of the errors relate to such things as having forrest pass through files untouched (like *.svg), and how to deal with them. I've also had problems with our left-side navigation on the Development, Design Alt Design tabs. Those problems mainly relate to pages which are linked in multiple tabs (Development Alt Design tabs each have some Design links in there navigation links on the left). It might be easier to re-think that system (which is confusing, and IIRC gave Victor some headaches when he was doing this). On a somewhat related note, I'd also like to update the FO templates used to create the PDFs for Forrest, as I believe they provide too much margin all around (read extra reams of paper printer when ever printing is initiated). Almost there! Web Maestro Clay
cvs commit: xml-fop/src/documentation/content/xdocs news.xml
gmazza 2004/03/07 15:29:23 Modified:src/documentation/content/xdocs news.xml Log: Add Clay to news page. Revision ChangesPath 1.19 +6 -2 xml-fop/src/documentation/content/xdocs/news.xml Index: news.xml === RCS file: /home/cvs/xml-fop/src/documentation/content/xdocs/news.xml,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- news.xml 2 Mar 2004 21:15:35 - 1.18 +++ news.xml 7 Mar 2004 23:29:23 - 1.19 @@ -25,6 +25,10 @@ /header body section + title7 March 2004 - New Committer/title + pWelcome Web Maestro Clay Leeds!/p +/section +section title10 January 2004 - New Committers/title pWelcome Chris Bowditch and Andreas Delmelle!/p /section - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
