Re: remove layout package?

2004-09-06 Thread Chris Bowditch
Glen Mazza wrote: Team, With the recent removal (who did that? ;) of the unused layout.AreaClass and layout.TextState classes, the fop.layout package is now empty save for its hyphenation subpackage. I'd like to drop the layout package and make hyphenation a top-level package (i.e.,

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-06 Thread Jeremias Maerki
I'm sorry, Glen, but I think you will have to revisit that one. If I'm not absolutely wrong, this will break multi-threading capabilities. On 06.09.2004 20:28:17 gmazza wrote: gmazza 2004/09/06 11:28:17 Modified:src/java/org/apache/fop/fo FONode.java FOTreeBuilder.java

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-06 Thread Glen Mazza
Please elaborate. Jeremias Maerki wrote: I'm sorry, Glen, but I think you will have to revisit that one. If I'm not absolutely wrong, this will break multi-threading capabilities. On 06.09.2004 20:28:17 gmazza wrote: gmazza 2004/09/06 11:28:17 Modified:src/java/org/apache/fop/fo

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-06 Thread Jeremias Maerki
Ok, the FOEventHandler is created in the FOTreeBuilder. One FO TreeBuilder is instantiated per processing run. The FOEventHandler is set on FONode's static variable during startDocument(). The FOEventHandler keeps track of used fonts, number of pages, tracking IDs etc. which are all relevant to

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-06 Thread Jeremias Maerki
To be a bit more positive and not just criticizing, this could probably be solved using a ThreadLocal [1] which would make the whole thing almost as handy as a normal static variable but thread-safe. But I've never done this myself, yet, so I can't talk out of experience. Just an additional 0.05

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-06 Thread Glen Mazza
Jeremias Maerki wrote: Ok, the FOEventHandler is created in the FOTreeBuilder. One FO TreeBuilder is instantiated per processing run. The FOEventHandler is set on FONode's static variable during startDocument(). The FOEventHandler keeps track of used fonts, number of pages, tracking IDs etc. which

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-06 Thread Jeremias Maerki
On 06.09.2004 22:31:24 Glen Mazza wrote: Jeremias Maerki wrote: Ok, the FOEventHandler is created in the FOTreeBuilder. One FO TreeBuilder is instantiated per processing run. The FOEventHandler is set on FONode's static variable during startDocument(). The FOEventHandler keeps track of

Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-06 Thread Glen Mazza
Jeremias Maerki wrote: On 06.09.2004 22:31:24 Glen Mazza wrote: Jeremias Maerki wrote: Ok, the FOEventHandler is created in the FOTreeBuilder. One FO TreeBuilder is instantiated per processing run. The FOEventHandler is set on FONode's static variable during startDocument(). The