RE: AFP Renderer Patch

2004-09-13 Thread Townsend, Pete
Ok, I did try the command line option as well (with the version of CVS
shipped with WinCVS) - Is my problem related to the fact that these are new
java classes/packages - there seems to be a number of comments that diff
will not include new files?

I tried with the -N argument but this still didn't include the new files.
(cvs diff -wuNr fop-0_20_2-maintain xml-fop  patch.txt)

Pete.

-Original Message-
From: Glen Mazza [mailto:[EMAIL PROTECTED]
Sent: 13 September 2004 03:46
To: [EMAIL PROTECTED]; Pete Townsend
Subject: Re: AFP Renderer Patch


I stay away from WinCVS and just use the command line:

c:\cvs diff -u  c:\mypatch.txt

Thanks,
Glen

--- Pete Townsend [EMAIL PROTECTED] wrote:
 I'm trying to generate the patch for the AFP
 renderer, something I've not done before!
 



This e-mail (and any attachments) may contain privileged and/or confidential 
information. If you are not the intended recipient please do not disclose, copy, 
distribute, disseminate or take any action in reliance on it. If you have received 
this message in error please reply and tell us and then delete it. Should you wish to 
communicate with us by e-mail we cannot guarantee the security of any data outside our 
own computer systems. For the protection of Legal  General's systems and staff, 
incoming emails will be automatically scanned.

Any information contained in this message may be subject to applicable terms and 
conditions and must not be construed as giving investment advice within or outside the 
United Kingdom.

Legal  General Group PLC, Temple Court, 11 Queen Victoria Street, London, EC4N 4TP. 
Registered in England no: 1417162

Legal  General Group Plc is a holding company, subsidiary undertakings of which are 
fully authorised as appropriate under the Financial Services and Markets Act in 
respect of their investment activities in the UK.



Re: AFP Renderer Patch

2004-09-13 Thread Jeremias Maerki
Yes, it's probably best if you include the new files in a ZIP file and
attach that separately.

On 13.09.2004 11:20:37 Townsend, Pete wrote:
 Ok, I did try the command line option as well (with the version of CVS
 shipped with WinCVS) - Is my problem related to the fact that these are new
 java classes/packages - there seems to be a number of comments that diff
 will not include new files?
 
 I tried with the -N argument but this still didn't include the new files.
 (cvs diff -wuNr fop-0_20_2-maintain xml-fop  patch.txt)


Jeremias Maerki



Re: Project offo distributes hyphenation pattern files for FOP

2004-09-13 Thread Clay Leeds
Thanks for setting this up, Simon. Please let me know if there is 
anything I can do to help.

Web Maestro Clay
Simon Pepping wrote:
Dear FOP users,
In February 2004 a large number of hyphenation pattern files were
removed from FOP's CVS repository due to licensing issues. These
hyphenation patterns were contributed to FOP under licenses which
allowed their free distribution, but under conditions which were felt
to be in contradiction with the Apache license, under which FOP is
distributed. Most files are licensed under the LaTeX Project Public
License (http://www.latex-project.org/lppl/index.html), which requires
that no modified version be published under the name of the original
source file. For details see the FOP wiki page
(http://nagoya.apache.org/wiki/apachewiki.cgi?FOPAudits/March2003).
I am please to announce that the hyphenation pattern files for FOP are
now made available by the project `Objects for Formatting Objects'
(offo) (http://offo.sourceforge.net/). They can be downloaded from
offo's project page (http://sourceforge.net/projects/offo/). At this
moment the homepage of the project is not yet ready. Therefore the
overview of the hyphenation pattern files and their licenses is
available from my web site,
http://www.leverkruid.nl/FOP/hyphenation.html. It is also contained in
the package file.
Regards, Simon
--
Peter B. West http://cv.pbw.id.au/



Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-13 Thread Simon Pepping
On Tue, Sep 07, 2004 at 08:47:07PM +0200, Jeremias Maerki wrote:
 
 Question to everyone: We currently don't have a multi-threaded design
 like Peter West's approach. Can anyone think of a reason that all the
 FO-building and layouting process for one processing run may run within
 more than one thread? I don't think threre is one if the SAX event
 delivery is always within one thread (big if). If there isn't I believe
 we could make use of a ThreadLocal to put some shared data that will be
 easily accessible from all involved components. Initialize the
 ThreadLocal in startDocument() and clear it in endDocument(). I realize
 there's a certain risk involved but it could really shorten the access
 ways for shared data especially for the FO tree, if that's really a
 problem (I'd also like to know if it really is. Anyone?).

PageLayoutManager has a seed for multithreading; it implements
Runnable. The idea is to let each page sequence run in its own
thread. It has not been worked out. Using a ThreadLocal for
FOInputHandler would make this more difficult. This is not a typical
usage case for ThreadLocal as mentioned in the java documentation. I
do not find it an attractive idea.

Regards, Simon

-- 
Simon Pepping
home page: http://www.leverkruid.nl



Re: Project offo distributes hyphenation pattern files for FOP

2004-09-13 Thread Simon Pepping
On Mon, Sep 13, 2004 at 08:03:08AM -0700, Clay Leeds wrote:
 Thanks for setting this up, Simon. Please let me know if there is 
 anything I can do to help.

Thanks for the offer. It was some work to set this up, although I
could build mostly on Jeremias' earlier work. I expect that from now
on the project will not give me much work. The only thing that needs
to happen, is a nicer design for the home page and the page
hyphenation.html. Perhaps a challenge for the web master?

It might be a good idea if you or someone else of the FOP team would
also be a project administrator, to make it less dependent on one
person.

Regards, Simon

-- 
Simon Pepping
home page: http://www.leverkruid.nl



Re: Project offo distributes hyphenation pattern files for FOP

2004-09-13 Thread Simon Pepping
On Sun, Sep 12, 2004 at 11:35:42AM +1000, Peter B. West wrote:
 Moved from fop-user.
 
 Simon,
 
 Under which license have you set up the SourceForge project?

I stated that contributions with any OSI-approved license or in the
Public Domain were acceptable. The discussion to get the idea
explained and this license statement accepted was lengthy. I took care
to state each license carefully in the covering page
http://sourceforge.net/offo/hyphenation.html. For a large part thanks
to Jeremias earlier work.

Simon 

-- 
Simon Pepping
home page: http://www.leverkruid.nl



Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination Root.java

2004-09-13 Thread Glen Mazza
--- Simon Pepping [EMAIL PROTECTED] wrote:
 
 PageLayoutManager has a seed for multithreading; it
 implements
 Runnable. The idea is to let each page sequence run
 in its own
 thread. It has not been worked out. 

I'm uncertain of its benefit (that which calls FOP
should do the multithreading, not FOP itself, no? 
e.g., a servlet generating 10 reports, one on each
thread, rather than have the servlet and FOP both
multithreading at the same time.)  I'm inclined to
have it removed, lest it turn into another distraction
from our work.  Anyway, if Xalan isn't
multithreading--and I don't believe they are--then I'm
unsure that we should be.

Glen



Re: DO NOT REPLY [Bug 29124] - New line breaking algorithm

2004-09-13 Thread Luca Furini
Simon Pepping wrote:

 Still to be done:

 - Resolve the regressions mentioned above.

As concerns leader with use content, patch created and successfully tested.
The ContentLM calls getNextKnuthElements on his child InlineStackingLM, uses
the returned elements to calculate the pattern width and returns them to the
LeaderLM. The LeaderLM uses them when calling addAreas.

I also found a bug affecting leaders with leader-pattern = dots: the
TextArea with the dot (created in LeaderLM.getLeaderInlineArea) had width =
0; calling setWidth() fixes this problem.
There is still a little difference between a leader with leader-pattern =
dots and one with use-content and a single dot as content: the former is
placed a bit over the baseline, but I couldn't find the reason.

Note that using the fo file xml-fop/examples/fo/basic/leader.fo to test the
patch you won't see the leaders with leader-pattern = use-content, as they
don't have a width property and the default .opt value (12pt) is  than the
pattern width. Setting a larger width, or text-align-last = justify, makes
the leaders visible.

 - I support the idea to create an InlineLayoutManager interface, which
   extends LayoutManager.

Done, same patch (or maybe I should create a different one?). I also
removed the getWordSpaceIPD() method, as I find out that a constant value
works better: the LineLM and its child must use the same value, or the
result is not always correct.

 1.
 Can we be sure that U+A is always alone or the first item in a
 textArray; does this not depend on the Parser, how it calls the SAX
 characters method?

Right, it's better to handle the most general case.
The patch will fix this too.

I will try to fix the other points reported by Simon as soon as possible.

Regards
Luca





Re: Project offo distributes hyphenation pattern files for FOP

2004-09-13 Thread Clay Leeds
On Sep 13, 2004, at 11:51 AM, Simon Pepping wrote:
On Mon, Sep 13, 2004 at 08:03:08AM -0700, Clay Leeds wrote:
Thanks for setting this up, Simon. Please let me know if there is
anything I can do to help.
Thanks for the offer. It was some work to set this up, although I
could build mostly on Jeremias' earlier work. I expect that from now
on the project will not give me much work. The only thing that needs
to happen, is a nicer design for the home page and the page
hyphenation.html. Perhaps a challenge for the web master?
I'd be happy to spend some time on this. I've got a couple ideas and 
will see if I can't come up with something soon.

It might be a good idea if you or someone else of the FOP team would
also be a project administrator, to make it less dependent on one
person.
Regards, Simon
Again, I'd be happy to oblige. I can also be another project 
administrator if you'd like.

Web Maestro Clay


DO NOT REPLY [Bug 31206] New: - Improvements over the new line breaking algorithm

2004-09-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31206.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31206

Improvements over the new line breaking algorithm 

   Summary: Improvements over the new line breaking algorithm
   Product: Fop
   Version: 1.0dev
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: page-master/layout
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Some improvements over the new line breaking algorithm (see also Simon's last 
comment to bug 29124):

- a new interface InlineLayoutManager, implemented by LeafNodeLM, 
InlineStackingLM and ContentLM

- leaders with pattern use-content and dots now works

- better handling of preserved linefeeds

I'm going to attach the proposed patch and a few test fo files.
Regards
Luca


DO NOT REPLY [Bug 31206] - Improvements over the new line breaking algorithm

2004-09-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31206.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31206

Improvements over the new line breaking algorithm 





--- Additional Comments From [EMAIL PROTECTED]  2004-09-13 20:28 ---
Created an attachment (id=12716)
patch file


DO NOT REPLY [Bug 31206] - Improvements over the new line breaking algorithm

2004-09-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31206.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31206

Improvements over the new line breaking algorithm 





--- Additional Comments From [EMAIL PROTECTED]  2004-09-13 20:29 ---
Created an attachment (id=12717)
Fo file: leaders with use-content and dots


DO NOT REPLY [Bug 31206] - Improvements over the new line breaking algorithm

2004-09-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31206.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31206

Improvements over the new line breaking algorithm 





--- Additional Comments From [EMAIL PROTECTED]  2004-09-13 20:30 ---
Created an attachment (id=12718)
Fo file: centered text with larger or smaller inlines


DO NOT REPLY [Bug 31206] - Improvements over the new line breaking algorithm

2004-09-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31206.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31206

Improvements over the new line breaking algorithm

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Improvements over the new   |Improvements over the new
   |line breaking algorithm |line breaking algorithm



--- Additional Comments From [EMAIL PROTECTED]  2004-09-13 20:33 ---
I forgot to say that I fix a bug in the TextLM: KnuthBoxes generated by the 
TLM had height = 0, so the line height was not always correct.