Re: Exception hierarchy.

2004-10-28 Thread Finn Bock
[Glen] I'm not clear why you didn't derive ValidationException from SAXParseException. I know the locator is already present in FOPException, but absent the subclass from SAXParseException, it ends up being a different Locator object, i.e., user code that would handle a SAXParseException can't

DO NOT REPLY [Bug 31899] - [PATCH] Exception hierarchy.

2004-10-28 Thread bugzilla
/show_bug.cgi?id=31899 [PATCH] Exception hierarchy. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution

Re: Exception hierarchy.

2004-10-28 Thread Glen Mazza
I see. Thanks for the explanation. Glen --- Finn Bock [EMAIL PROTECTED] wrote: [Glen] I'm not clear why you didn't derive ValidationException from SAXParseException. I know the locator is already present in FOPException, but absent the subclass from SAXParseException, it ends up

Re: Exception hierarchy.

2004-10-27 Thread Finn Bock
[Andreas] It seems more about not throwing SAXParseExceptions, but catching them and throwing a FOPException instead. Isn't that the issue? That a 'missingChildElementError' is actually not a SAXParseException... because it has nothing to do with SAX in itself [Glen] SAXParseExceptions would

RE: Exception hierarchy.

2004-10-27 Thread Andreas L. Delmelle
-Original Message- From: Glen Mazza [mailto:[EMAIL PROTECTED] snip / As the definition of its parent SAXException[1] states, This class can contain basic error or warning information from either the XML parser *or the application* So it can be used within FOP. True, but I still

Re: Exception hierarchy.

2004-10-27 Thread J.Pietschmann
Finn Bock wrote: ValidateException is the right choice of exception when the FO file doesn't follow the content model. Nitpick: s/FO file/FO processor input document/ J.Pietschmann

Re: Exception hierarchy.

2004-10-27 Thread Glen Mazza
Finn, I am more in agreement with your patch. +0 as-is. --- Finn Bock [EMAIL PROTECTED] wrote: [Finn] [Glen] SPE might be considered the XML parsing equivalent of a syntax error that would occur for a code compilation error. Right, errors at the XML level. It *can* be used

RE: Exception hierarchy.

2004-10-27 Thread Glen Mazza
--- Andreas L. Delmelle [EMAIL PROTECTED] wrote: You might want to try searching Xalan source code BTW: I don't think Xalan's actually throwing them anywhere, it merely *uses* them in the sense of 'catch and possibly throw a TransformerException' or define a method with 'throws

DO NOT REPLY [Bug 31899] New: - [PATCH] Exception hierarchy.

2004-10-26 Thread bugzilla
/show_bug.cgi?id=31899 [PATCH] Exception hierarchy. Summary: [PATCH] Exception hierarchy. Product: Fop Version: 1.0dev Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component

DO NOT REPLY [Bug 31899] - [PATCH] Exception hierarchy.

2004-10-26 Thread bugzilla
/show_bug.cgi?id=31899 [PATCH] Exception hierarchy. --- Additional Comments From [EMAIL PROTECTED] 2004-10-26 18:21 --- Created an attachment (id=13223) Unified diff against head

Exception hierarchy.

2004-10-26 Thread Finn Bock
, the exceptions used in FOP should form a structure where concrete subclass exception are thrown and a common superclass can be used for catching all the different exceptions. My proposal for the exception hierarchy look like this: - SAXException - FOPException - ValidateException

Re: Exception hierarchy.

2004-10-26 Thread Jeremias Maerki
. Second, the exceptions used in FOP should form a structure where concrete subclass exception are thrown and a common superclass can be used for catching all the different exceptions. My proposal for the exception hierarchy look like this: - SAXException - FOPException

Re: Exception hierarchy.

2004-10-26 Thread Glen Mazza
with the FO tree. Second, the exceptions used in FOP should form a structure where concrete subclass exception are thrown and a common superclass can be used for catching all the different exceptions. My proposal for the exception hierarchy look like this: - SAXException

Re: Exception hierarchy.

2004-10-26 Thread Finn Bock
[Glen] I'm confused--why is OK to throw SAXExceptions but not its child SAXParseExceptions? With the latter, it just holds locator information necessary to pinpoint the problem for the user. Please elaborate. The way I see it SAXException is the exception used to communicate across the

RE: Exception hierarchy.

2004-10-26 Thread Andreas L. Delmelle
-Original Message- From: Glen Mazza [mailto:[EMAIL PROTECTED] Hi Glen, I'm confused--why is OK to throw SAXExceptions but not its child SAXParseExceptions? With the latter, it just holds locator information necessary to pinpoint the problem for the user. Please elaborate. It

RE: Exception hierarchy.

2004-10-26 Thread Victor Mote
Andreas L. Delmelle wrote: What about: - LayoutException - AreaException - RenderException FWIW, this is exactly where FOray is headed. You and Finn are on the right track. Victor Mote

RE: Exception hierarchy.

2004-10-26 Thread Glen Mazza
Hello Andreas! (and others) --- Andreas L. Delmelle [EMAIL PROTECTED] wrote: -Original Message- From: Glen Mazza [mailto:[EMAIL PROTECTED] Hi Glen, I'm confused--why is OK to throw SAXExceptions but not its child SAXParseExceptions? With the latter, it just holds