[ https://issues.apache.org/jira/browse/FOP-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974407#comment-13974407 ]
Vincent Hennebert commented on FOP-2293: ---------------------------------------- Hi Seifeddine, Thanks for your patch. I've applied it in rev. [1588548|http://svn.apache.org/r1588548]. The test cases look really good, simple and to the point. I think that apart from small details (the value of the auto-toggle property, among others), this work is ready to be merged to trunk. Is there anything you would like to add or shall I launch the vote? Ideally the documentation would be made a bit more detailed, with a slightly more complex example and illustrations of the cases where no variant is selected, or another than the first one, etc. But I don't see this as a blocker for the vote. Thanks, Vincent > Whitespace management extension > ------------------------------- > > Key: FOP-2293 > URL: https://issues.apache.org/jira/browse/FOP-2293 > Project: Fop > Issue Type: New Feature > Components: general > Affects Versions: trunk > Reporter: Seifeddine Dridi > Priority: Minor > Labels: XSL-FO > Fix For: trunk > > Attachments: FO_multi-switch_best-fit_ext_rev10.patch, > FO_multi-switch_best-fit_ext_rev11.patch, > FO_multi-switch_best-fit_ext_rev12.patch, > FO_multi-switch_best-fit_ext_rev13.patch, > FO_multi-switch_best-fit_ext_rev2.patch, > FO_multi-switch_best-fit_ext_rev3.patch, > FO_multi-switch_best-fit_ext_rev4.patch, > FO_multi-switch_best-fit_ext_rev5.patch, > FO_multi-switch_best-fit_ext_rev6.patch, > FO_multi-switch_best-fit_ext_rev7.patch, > FO_multi-switch_best-fit_ext_rev8.patch, > FO_multi-switch_best-fit_ext_rev9.patch, FO_multi-switch_test.fo, > FO_multi-switch_with_best-fit_extension.patch, bestfit.fo, > bug_page_ipd_change.fo, doc.pdf, empty-last-page.fo, > multi-switch-testcases.zip, multi-switch_bestfit.fo, > multiple-feasible-nodes.fo, patch-rev1.1.patch, patch-rev1.patch, > patch-rev2.patch, patch.patch, rev11_bug.fo, two-valid-variants.fo > > > I have been working on an extension for whitespace management, similar to > what's described here: > http://wiki.apache.org/xmlgraphics-fop/WhitespaceManagement > The logic of the extension is very simple: the user defines a set of > alternatives that he wishes to insert at the end of a page, then if there is > enough space left, FOP will pick the alternative that best matches the user's > selection criteria (first fit, smallest fit, biggest fit). > This is my first work on FOP and it took me almost 2 months to reach this > stage in development. But it's not the end of course, so I'm relying on your > feedback to improve it. > Thank you -- This message was sent by Atlassian JIRA (v6.2#6252)