Re: Findbug exclusions

2012-01-19 Thread Pascal Sancho
Hi Chris, found just one duplication: Match Class name=org.apache.fop.afp.AFPPaintingState/ Field name=colorConverter/ Bug pattern=SE_BAD_FIELD_STORE/ /Match using following template: xsl:template match=Match xsl:if test=preceding-sibling::Match[ Class/@name = current()/Class/@name

Re: Findbug exclusions

2012-01-19 Thread Pascal Sancho
Hmm, I 've done it too fast. xsl:template match=Match xsl:if test=preceding-sibling::Match[ Class/@name = current()/Class/@name and Bug/@pattern = current()/Bug/@pattern and (Field/@name = current()/Field/@name or Method/@name = current()/Method/@name or

Re: Findbug exclusions

2012-01-19 Thread Chris Bowditch
On 19/01/2012 13:21, Pascal Sancho wrote: Hi Pascal, Many thanks for writing the below XSLT. That helped me eliminate the remaining duplicates. As the list wasn't too long it was easy enough to remove the duplicates by hand. Thanks, Chris Hmm, I 've done it too fast. xsl:template

Findbug exclusions

2012-01-18 Thread Chris Bowditch
Hi Fellow Committers, I was reviewing the current set of warnings generated by FindBugs and found myself needing to add an extra exclusion. I noticed that the exclusions file contains a lot of duplicates, e.g. Match Class name=org.apache.fop.render.afp.AFPImageHandlerRawCCITTFax/ Method

Re: Findbug exclusions

2012-01-18 Thread Glenn Adams
I recall that someone (Jeremias or Simon?) had mechanically generated some exclusions to add to this file. It is possible that duplicates got inserted in that process. I know of no reason to retain duplicates. On Wed, Jan 18, 2012 at 6:39 AM, Chris Bowditch bowditch_ch...@hotmail.comwrote: Hi

Re: Findbug exclusions

2012-01-18 Thread Chris Bowditch
On 18/01/2012 15:51, Glenn Adams wrote: I recall that someone (Jeremias or Simon?) had mechanically generated some exclusions to add to this file. It is possible that duplicates got inserted in that process. I know of no reason to retain duplicates. Thanks Glenn. I've removed the duplicates