Re: new findbug errors

2010-11-22 Thread Vincent Hennebert
Hi, On 19/11/10 15:28, Glenn Adams wrote: Thanks! You say: I note that we have not accepted findbugs as a tool of the project. I think that not all developers are a fan of the tool. Findbugs has not been accepted as a tool of the project simply because nobody has promoted its use strong

Re: new findbug errors

2010-11-19 Thread Simon Pepping
I committed an exclusion filter that suppresses all existing findbug warnings (966). I generated it from the findbugs xml report. Then I moved all NM_CONFUSING out of the automatically generated block. When you get a new findbugs warning, you may 1. resolve it; 2. leave it unresolved, and add it

Re: new findbug errors

2010-11-19 Thread Glenn Adams
Thanks! You say: I note that we have not accepted findbugs as a tool of the project. I think that not all developers are a fan of the tool. Is there an alternative, and equally or more effective tool that is acceptable to more developers, e.g., PMD? If there is, then perhaps we should migrate to

Re: new findbug errors

2010-11-19 Thread Simon Pepping
Glenn, One note: You introduced findbugs as a tool, and you created the findbugs target in the build file. Simon On Fri, Nov 19, 2010 at 08:28:09AM -0700, Glenn Adams wrote: Thanks! You say: I note that we have not accepted findbugs as a tool of the project. I think that not all developers

Re: new findbug errors

2010-11-19 Thread Glenn Adams
Nope. It was introduced along with PMD target by Max Berger in June, 2008, see http://svn.apache.org/viewvc?view=revisionrevision=666967 I only made some enhancements to it, like adding the exclusion file. G. On Fri, Nov 19, 2010 at 11:55 AM, Simon Pepping spepp...@leverkruid.euwrote: Glenn,

Re: new findbug errors

2010-11-17 Thread Simon Pepping
I will take care of this. I am now squashing the easier findbugs-reported bugs/problems. Then I will add the remaining ones to the exclusion file, such that those that are really excluded can be distinguished from those which have not yet been examined. Simon On Tue, Nov 16, 2010 at 09:41:00AM

new findbug errors

2010-11-16 Thread Glenn Adams
I notice a few new findbugs errors creeping into trunk. Please try to run the findbugs target before commiting in order to fix any newly introduced bugs. Here are the new ones I see: a href=#MS_SHOULD_BE_FINALBug type MS_SHOULD_BE_FINAL (click for details)/a br/In class