[jira] [Commented] (FOP-2469) [PATCH] Auto table layout

2018-08-31 Thread Eric Lim (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599270#comment-16599270
 ] 

Eric Lim commented on FOP-2469:
---

I don't think table footer adding a new line is not entirely an auto table 
layout issue.  If you add more characters to the text marker and show borders, 
then you will see the table marker outside the table.  See attached test2.fo.

I'll investigate more next week.

 

> [PATCH] Auto table layout
> -
>
> Key: FOP-2469
> URL: https://issues.apache.org/jira/browse/FOP-2469
> Project: FOP
>  Issue Type: Bug
>  Components: layout/unqualified
>Affects Versions: trunk
> Environment: Windows 7, JDK 7
>Reporter: Gregor Berg
>Assignee: Andreas L. Delmelle
>Priority: Major
> Attachments: 2015-05-13-auto-table-layout.patch, 
> 2015-05-27-LM-to-LC-refactoring.patch, 
> 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, 
> FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, 
> resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, 
> test.fo, test2.fo, warning-only-static-columns-are-spanned.xml
>
>
> Hi,
> this is a patch which enables table-layout=auto. It is quite robust, it can 
> not only handle linebreaks and pagebreaks, but it also copes with auto tables 
> in fixed tables in auto tables.
> Essentially, it is the patch of issue FOP-2450 adapted to the trunk version 
> of FOP.
> Best regards,
> Gregor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (FOP-2469) [PATCH] Auto table layout

2018-08-31 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598596#comment-16598596
 ] 

simon steiner edited comment on FOP-2469 at 8/31/18 11:10 AM:
--

Table footer has newline after this patch, see test.fo file, also checkstyle 
fails


was (Author: ssteiner1):
Table footer has newline after this patch, see test.fo file

> [PATCH] Auto table layout
> -
>
> Key: FOP-2469
> URL: https://issues.apache.org/jira/browse/FOP-2469
> Project: FOP
>  Issue Type: Bug
>  Components: layout/unqualified
>Affects Versions: trunk
> Environment: Windows 7, JDK 7
>Reporter: Gregor Berg
>Assignee: Andreas L. Delmelle
>Priority: Major
> Attachments: 2015-05-13-auto-table-layout.patch, 
> 2015-05-27-LM-to-LC-refactoring.patch, 
> 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, 
> FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, 
> resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, 
> test.fo, warning-only-static-columns-are-spanned.xml
>
>
> Hi,
> this is a patch which enables table-layout=auto. It is quite robust, it can 
> not only handle linebreaks and pagebreaks, but it also copes with auto tables 
> in fixed tables in auto tables.
> Essentially, it is the patch of issue FOP-2450 adapted to the trunk version 
> of FOP.
> Best regards,
> Gregor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FOP-2469) [PATCH] Auto table layout

2018-08-31 Thread simon steiner (JIRA)


 [ 
https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

simon steiner updated FOP-2469:
---
Summary: [PATCH] Auto table layout  (was: [PATCH] auto table layout)

> [PATCH] Auto table layout
> -
>
> Key: FOP-2469
> URL: https://issues.apache.org/jira/browse/FOP-2469
> Project: FOP
>  Issue Type: Bug
>  Components: layout/unqualified
>Affects Versions: trunk
> Environment: Windows 7, JDK 7
>Reporter: Gregor Berg
>Assignee: Andreas L. Delmelle
>Priority: Major
> Attachments: 2015-05-13-auto-table-layout.patch, 
> 2015-05-27-LM-to-LC-refactoring.patch, 
> 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, 
> FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, 
> resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, 
> test.fo, warning-only-static-columns-are-spanned.xml
>
>
> Hi,
> this is a patch which enables table-layout=auto. It is quite robust, it can 
> not only handle linebreaks and pagebreaks, but it also copes with auto tables 
> in fixed tables in auto tables.
> Essentially, it is the patch of issue FOP-2450 adapted to the trunk version 
> of FOP.
> Best regards,
> Gregor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FOP-2469) [PATCH] auto table layout

2018-08-31 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598596#comment-16598596
 ] 

simon steiner commented on FOP-2469:


Table footer has newline after this patch, see test.fo file

> [PATCH] auto table layout
> -
>
> Key: FOP-2469
> URL: https://issues.apache.org/jira/browse/FOP-2469
> Project: FOP
>  Issue Type: Bug
>  Components: layout/unqualified
>Affects Versions: trunk
> Environment: Windows 7, JDK 7
>Reporter: Gregor Berg
>Assignee: Andreas L. Delmelle
>Priority: Major
> Attachments: 2015-05-13-auto-table-layout.patch, 
> 2015-05-27-LM-to-LC-refactoring.patch, 
> 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, 
> FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, 
> resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, 
> test.fo, warning-only-static-columns-are-spanned.xml
>
>
> Hi,
> this is a patch which enables table-layout=auto. It is quite robust, it can 
> not only handle linebreaks and pagebreaks, but it also copes with auto tables 
> in fixed tables in auto tables.
> Essentially, it is the patch of issue FOP-2450 adapted to the trunk version 
> of FOP.
> Best regards,
> Gregor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FOP-2469) [PATCH] auto table layout

2018-08-31 Thread simon steiner (JIRA)


 [ 
https://issues.apache.org/jira/browse/FOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

simon steiner updated FOP-2469:
---
Attachment: test.fo

> [PATCH] auto table layout
> -
>
> Key: FOP-2469
> URL: https://issues.apache.org/jira/browse/FOP-2469
> Project: FOP
>  Issue Type: Bug
>  Components: layout/unqualified
>Affects Versions: trunk
> Environment: Windows 7, JDK 7
>Reporter: Gregor Berg
>Assignee: Andreas L. Delmelle
>Priority: Major
> Attachments: 2015-05-13-auto-table-layout.patch, 
> 2015-05-27-LM-to-LC-refactoring.patch, 
> 2015-06-09-LM-to-LC-refactoring-update.patch, FOP-2469-2018-07-17.patch, 
> FOP-2469_20150621.patch, FOP2469-auto-table-layout.xml, 
> resize-all-but-static-spanned-columns.xml, resize-spanned-columns.xml, 
> test.fo, warning-only-static-columns-are-spanned.xml
>
>
> Hi,
> this is a patch which enables table-layout=auto. It is quite robust, it can 
> not only handle linebreaks and pagebreaks, but it also copes with auto tables 
> in fixed tables in auto tables.
> Essentially, it is the patch of issue FOP-2450 adapted to the trunk version 
> of FOP.
> Best regards,
> Gregor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FOP-2811) Deduplicate Pdf pages may cause erroneous pages rendering

2018-08-31 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598562#comment-16598562
 ] 

simon steiner commented on FOP-2811:


We would need replication steps for issue

> Deduplicate Pdf pages may cause erroneous pages rendering
> -
>
> Key: FOP-2811
> URL: https://issues.apache.org/jira/browse/FOP-2811
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Affects Versions: 2.2
>Reporter: ffimbel
>Priority: Major
>
> Implementation of FOP-2647: Deduplicate PDF content stream compares pdf pages 
> content using a hashcode which may not be unique. It causes rendering twice 
> the same page in the final pdf document while actual pages are different 
> (very inconvenient when the actual file contains documents for multiple 
> recipients).
> Due to confidentiality reasons, I cannot share the test case we used to 
> reproduce the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FOP-2810) Incomplete implementation of the simulate-style flag

2018-08-31 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598561#comment-16598561
 ] 

simon steiner commented on FOP-2810:


Can we see replication steps for issue

> Incomplete implementation of the simulate-style flag
> 
>
> Key: FOP-2810
> URL: https://issues.apache.org/jira/browse/FOP-2810
> Project: FOP
>  Issue Type: Bug
>  Components: font/unqualified
>Affects Versions: 2.3
>Reporter: Dan Caprioara
>Priority: Major
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CustomFont.getSimulateStyle() is used only in:
> {code:java}
> org.apache.fop.render.pdf.PDFPainter.drawTextWithDX(int, int, String, 
> FontTriplet, int, int, int[])
> {code}
> But not in:
> {code:java}
> org.apache.fop.render.pdf.PDFPainter.drawTextWithDP(int, int, String, 
> FontTriplet, int, int, int[][])
> {code}
> As a result some of the font styling is not applied.
> Modifying the above method with the following patch seem to fix the problem:
> {code:java}
> ...
>boolean simulateStyle = tf instanceof CustomFont && ((CustomFont) 
> tf).getSimulateStyle();
> 
> // PATCH START 
> // Taken from #drawTextWithDX method
> double shear = 0;
>   
> if (simulateStyle) {
> //Adding this breaks the PDF: generator.add("q\n")
> if (triplet.getWeight() == 700) {
> generator.add("2 Tr 0.31543 w\n");
> }
> if (triplet.getStyle().equals("italic")) {
> shear = 0.333;
> }
> }
> // PATCH END
> tu.writeTextMatrix(new AffineTransform(1, 0, shear, -1, x / 
> 1000f, y / 1000f));
> tu.updateTf(fk, fsPoints, true);
>generator.updateCharacterSpacing(letterSpacing / 1000f);
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FOP-2501) [PATCH] Missing support for border 'none'

2018-08-31 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598558#comment-16598558
 ] 

simon steiner commented on FOP-2501:


Can we see replication steps for issue

> [PATCH] Missing support for border 'none'
> -
>
> Key: FOP-2501
> URL: https://issues.apache.org/jira/browse/FOP-2501
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Affects Versions: trunk
>Reporter: Jan Tošovský
>Priority: Minor
> Attachments: FOP-2501.patch
>
>
> drawBorderLine2 method in PDFGraphicsPainter.java doesn't check for 'none' 
> value so this border style is rendered using a default 'solid' style. The fix 
> is quite straightforward:
> ...
> +case Constants.EN_NONE:
>   case Constants.EN_HIDDEN:
> break;
> ...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FOP-2775) Japanese characters turn into "###" from XML/XSL to PDF conversion

2018-08-31 Thread simon steiner (JIRA)


[ 
https://issues.apache.org/jira/browse/FOP-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598556#comment-16598556
 ] 

simon steiner commented on FOP-2775:


For example in fo:

japanese text

in fop.xconf:

  
    
  
    
  

> Japanese characters turn into "###" from XML/XSL to PDF conversion
> --
>
> Key: FOP-2775
> URL: https://issues.apache.org/jira/browse/FOP-2775
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/pdf
>Affects Versions: 2.0
>Reporter: Neha
>Priority: Major
> Attachments: FOPProject.zip, fop.xconf, 
> image-2018-08-31-11-05-39-202.png
>
>
> We are having trouble making Japanese language output with FOP when trying to 
> convert XML/XSL file to PDF file. The characters used in Japanese turns into 
> *###* in PDF file.
>  
> Attaching the project for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)