Re: svn commit: r359488 - /xmlgraphics/fop/trunk/test/layoutengine/standard-testcases/linearea_nonempty_1.xml
On Wed, 28 Dec 2005 07:33 pm, [EMAIL PROTECTED] wrote: Author: spepping Date: Wed Dec 28 03:33:29 2005 New Revision: 359488 URL: http://svn.apache.org/viewcvs?rev=359488view=rev Log: Test file for the NPE reported in bug 38053 Simon, thank you for that. For my benefit, I must have a mental block ATM, what actually triggers this problem? You said something about empty KnuthPossPosIter and font dependencies. However, I don't quite get it. Thanks again Manuel
Re: DO NOT REPLY [Bug 38053] - FOP SVN TRUNK crashes at inline page manager and Knuth inline box.
On Wed, Dec 28, 2005 at 05:17:03AM +0100, [EMAIL PROTECTED] wrote: For the NPE fix see http://svn.apache.org/viewcvs?rev=359383view=rev I didn't manage to construct a small test case for the NPE. Any attempts to cut down the large param-tidy.fo to a reasonable size but still exhibiting the problem failed. I must be missing something. Any help / suggestions appreciated. The test file linearea_nonempty_1.xml reproduces the NPE (without Manuel's fix). lastPos being null means that in InlineLM.addAreas, the iterator parentIter passed to it did not contain any area-generating positions. In this case, the paragraph is: Object [0]= LineLayoutManager$Paragraph (id=96) Object [0]= KnuthGlue (id=104) Object [1]= KnuthPenalty (id=108) Object [2]= KnuthGlue (id=110) Object [3]= KnuthInlineBox (id=111) Object [4]= KnuthPenalty (id=114) Object [5]= KnuthGlue (id=115) Object [6]= KnuthPenalty (id=116) There are two lines: from 0 to 1, and from 2 to 6. Line 1 is the problem. In LineLM.addInlineArea (a new method, which I recently extracted from LineLM.addAreas) non-boxes are skipped, so that iStartElement becomes 3, resulting in an empty iterator. I do not understand how the line breaking algorithm can produce a line consisting of only a glue and a penalty. Regards, Simon -- Simon Pepping home page: http://www.leverkruid.nl
Re: svn commit: r359368 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/inline/LineLayoutManager.java status.xml test/layoutengine/disabled-testcases.xml
On Dec 27, 2005, at 8:23 PM, Manuel Mall wrote: On Wed, 28 Dec 2005 11:21 am, [EMAIL PROTECTED] wrote: Author: manuel Date: Tue Dec 27 19:21:08 2005 New Revision: 359368 URL: http://svn.apache.org/viewcvs?rev=359368view=rev Log: Fix for bug 37743 and part of 38053 Sorry, I committed some of the files in the wrong order. This patch and the previous commit ( http://svn.apache.org/viewcvs?rev=359364view=rev) go together and cannot be looked at in isolation. Manuel You might want to post a comment to both BUGs... Happy holidays, and thanks for all the hard work! Web Maestro Clay
