https://issues.apache.org/bugzilla/show_bug.cgi?id=44794
--- Comment #3 from Andreas L. Delmelle [EMAIL PROTECTED] 2008-05-09
02:40:02 PST ---
Further notes:
In the related code, there's some preparations for resolving the
page-number-citation-last correctly, but the problem is that this
https://issues.apache.org/bugzilla/show_bug.cgi?id=44794
--- Comment #4 from Jeremias Maerki [EMAIL PROTECTED] 2008-05-09 02:47:08
PST ---
(In reply to comment #3)
Further notes:
In the related code, there's some preparations for resolving the
page-number-citation-last correctly, but the
https://issues.apache.org/bugzilla/show_bug.cgi?id=44794
--- Comment #5 from Andreas L. Delmelle [EMAIL PROTECTED] 2008-05-09
04:25:53 PST ---
Thanks for the confirmation.
In the meantime, I succeeded in getting the resolution for blocks correct, by
modifying BlockLM.addAreas().
Instead
https://issues.apache.org/bugzilla/show_bug.cgi?id=44794
--- Comment #6 from Andreas L. Delmelle [EMAIL PROTECTED] 2008-05-09
06:14:19 PST ---
More notes:
* page-number-citation seems to suffer the same limitations for block-container
as for inline. If the citation ends up on the same
https://issues.apache.org/bugzilla/show_bug.cgi?id=44794
--- Comment #7 from Andreas L. Delmelle [EMAIL PROTECTED] 2008-05-09
06:50:47 PST ---
(In reply to comment #6)
More notes:
* page-number-citation seems to suffer the same limitations for
block-container
as for inline. If the
Hi Adrian,
Nice job! Two nits:
Author: acumiskey
Date: Tue May 6 09:14:09 2008
New Revision: 653826
snip/
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/apps/FopFactory.java
URL:
On May 9, 2008, at 16:25, Vincent Hennebert wrote:
Nice job! Two nits:
I second this, and have an additional consideration:
+/**
+ * Returns the font manager
+ * @return the font manager
+ */
+public FontManager getFontManager() {
+if (fontManager == null) {
+
On May 9, 2008, at 16:40, Andreas Delmelle wrote:
snip /
That is, unless there is a specific reason to wait until
getFontManager() is called before initializing (?)
(Haven't checked whether the fontManager needs a fully initialized
FopFactory to work properly...)
I did a quick check, and
Andreas Delmelle wrote:
On May 9, 2008, at 16:25, Vincent Hennebert wrote:
Nice job! Two nits:
I second this, and have an additional consideration:
+/**
+ * Returns the font manager
+ * @return the font manager
+ */
+public FontManager getFontManager() {
+if
On May 9, 2008, at 17:22, Adrian Cumiskey wrote:
Andreas Delmelle wrote:
Maybe a matter of style, but if see this, I usually move the
assignment to the member initialization, i.e.
class FopFactory {
...
private FontManager fontManager = new FontManager(this);
...
That is, unless there is a
Hi Andreas,
I've thought about it and made your suggested change, also keeps the code in line with the existing
instantiation scheme in the constructor :).
Thanks for the feedback,
Adrian.
Andreas Delmelle wrote:
On May 9, 2008, at 17:22, Adrian Cumiskey wrote:
Andreas Delmelle wrote:
Hi Vincent,
Thanks a lot for taking the time to comb through my large patch :).
Vincent Hennebert wrote:
Hi Adrian,
Nice job! Two nits:
Author: acumiskey
Date: Tue May 6 09:14:09 2008
New Revision: 653826
snip/
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/apps/FopFactory.java
...to do something and it turned out, that I won't have the time to do so...I
tried to unlist from this list as well as bugzilla's but I can't. Can someone
with admin role do this for me? Thanks...
--
--
http://krachlattenpaul.homelinux.org
Home of Trackbase (1.3.0),
https://issues.apache.org/bugzilla/show_bug.cgi?id=44794
Andreas L. Delmelle [EMAIL PROTECTED] changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
14 matches
Mail list logo
