[jira] [Commented] (FOP-2211) [PATCH] Fix improve the handling of temporary files using the new URI resource resolvers
[
https://issues.apache.org/jira/browse/FOP-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13593313#comment-13593313
]
Alexios Giotis commented on FOP-2211:
-
Hi Simon,
Thank you for the patch. I looked at it and it does not resolve the issue of
keeping on disk many and big files. In a test we did last week, the temp file
was 100GB and for sure we don't wish to keep such files until the JVM is
normally terminated. For us, this is several months or a year.
Also, I don't think that backwards compatibility is an issue here. This is
trunk, there are many changes since 1.1 that do affect users embedding FOP in
their apps and this is not one of them. I am sure it will be easy to change
your code or to create an adapter.
I will try to find some time to submit updated versions of the patches that
take into account the comments above.
[PATCH] Fix improve the handling of temporary files using the new URI
resource resolvers
--
Key: FOP-2211
URL: https://issues.apache.org/jira/browse/FOP-2211
Project: Fop
Issue Type: Bug
Components: general
Affects Versions: trunk
Reporter: Alexios Giotis
Fix For: trunk
Attachments: fop.patch, tempurisimple.patch, xgc.patch
As written in http://markmail.org/message/zelumstxxsdyvkcz , after the merge
of the Temp_URI_Resolution branch (Sept 2012), the actual pattern of using
temp files has changed from:
{code}
File tmpFile = File.createTempFile();
// Write and read from the file
tmpFile.delete();
{code}
to:
{code}
File tmpFile = new File(System.getProperty(java.io.tmpdir),
counterStartingFrom1AsString);
tmpFile.deleteOnExit();
// Write and read from the file
{code}
This is fine when FOP is executed from the command line (which I guess this
is how most people use it) but it introduces a number of bad side effects for
long running processes that use FOP embedded.
1. Different FOP processes can't be executed in parallel on the same system
because creating the same temp file fails.
2. If the JVM is not normally terminated, the temp files are never deleted
and the next invocation of the JVM fails to run.
3. deleteOnExit() keeps for the life of the JVM an unknown number of temp
files both on disk and a reference in memory.
There should not be a need to implement a custom resource resolver when using
FOP embedded in order to fix those issues. The default implementation should
work at least as good as it worked in FOP 1.1 or earlier.
Attached are 2 patches, one for XGC and one for FOP that should fix and
improve the handling of at least the temporary files.
For reference, [1] lists some reasons for implementing the new URI resource
resolvers.
[1] http://wiki.apache.org/xmlgraphics-fop/URIResolution
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FOP-2214) [PATCH] Thin dashed border look like dots
[ https://issues.apache.org/jira/browse/FOP-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13593318#comment-13593318 ] Chris Bowditch commented on FOP-2214: - Thanks Simon, Patch applied in revision: 1452734 [PATCH] Thin dashed border look like dots - Key: FOP-2214 URL: https://issues.apache.org/jira/browse/FOP-2214 Project: Fop Issue Type: Bug Reporter: simon steiner Assignee: Chris Bowditch Attachments: afpborder.patch, afpbordertest.patch, border.patch, test.fo At border-width=1pt dashes are too short -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FOP-2217) [PATCH] Image scaling change .was adversely affecting other image types
[ https://issues.apache.org/jira/browse/FOP-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bowditch reassigned FOP-2217: --- Assignee: Chris Bowditch [PATCH] Image scaling change .was adversely affecting other image types Key: FOP-2217 URL: https://issues.apache.org/jira/browse/FOP-2217 Project: Fop Issue Type: Bug Reporter: Robert Meyer Assignee: Chris Bowditch Attachments: patch.diff A patch which will be posted shortly addresses several issues revolving around a change made to the ImageLayout class to resolve a scaling issue. This subsequently adversely affected other image types which needed to be changed. This patch removes the existing code changes and employs a fix to resolve the original issue related to SVG not converting to the correct unit. I have also removed a test case which was added for the ImageLayout class as this no longer applies. A follow up patch will be created for the XGC project to remove the fix related for this issue as that also no longer applies. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Created] (FOP-2219) XGC change removal as it is no longer needed with the image scaling change in FOP
Hi Glenn, Can you explain why other fop devs can't MOVE bugs between FOP and XGC. The weird thing is I can move from FOP to XGC but not the other way round. Which is strange indeed. Thanks, Chris On 05/03/2013 00:32, Luis Bernardo wrote: This should have been submitted as a XGC issue, not FOP. Glenn, I saw that you can move an issue from one project to the other. I assume one needs special privileges to do that since I don't see how to do it... On 3/4/13 2:07 PM, Robert Meyer (JIRA) wrote: Robert Meyer created FOP-2219: - Summary: XGC change removal as it is no longer needed with the image scaling change in FOP Key: FOP-2219 URL: https://issues.apache.org/jira/browse/FOP-2219 Project: Fop Issue Type: Bug Components: images Reporter: Robert Meyer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Revision 1435241 for FOP-2191 introduces a Findbugs warning
Specifically: CodeWarning EI2 org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence, String, String, String, int, int[], int[][], ScriptContextTester) may expose internal representation by storing an externally mutable object into GlyphPositioningState.adjustments Bug type EI_EXPOSE_REP2 (click for details) #EI_EXPOSE_REP2 In class org.apache.fop.complexscripts.fonts.GlyphPositioningState In method org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence, String, String, String, int, int[], int[][], ScriptContextTester) Field org.apache.fop.complexscripts.fonts.GlyphPositioningState.adjustments Local variable named adjustments At GlyphPositioningState.java:[line 97] EI2 org.apache.fop.complexscripts.fonts.GlyphPositioningState.reset(GlyphSequence, String, String, String, int, int[], int[][], ScriptContextTester) may expose internal representation by storing an externally mutable object into GlyphPositioningState.widths I would appreciate it if the developer responsible could address this warning. Thanks, Chris
[jira] [Updated] (FOP-2217) [PATCH] Image scaling change was adversely affecting other image types
[ https://issues.apache.org/jira/browse/FOP-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bowditch updated FOP-2217: Summary: [PATCH] Image scaling change was adversely affecting other image types (was: [PATCH] Image scaling change .was adversely affecting other image types ) [PATCH] Image scaling change was adversely affecting other image types --- Key: FOP-2217 URL: https://issues.apache.org/jira/browse/FOP-2217 Project: Fop Issue Type: Bug Reporter: Robert Meyer Assignee: Chris Bowditch Attachments: patch2.diff, patch.diff A patch which will be posted shortly addresses several issues revolving around a change made to the ImageLayout class to resolve a scaling issue. This subsequently adversely affected other image types which needed to be changed. This patch removes the existing code changes and employs a fix to resolve the original issue related to SVG not converting to the correct unit. I have also removed a test case which was added for the ImageLayout class as this no longer applies. A follow up patch will be created for the XGC project to remove the fix related for this issue as that also no longer applies. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FOP-2217) [PATCH] Image scaling change was adversely affecting other image types
[ https://issues.apache.org/jira/browse/FOP-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bowditch resolved FOP-2217. - Resolution: Fixed Fix Version/s: trunk Thanks Rob. Patch applied in revision 1452859 [PATCH] Image scaling change was adversely affecting other image types --- Key: FOP-2217 URL: https://issues.apache.org/jira/browse/FOP-2217 Project: Fop Issue Type: Bug Reporter: Robert Meyer Assignee: Chris Bowditch Fix For: trunk Attachments: patch2.diff, patch.diff A patch which will be posted shortly addresses several issues revolving around a change made to the ImageLayout class to resolve a scaling issue. This subsequently adversely affected other image types which needed to be changed. This patch removes the existing code changes and employs a fix to resolve the original issue related to SVG not converting to the correct unit. I have also removed a test case which was added for the ImageLayout class as this no longer applies. A follow up patch will be created for the XGC project to remove the fix related for this issue as that also no longer applies. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Revision 1435241 for FOP-2191 introduces a Findbugs warning
It was already fixed in https://issues.apache.org/jira/browse/FOP-2192(rev 1435270). :) On Tue, Mar 5, 2013 at 8:22 AM, Chris Bowditch bowditch_ch...@hotmail.comwrote: Specifically: CodeWarning EI2 org.apache.fop.complexscripts.**fonts.GlyphPositioningState.**reset(GlyphSequence, String, String, String, int, int[], int[][], ScriptContextTester) may expose internal representation by storing an externally mutable object into GlyphPositioningState.**adjustments Bug type EI_EXPOSE_REP2 (click for details) #EI_EXPOSE_REP2 In class org.apache.fop.complexscripts.**fonts.GlyphPositioningState In method org.apache.fop.complexscripts.**fonts.GlyphPositioningState.**reset(GlyphSequence, String, String, String, int, int[], int[][], ScriptContextTester) Field org.apache.fop.complexscripts.**fonts.GlyphPositioningState.** adjustments Local variable named adjustments At GlyphPositioningState.java:[**line 97] EI2 org.apache.fop.complexscripts.**fonts.GlyphPositioningState.**reset(GlyphSequence, String, String, String, int, int[], int[][], ScriptContextTester) may expose internal representation by storing an externally mutable object into GlyphPositioningState.widths I would appreciate it if the developer responsible could address this warning. Thanks, Chris
