[jira] [Commented] (FOP-1196) [PATCH] GSoC: floats implementation

[Chris Bowditch (Jira)]

[ 
https://issues.apache.org/jira/browse/FOP-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056772#comment-17056772
 ] 

Chris Bowditch commented on FOP-1196:
-

No one has implemented support for top floats, only side floats has been 
implemented so far

> [PATCH] GSoC: floats implementation
> ---
>
> Key: FOP-1196
> URL: https://issues.apache.org/jira/browse/FOP-1196
> Project: FOP
>  Issue Type: Improvement
>  Components: layout/unqualified
>Affects Versions: trunk
> Environment: Operating System: All
> Platform: All
>Reporter: Vincent Hennebert
>Priority: Major
>  Labels: PatchAvailable
> Attachments: patch.diff, patch2.diff, patchBeforeFloats-2.diff, 
> patchBeforeFloats.diff, patchDisabledTestcases.diff, patchTestcases.diff
>
>
> This patch isn't really meant to be applied... Rather to be reviewed by
> interested parties to check if I'm not wrong. Changelog:
> * javadocs for the Knuth line- and page-breaking algorithms. Some items are
> marked with double question marks because I haven't found out yet what is 
> their
> purpose. I will probably find eventually, but if anybody has immediate hints
> they will be welcome.
> * some methods have been marked deprecated because AFAICT they are not called
> anywhere. If this is agreed I'll remove them in my next patch
> * bugfix? In the last for loop of the method
> layoutmgr.PageBreakingAlgorithm.noBreakBetween I think the exit condition 
> should
> be a strict comparison ('<' instead of '<='). Confirmation?
> * the javadoc comments for some methods have been removed because they will
> inherit them from their super-class
> * some checkstyle fixes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (FOP-2918) Surrogate pairs not handled in U+10800-U+1083F

[Jan Driesen (Jira)]

Jan Driesen created FOP-2918:


 Summary: Surrogate pairs not handled in U+10800-U+1083F
 Key: FOP-2918
 URL: https://issues.apache.org/jira/browse/FOP-2918
 Project: FOP
  Issue Type: Bug
  Components: renderer/pdf
Affects Versions: 2.4
 Environment: Windows 10
Reporter: Jan Driesen
 Attachments: NotoSansCypriot-Regular.ttf, fop.xconf, input.fo

Fop is not properly handling surrogate pairs for characters in Unicode Block 
'Cypriot Syllabary' when rendering PDF.
It tries to resolve the individual surrogate entities. This results in errors 
saying the glyphs cannot be found.

The attached test shows a font that supports characters in this range, and an 
FO file holding the surrogate characters to be rendered.

Similar issues arise with fonts "MPH 2b Damas" 
([https://fedoraproject.org/wiki/MPH_2B_Damase_fonts]) and "Segoe UI Historic" 
([https://docs.microsoft.com/en-us/typography/font-list/segoe_ui_historic),] 
but the error may differ. [I am unsure whether licensing allows me to add these)

Some fonts (Damas & Noto) result in a "String index out of range". Other fonts 
(Segoe) deliver a "ill-formed UTF-16 sequence, contains isolated high surrogate 
at end of sequence" FOPException.

We expected this to work thanks to FOP-1969 (fop 2.3).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)