DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 taffy-tyler6...@hotmail.co.uk changed: What|Removed |Added CC||taffy-tyler6...@hotmail.co. ||uk -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 Glenn Adams gl...@skynav.com changed: What|Removed |Added Priority|P2 |P3 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 --- Comment #5 from Simon Pepping spepp...@apache.org 2009-03-24 03:26:54 PST --- The spec says: error-if-overflow: This value implies the same semantics as the value hidden with the additional semantic that an error shall be indicated; implementations may recover by clipping the region. The code says: boolean canRecover = (getBlockContainerFO().getOverflow() != EN_ERROR_IF_OVERFLOW); (BlockContainerLayoutManager, line 533). Does that not mean that the code is wrong: it should recover, but issue an ERROR instead of a WARNING? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 --- Comment #6 from Jeremias Maerki jerem...@apache.org 2009-03-24 04:11:44 PST --- (In reply to comment #5) The spec says: error-if-overflow: This value implies the same semantics as the value hidden with the additional semantic that an error shall be indicated; implementations may recover by clipping the region. The code says: boolean canRecover = (getBlockContainerFO().getOverflow() != EN_ERROR_IF_OVERFLOW); (BlockContainerLayoutManager, line 533). Does that not mean that the code is wrong: it should recover, but issue an ERROR instead of a WARNING? The spec says may recover, it doesn't say should recover, so it isn't technically wrong. That doesn't mean it can't be changed. But my personal expectation is an error if I explicitely say error-if-overflow instead of hidden. If I say hidden I don't care if any content is lost. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 --- Comment #7 from Simon Pepping spepp...@apache.org 2009-03-24 05:42:14 PST --- Created an attachment (id=23407) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=23407) Proposed patch Would the attach patch solve the problem in a good way? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 --- Comment #8 from Jeremias Maerki jerem...@apache.org 2009-03-24 10:24:51 PST --- (In reply to comment #7) Created an attachment (id=23407) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=23407) [details] Proposed patch Would the attach patch solve the problem in a good way? I think you're doing pretty much the same thing I did there, only in reverse. I specified the event for FATAL level, and canRecover can lower the severity to WARN. Your change would set the default level to WARN and increase it to ERROR if it's error-on-overflow. The only difference is that the error cause used FATAL before and uses ERROR after the change which would effectively not stop the formatting and allow the user to increase the event severity to FATAL if he so chooses. You could skip the isError attribute and just set all overflow events to ERROR level by default (Javadoc @event.severity). That would have the same effect. Don't forget that the block-container case is not the only overflow where an error is possible. As I said before I'm not opposed to lowering FATAL to ERROR for error-if-overflow. A custom event handler can always throw an exception. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 --- Comment #2 from Andreas L. Delmelle adelme...@apache.org 2009-03-09 10:53:45 PST --- Sorry, a bit too quick, but there is a logical explanation: I had commented out the last fo:block-container, which has a overflow='error-if-overflow', so the fact that you get an exception is expected. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 --- Comment #3 from Adrian Cumiskey d...@cumiskey.com 2009-03-09 13:58:31 PST --- I should have looked at the FO more closely... still, this is not a very good example for someone wanting to try FOP out. It would be better to remove the error on overflow and generate some useful output for the user. WDYT? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 46823] LayoutException when rendering ./examples/fo/basic/blockcontainer.fo
https://issues.apache.org/bugzilla/show_bug.cgi?id=46823 --- Comment #4 from Andreas L. Delmelle adelme...@apache.org 2009-03-09 14:05:29 PST --- (In reply to comment #3) I should have looked at the FO more closely... still, this is not a very good example for someone wanting to try FOP out. It would be better to remove the error on overflow and generate some useful output for the user. WDYT? Good idea. Indeed, a dubious demo file. :-) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
