Re: SpaceHandling[Break]Position, associated LayoutManager and AreaAdditionUtil

2007-04-20 Thread Jeremias Maerki

On 19.04.2007 11:24:20 Vincent Hennebert wrote:
 Hi,
 
 Is there any reason why SpaceHandling[Break]Position elements created by
 SpaceResolver don't have any LayoutManager associated to them?

I guess I didn't see the need to have one when I implemented this.

 As a result, in AreaAdditionUtil.addAreas, if the first Position element
 is a SpaceHandling[Break]Position, then the position list is not
 iterated over to add areas for childLMs.
 
 l.103: while ((childLM = childPosIter.getNextChildLM()) != null) {
 
 The loop isn't entered if the first position is a
 SpaceHandling[Break]Position, as it will return a null LayoutManager.
 
 Or are such positions supposed to never be first in the list?

See block_space-before_space-after_2.xml. There, it is first in the
element list.

If you have a case where this has a negative side-effect, then, of
course, a test case has to be written and the problem adressed. It
simply wasn't an issue so far.




Jeremias Maerki



SpaceHandling[Break]Position, associated LayoutManager and AreaAdditionUtil

2007-04-19 Thread Vincent Hennebert
Hi,

Is there any reason why SpaceHandling[Break]Position elements created by
SpaceResolver don't have any LayoutManager associated to them?
As a result, in AreaAdditionUtil.addAreas, if the first Position element
is a SpaceHandling[Break]Position, then the position list is not
iterated over to add areas for childLMs.

l.103: while ((childLM = childPosIter.getNextChildLM()) != null) {

The loop isn't entered if the first position is a
SpaceHandling[Break]Position, as it will return a null LayoutManager.

Or are such positions supposed to never be first in the list?

Thanks,
Vincent