DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 Glenn Adams gad...@apache.org changed: What|Removed |Added Priority|P3 |P2 --- Comment #9 from Glenn Adams gad...@apache.org 2012-04-11 03:22:11 UTC --- increase priority for bugs with a patch -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 --- Comment #8 from Glenn Adams gl...@skynav.com 2012-04-07 01:44:07 UTC --- resetting P2 open bugs to P3 pending further review -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 Glenn Adams gl...@skynav.com changed: What|Removed |Added Priority|P2 |P3 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 --- Comment #7 from Glenn Adams gl...@skynav.com 2012-04-01 15:20:12 UTC --- (In reply to comment #6) Hi Peter, Sorry for the slow response in replying to this now very old patch. There is no test case attached so the purpose of the patch is unclear. Is the purpose of the encoding attribute on TLE to allow non ASCII characters to be included in the TLE data? Could you upload a test XSL-FO to demo the issue? Thanks, Chris peter, any progress on this? can this be moved to resolved? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 Chris Bowditch bowditch_ch...@hotmail.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #6 from Chris Bowditch bowditch_ch...@hotmail.com 2012-02-21 15:48:30 UTC --- Hi Peter, Sorry for the slow response in replying to this now very old patch. There is no test case attached so the purpose of the patch is unclear. Is the purpose of the encoding attribute on TLE to allow non ASCII characters to be included in the TLE data? Could you upload a test XSL-FO to demo the issue? Thanks, Chris -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 --- Comment #2 from Vincent Hennebert vhenneb...@gmail.com 2010-03-25 11:16:34 UTC --- (In reply to comment #1) Hi Peter, Thanks for your patch. I can't comment on the functionality itself, but I noticed a few general issues: - the new EncodingTriplet class is missing from the patch. You must svn add the new class before creating the patch - there are other compilation errors: a new parameter was added to AbstractPageObject.createTagLogicalElement but the corresponding method calls haven't been updated. Likewise for the TagLogicalElement constructor - the method AbstractTripletStructuredObject.setFullyQualifiedName is no longer visible - there are some checkstyle issues in the new code In AFPPageSetup: - there is a setter for encoding, so that field can be made private In AFPPageSetupElement: - catching Exception is evil (in most cases). In this case I suppose you just want to catch NumberFormatException In TagLogicalElement: - do you really want to store the encoding as an Integer? IIUC the int value is wrapped into an Integer in AFPPageSetup and then unwrapped in TagLogicalElement.setEncoding. It seems to me that the int value could directly be passed around Thanks, Vincent -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 Peter Hancock peter.hanc...@gmail.com changed: What|Removed |Added Attachment #25163|0 |1 is obsolete|| --- Comment #3 from Peter Hancock peter.hanc...@gmail.com 2010-03-25 17:00:02 UTC --- Created an attachment (id=25184) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=25184) patch of implementation with suggested fixes Patch updated from Vincent's initial response -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 --- Comment #5 from Peter Hancock peter.hanc...@gmail.com 2010-03-25 18:10:22 UTC --- Note the patch includes the deletion of src/java/org/apache/fop/afp/modca/AbstractTripletStructuredObject.java. I think the commiter will have to 'svn delete' it. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48954] [PATCH] Support for character encoding of TLEs in AFP output
https://issues.apache.org/bugzilla/show_bug.cgi?id=48954 Peter Hancock peter.hanc...@gmail.com changed: What|Removed |Added Summary|Support for character |[PATCH] Support for |encoding of TLEs in AFP |character encoding of TLEs |output |in AFP output -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
