subject:"RTF output"

[jira] [Updated] (FOP-1278) PNG missing for RTF output

2021-06-26 Thread dian hina (Jira)



 [ 
https://issues.apache.org/jira/browse/FOP-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

dian hina updated FOP-1278:
---

oke finish

> PNG missing for RTF output
> --
>
> Key: FOP-1278
> URL: https://issues.apache.org/jira/browse/FOP-1278
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/rtf
>Affects Versions: 2.5
> Environment: Operating System: other
> Platform: Other
>Reporter: Chris Bowditch
> Attachments: moon.png, test.fo
>
>
> Attached PNG causes a NPE when rendering to RTF. Submitted by Dominic Brugger 
> (brugger.at.puzzle.ch) Stack trace below:
> SEVERE: Error while handling an external-graphic: null
> java.lang.NullPointerException
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:920)
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:215)
> at org.apache.fop.image.AbstractFopImage.loadDefaultOriginalData
> (AbstractFopImage.java:223)
> at org.apache.fop.image.ImageIOImage.loadOriginalData
> (ImageIOImage.java:217)
> at org.apache.fop.image.AbstractFopImage.load
> (AbstractFopImage.java:174)
> at org.apache.fop.render.rtf.RTFHandler.image(RTFHandler.java:1131)
> at org.apache.fop.render.rtf.RTFHandler.invokeDeferredEvent
> (RTFHandler.java:1492)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1616)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1687)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1687)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1639)
> at org.apache.fop.render.rtf.RTFHandler.endPageSequence
> (RTFHandler.java:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FOP-1278) PNG missing for RTF output

2020-01-07 Thread Chris Bowditch (Jira)



[ 
https://issues.apache.org/jira/browse/FOP-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009725#comment-17009725
 ] 

Chris Bowditch commented on FOP-1278:
-

I don't think the bug can be closed. The NPE no longer occurs, but the PNG 
appears to be a format unexpected by the RTFHandler

> PNG missing for RTF output
> --
>
> Key: FOP-1278
> URL: https://issues.apache.org/jira/browse/FOP-1278
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/rtf
>Affects Versions: trunk
> Environment: Operating System: other
> Platform: Other
>Reporter: Chris Bowditch
> Attachments: moon.png, test.fo
>
>
> Attached PNG causes a NPE when rendering to RTF. Submitted by Dominic Brugger 
> (brugger.at.puzzle.ch) Stack trace below:
> SEVERE: Error while handling an external-graphic: null
> java.lang.NullPointerException
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:920)
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:215)
> at org.apache.fop.image.AbstractFopImage.loadDefaultOriginalData
> (AbstractFopImage.java:223)
> at org.apache.fop.image.ImageIOImage.loadOriginalData
> (ImageIOImage.java:217)
> at org.apache.fop.image.AbstractFopImage.load
> (AbstractFopImage.java:174)
> at org.apache.fop.render.rtf.RTFHandler.image(RTFHandler.java:1131)
> at org.apache.fop.render.rtf.RTFHandler.invokeDeferredEvent
> (RTFHandler.java:1492)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1616)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1687)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1687)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1639)
> at org.apache.fop.render.rtf.RTFHandler.endPageSequence
> (RTFHandler.java:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FOP-1278) PNG missing for RTF output

2019-12-30 Thread Sanjaya S (Jira)



[ 
https://issues.apache.org/jira/browse/FOP-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005238#comment-17005238
 ] 

Sanjaya S commented on FOP-1278:


Hi Team,

I am using FOP 2.3 with Xmlgraphics-commons-2.3 to my test case. Simply I am 
generating a rtf output from a fo file where I am using an 
 tag and taking a png image in src url.

This gives me following error in output rtf file- 

{color:#505f79}_org.apache.fop.render.rtf.rtflib.rtfdoc.RtfExternalGraphic$ExternalGraphicException:
 The tag  does not support png - image type._{color}

 

I have tried with the fix given in https://issues.apache.org/jira/browse/XGC-97 
but still no help. 

 

> PNG missing for RTF output
> --
>
> Key: FOP-1278
> URL: https://issues.apache.org/jira/browse/FOP-1278
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/rtf
>Affects Versions: trunk
> Environment: Operating System: other
> Platform: Other
>Reporter: Chris Bowditch
> Attachments: moon.png, test.fo
>
>
> Attached PNG causes a NPE when rendering to RTF. Submitted by Dominic Brugger 
> (brugger.at.puzzle.ch) Stack trace below:
> SEVERE: Error while handling an external-graphic: null
> java.lang.NullPointerException
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:920)
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:215)
> at org.apache.fop.image.AbstractFopImage.loadDefaultOriginalData
> (AbstractFopImage.java:223)
> at org.apache.fop.image.ImageIOImage.loadOriginalData
> (ImageIOImage.java:217)
> at org.apache.fop.image.AbstractFopImage.load
> (AbstractFopImage.java:174)
> at org.apache.fop.render.rtf.RTFHandler.image(RTFHandler.java:1131)
> at org.apache.fop.render.rtf.RTFHandler.invokeDeferredEvent
> (RTFHandler.java:1492)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1616)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1687)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1687)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1639)
> at org.apache.fop.render.rtf.RTFHandler.endPageSequence
> (RTFHandler.java:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (FOP-1278) PNG missing for RTF output

2017-02-22 Thread simon steiner (JIRA)


 [ 
https://issues.apache.org/jira/browse/FOP-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

simon steiner updated FOP-1278:
---
Summary: PNG missing for RTF output  (was: PNG causes NPE for RTF output)

> PNG missing for RTF output
> --
>
> Key: FOP-1278
> URL: https://issues.apache.org/jira/browse/FOP-1278
> Project: FOP
>  Issue Type: Bug
>  Components: renderer/rtf
>Affects Versions: trunk
> Environment: Operating System: other
> Platform: Other
>Reporter: Chris Bowditch
> Attachments: moon.png, test.fo
>
>
> Attached PNG causes a NPE when rendering to RTF. Submitted by Dominic Brugger 
> (brugger.at.puzzle.ch) Stack trace below:
> SEVERE: Error while handling an external-graphic: null
> java.lang.NullPointerException
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:920)
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:215)
> at org.apache.fop.image.AbstractFopImage.loadDefaultOriginalData
> (AbstractFopImage.java:223)
> at org.apache.fop.image.ImageIOImage.loadOriginalData
> (ImageIOImage.java:217)
> at org.apache.fop.image.AbstractFopImage.load
> (AbstractFopImage.java:174)
> at org.apache.fop.render.rtf.RTFHandler.image(RTFHandler.java:1131)
> at org.apache.fop.render.rtf.RTFHandler.invokeDeferredEvent
> (RTFHandler.java:1492)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1616)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1687)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1687)
> at org.apache.fop.render.rtf.RTFHandler.recurseFONode
> (RTFHandler.java:1639)
> at org.apache.fop.render.rtf.RTFHandler.endPageSequence
> (RTFHandler.java:



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (FOP-2350) Implement support for page-master types other than the simple variant for RTF output

2014-02-26 Thread Robert Meyer (JIRA)

Robert Meyer created FOP-2350:
-

 Summary: Implement support for page-master types other than the 
simple variant for RTF output
 Key: FOP-2350
 URL: https://issues.apache.org/jira/browse/FOP-2350
 Project: Fop
  Issue Type: New Feature
  Components: rtf
Affects Versions: trunk
Reporter: Robert Meyer


RTF currently only supports simple-page-masters. The RTF specification has 
support for different page sizes and orientations per page so this feature 
should be possible to support and implement.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Updated] (FOP-1278) PNG causes NPE for RTF output

2013-06-03 Thread Robert Meyer (JIRA)


 [ 
https://issues.apache.org/jira/browse/FOP-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Meyer updated FOP-1278:
--

Attachment: test.fo

I know this is an old bug, but thought I'd just investigate to see whether this 
is still reproducible and if it's worth keeping this open. I have attached the 
following FO and am not getting the NPE for which this bug was originally 
raised for. It now creates the RTF without error, however if you open the RTF 
instead of finding the image, some text in the RTF is written as the following:

org.apache.fop.render.rtf.rtflib.rtfdoc.RtfExternalGraphic$ExternalGraphicException
 
org.apache.fop.render.rtf.rtflib.rtfdoc.RtfExternalGraphic$ExternalGraphicException:
 The tag fo:external-graphic does not support png - image type.

I guess that means this can be closed?

 PNG causes NPE for RTF output
 -

 Key: FOP-1278
 URL: https://issues.apache.org/jira/browse/FOP-1278
 Project: Fop
  Issue Type: Bug
  Components: rtf
Affects Versions: trunk
 Environment: Operating System: other
 Platform: Other
Reporter: Chris Bowditch
 Attachments: moon.png, test.fo


 Attached PNG causes a NPE when rendering to RTF. Submitted by Dominic Brugger 
 (brugger.at.puzzle.ch) Stack trace below:
 SEVERE: Error while handling an external-graphic: null
 java.lang.NullPointerException
 at org.apache.commons.io.IOUtils.copy(IOUtils.java:920)
 at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:215)
 at org.apache.fop.image.AbstractFopImage.loadDefaultOriginalData
 (AbstractFopImage.java:223)
 at org.apache.fop.image.ImageIOImage.loadOriginalData
 (ImageIOImage.java:217)
 at org.apache.fop.image.AbstractFopImage.load
 (AbstractFopImage.java:174)
 at org.apache.fop.render.rtf.RTFHandler.image(RTFHandler.java:1131)
 at org.apache.fop.render.rtf.RTFHandler.invokeDeferredEvent
 (RTFHandler.java:1492)
 at org.apache.fop.render.rtf.RTFHandler.recurseFONode
 (RTFHandler.java:1616)
 at org.apache.fop.render.rtf.RTFHandler.recurseFONode
 (RTFHandler.java:1687)
 at org.apache.fop.render.rtf.RTFHandler.recurseFONode
 (RTFHandler.java:1687)
 at org.apache.fop.render.rtf.RTFHandler.recurseFONode
 (RTFHandler.java:1639)
 at org.apache.fop.render.rtf.RTFHandler.endPageSequence
 (RTFHandler.java:

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

DO NOT REPLY [Bug 41149] PNG causes NPE for RTF output

2012-04-11 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=41149

Glenn Adams gad...@apache.org changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

--- Comment #4 from Glenn Adams gad...@apache.org 2012-04-11 06:17:15 UTC ---
change status from ASSIGNED to NEW for consistency

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 41149] PNG causes NPE for RTF output

2012-04-06 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=41149

--- Comment #3 from Glenn Adams gl...@skynav.com 2012-04-07 01:42:58 UTC ---
resetting P2 open bugs to P3 pending further review

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 41149] PNG causes NPE for RTF output

2012-04-06 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=41149

Glenn Adams gl...@skynav.com changed:

   What|Removed |Added

   Priority|P2  |P3

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 40442] [PATCH] percent length not working in font-size for rtf output

2012-04-01 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=40442

Glenn Adams gl...@skynav.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #6 from Glenn Adams gl...@skynav.com 2012-04-01 06:38:09 UTC ---
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 39215] [PATCH] To render GIF external images in RTF output via PNG

2012-04-01 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=39215

Glenn Adams gl...@skynav.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #6 from Glenn Adams gl...@skynav.com 2012-04-01 06:46:51 UTC ---
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 41488] [PATCH] PNG causes NPE for RTF output

2012-04-01 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=41488

Glenn Adams gl...@skynav.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #5 from Glenn Adams gl...@skynav.com 2012-04-01 06:56:45 UTC ---
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 38041] Page numbering fails for rtf output

2012-04-01 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=38041

Glenn Adams gl...@skynav.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #11 from Glenn Adams gl...@skynav.com 2012-04-01 07:07:24 UTC ---
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 39215] [PATCH] To render GIF external images in RTF output via PNG

2009-08-26 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=39215


Max Berger m...@berger.name changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


--- Comment #5 from Max Berger m...@berger.name 2009-08-26 01:28:58 PDT ---
Patch is now obsolete since the mentioned image conversion has been implemented
by Jeremias.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 41488] - [PATCH] PNG causes NPE for RTF output

2007-02-03 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=41488.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41488


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2007-02-03 14:56 ---
Patch applied. Thanks, Dominic.
http://svn.apache.org/viewvc?view=revrev=503326

While reviewing I noticed one problem. PNGReader does not read the resolution
from the PNG file. So, if a PNG were used with a resolution other than 72dpi,
the intrinsic size of the image will be wrong when processed through the layout
engine. The problem is that PNG is a format consisting of chunks. The pHYs
chunk with the resolution info is optional any doesn't have to be near the
beginning of the file so it's not so easy to just extend PNGReader.

I'll have to think about how best to implement this, especially in the light of
the image library redesign where I'd like to avoid decoding the whole image just
to get the resolution. Therefore I'm keeping this issue open. One way or the
other, we need to fix this before the next release, because the bug fixes one
thing but essentially breaks another.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 41488] New: - [PATCH] PNG causes NPE for RTF output

2007-01-29 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=41488.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41488

   Summary: [PATCH] PNG causes NPE for RTF output
   Product: Fop
   Version: 1.0dev
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: rtf
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: [EMAIL PROTECTED]


A fix for bug 41149. As proposed by Jeremias, ImageIOImage now doesn't call
loadBitmap() if it has the width and height of the image. I tested the patched
version width JPG, GIF and PNG images for PS, PDF and RTF output. So far it
seems to be OK...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 41488] - [PATCH] PNG causes NPE for RTF output

2007-01-29 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=41488.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41488





--- Additional Comments From [EMAIL PROTECTED]  2007-01-29 02:06 ---
Created an attachment (id=19474)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19474action=view)
Patch file


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 41488] - [PATCH] PNG causes NPE for RTF output

2007-01-29 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=41488.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41488





--- Additional Comments From [EMAIL PROTECTED]  2007-01-29 02:07 ---
Created an attachment (id=19475)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19475action=view)
Test file


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 41488] - [PATCH] PNG causes NPE for RTF output

2007-01-29 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=41488.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41488


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #19475|application/octet-stream|application/zip
  mime type||




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 41149] - PNG causes NPE for RTF output

2006-12-11 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=41149.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41149





--- Additional Comments From [EMAIL PROTECTED]  2006-12-11 06:34 ---
Created an attachment (id=19242)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19242action=view)
PNG


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output

2006-10-09 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40442


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-10-09 06:07 ---
Patch applied in revision 454369. Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output

2006-09-16 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40442


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #18840|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 18:16 ---
Created an attachment (id=18876)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=18876action=view)
simpler fix

New, simpler fix for percent font problem in RTF output.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output

2006-09-11 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40442


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2006-09-11 06:48 ---
Creating LayoutManagers in RTF output is not really the right idea.
LayoutManagers are to be used only inside the layout engine which for RTF
isn't used. I realize it's a tempting move but from a design perspective, it is
wrong. A different solution has to be found. IMO, we have to have special
implementations for PercentBaseContext for output formats which don't use the
layout engine. These implementations could even be used by the layout managers,
thus removing the need to implement PercentBaseContext there.

If another committer disagrees with my statement, please reopen the issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40442] New: - percent length not working in font-size for rtf output

2006-09-08 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40442

   Summary: percent length not working in font-size for rtf output
   Product: Fop
   Version: 0.92
  Platform: All
OS/Version: All
Status: NEW
  Keywords: PatchAvailable
  Severity: normal
  Priority: P2
 Component: rtf
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: [EMAIL PROTECTED]


Using a relative font-size, like this  
fo:block font-size=120%test/fo:block  
always gives the smallest font size possible.  
  
This is due to the fact that in  
org.apache.fop.render.rtf.FOPRtfAttributes.setHalfPoints(String,Length)  
getValue is used without a context.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40442] - percent length not working in font-size for rtf output

2006-09-08 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40442





--- Additional Comments From [EMAIL PROTECTED]  2006-09-08 08:25 ---
Created an attachment (id=18840)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=18840action=view)
patch that add PercentBaseContext

The patch is against 0.92, but should apply to trunk as well, as the only
differences to these files are header diffs.

This is a proposed modification to org.apache.fop.render.rtf.FOPRtfAttributes
and org.apache.fop.render.rtf.TextAttributesConverter wich create
LayoutManagers to use them as PercentBaseContext.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40442] - [PATCH] percent length not working in font-size for rtf output

2006-09-08 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=40442.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40442


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|percent length not working  |[PATCH] percent length not
   |in font-size for rtf output |working in font-size for rtf
   ||output




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 39215] New: - [PATCH] To render GIF external images in RTF output via PNG

2006-04-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39215.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39215

   Summary: [PATCH] To render GIF external images in RTF output via
PNG
   Product: Fop
   Version: 1.0dev
  Platform: Macintosh
OS/Version: Mac OS X 10.3
Status: NEW
  Severity: normal
  Priority: P2
 Component: rtf
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: [EMAIL PROTECTED]


A patch to RtfExternalImage to convert GIF to PNG using javax.image.ImageIO

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 39215] - [PATCH] To render GIF external images in RTF output via PNG

2006-04-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39215.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39215


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Keywords||PatchAvailable




--- Additional Comments From [EMAIL PROTECTED]  2006-04-05 13:07 ---
Thanks for the patch, Ian. However, there's a fundamental problem with it: It
generates a dependency on JDK 1.4 or later due to the use of ImageIO. FOP must,
for the time being, remain compatible with JDK 1.3. FOP's image package contains
adapters to several image libraries which can read GIF images. The problem is
that you cannot easily use them for this particular use case because they
currently create a decoded bitmap image as a byte array. It would have to be
converted into a BufferedImage and then written to a PNG through the ImageWriter
interface provided by XML Graphics Commons
(http://svn.apache.org/viewcvs.cgi/xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/image/writer/).

I've started documenting requirements for an improved image adapter package:
http://wiki.apache.org/xmlgraphics-fop/ImageSupport. But that's probably for
later since this will take some time to implement properly.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 39215] - [PATCH] To render GIF external images in RTF output via PNG

2006-04-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39215.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39215





--- Additional Comments From [EMAIL PROTECTED]  2006-04-05 14:08 ---
Is it Ok to use JAI to build the BufferedImage ?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38041] - Page numbering fails for rtf output

2005-12-27 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38041.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38041





--- Additional Comments From [EMAIL PROTECTED]  2005-12-27 10:02 ---
Created an attachment (id=17279)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17279action=view)
The FO-file for producing pdf and rtf output


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38041] - Page numbering fails for rtf output

2005-12-27 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38041.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38041





--- Additional Comments From [EMAIL PROTECTED]  2005-12-27 10:03 ---
Created an attachment (id=17280)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17280action=view)
Outout as desired as a pdf file generated by FOP 0.91


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38041] - Page numbering fails for rtf output

2005-12-27 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38041.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38041





--- Additional Comments From [EMAIL PROTECTED]  2005-12-27 10:05 ---
Created an attachment (id=17281)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17281action=view)
Output to rtf by FOP 0.91 as described in the bug


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38041] - Page numbering fails for rtf output

2005-12-27 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38041.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38041





--- Additional Comments From [EMAIL PROTECTED]  2005-12-27 10:55 ---
Created an attachment (id=17282)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17282action=view)
FO file for writing simple reportr with index


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38041] - Page numbering fails for rtf output

2005-12-27 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38041.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38041





--- Additional Comments From [EMAIL PROTECTED]  2005-12-27 10:56 ---
Created an attachment (id=17283)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17283action=view)
rtf file displays problem with list-item-label for FOP 0.91


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38041] - Page numbering fails for rtf output

2005-12-27 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38041.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38041





--- Additional Comments From [EMAIL PROTECTED]  2005-12-27 10:57 ---
Note! By modifying the fo-file according to the instructions by Peter Herweg 
the rtf looks rather ok except the texts Place as list-item labels for all 
lists-items. Place is the first list-item-label of the last list-item in the 
document and is copied to all list-item-label:s.

I added an fo-file and rtf file that have been modified from my original ones 
that displays this problem only

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38041] New: - Page numbering fails for rtf output

2005-12-26 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38041.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38041

   Summary: Page numbering fails for rtf output
   Product: Fop
   Version: 0.91
  Platform: Other
OS/Version: Windows 2000
Status: NEW
  Severity: normal
  Priority: P2
 Component: rtf
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: [EMAIL PROTECTED]


I have a simple fo file at
http://www.kk-software.fi/kaila/fop/kalle01.fo

This produces the pdf as I wish at
http://www.kk-software.fi/kaila/fop/kalle01.pdf

The rtf output is better than it was with 0.90 but seems to have some
problems with page numbering.

The rtf output is at http://www.kk-software.fi/kaila/fop/kalle01.rtf
Tha page text appears with the hyperlinks and is missing at top of the page. 
Also some new page commands are not correct

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38041] - Page numbering fails for rtf output

2005-12-26 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38041.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38041





--- Additional Comments From [EMAIL PROTECTED]  2005-12-26 18:19 ---
The value index-region-left for fo:[EMAIL PROTECTED] is not supported 
by rtf output. Also there is no support for fo:conditional-page-master-
reference by rtf output. Please use fo:simple-page-master and fo:region-before 
instead and pass xsl-region-before to flow-name attribute.

There is also no support for break-before attribute by rtf output. That's the 
reason why page breaks are not correct.

Kind regards,
Peter Herweg


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

EMF support for RTF output

2005-11-08 Thread Jeremias Maerki

Peter,

I've had a look at your changes to the RTF output concerning image
support. It's cool to see that switching to FOP's image adapters was
relatively painless.

I've stumbled upon one problem, though. If you run
external-graphic_emf.xml through the RTFHandler the image is distorted.
It looks like RtfExternalGraphic.computeImageSize() fetches wrong values
from the EMF. That's not so important for me right now, but I wanted you
to know about it.

Jeremias Maerki

AW: RTF output

2005-10-26 Thread Peter Herweg

There's the intention to use the wrapper classes, which are already used by
rest of FOP.
Jeremias made a similiar suggestion on 4th Oct.

I will see, if i can invest some time on that task this week-end.

Kind regards,
Peter Herweg

-Ursprungliche Nachricht-
Von: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
Auftrag von Andreas L Delmelle
Gesendet: Dienstag, 25. Oktober 2005 21:10
An: fop-users@xmlgraphics.apache.org
Cc: fop-dev@xmlgraphics.apache.org
Betreff: Re: RTF output



On Oct 25, 2005, at 00:20, Tony Morris wrote:

 I don't have my test case with me, since I am at work at the moment.
 Otherwise, what I recall is setting the size of an external-graphic
 to the
 exact number of pixels (I think if I didn't, the RTF renderer
 wasn't happy),
 the image appeared scaled down, but if I set the image size to say,
 10x the
 number of pixels, it would not appear 10x bigger than the scaled
 down image,
 but about the size I would expect normally. Granted, I was using MS
 Word
 2003 for verification, which may well be the culprit.

(cc'ing fop-dev, since the message contains pointers on the causes of
this problem, and may help someone devise a solution for it)

Well, we shouldn't be blaming M$ for everything --however tempting it
may be ;-)
All I can say is that the other renderers all use the same set of
image library wrappers. The RTF renderer currently is the only
exception (support for external-graphics was reintroduced for RTF
about a month ago).
AFAICT, in the long run, it's the intention of switching to the same
set of wrappers for the RTF renderer. Doing so could mean that your
problem disappears, I'm not sure. What is more than certain is that
the current code in the RTF lib is not 100% correct, and even seems
to make the same mistake in interpretation of the related properties
(height/width) that FOP 0.20.5 made, namely interpreting the value of
these properties as the dimensions of the image itself instead of
taking them to be the dimensions of the image's surrounding box.
Looking at the related code in the RTF library, it seems the 'height'
and 'width' of the external-graphic are interpreted as 'desired
height' and 'desired width', which is wrong if neither content-height
nor content-width were specified as 'scale-to-fit'. One can define an
external-graphic with height=10cm and still have the content take
up only 3cm.

Roughly, it seems line 952 in the RTFHandler:

newGraphic.setWidth(eg.getWidth().getValue() / 1000f + pt);

is too simplistic, and should at least become something like:

if (eg.getWidth().getEnum() != Constants.EN_AUTO) {
 if (eg.getContentWidth().getEnum() == Constants.EN_SCALE_TO_FIT) {
 newGraphic.setWidth(eg.getWidth().getValue() / 1000f + pt);
 } ...
...
}

So, only if width is not specified as auto *and* content-width is
specified as scale-to-fit (or is of length equal to the non-auto
width) does the external-graphic's width become the desired width for
the image.

If, for instance, width=auto *and* content-width=auto, the
following could be used (instrinsic width of the image):

newGraphic.setWidth(100%);

I don't think it's all that difficult to tweak the RTFHandler into
handling these properties correctly, but then again, the question can
be asked whether it's all worth it. If the RTF renderer is going to
switch to the default image lib wrappers anyway, this effort would
perhaps be completely in vain.

Anyone?

Cheers,

Andreas

Re: RTF output

2005-10-25 Thread Andreas L Delmelle



On Oct 25, 2005, at 00:20, Tony Morris wrote:


I don't have my test case with me, since I am at work at the moment.
Otherwise, what I recall is setting the size of an external-graphic  
to the
exact number of pixels (I think if I didn't, the RTF renderer  
wasn't happy),
the image appeared scaled down, but if I set the image size to say,  
10x the
number of pixels, it would not appear 10x bigger than the scaled  
down image,
but about the size I would expect normally. Granted, I was using MS  
Word

2003 for verification, which may well be the culprit.


(cc'ing fop-dev, since the message contains pointers on the causes of  
this problem, and may help someone devise a solution for it)


Well, we shouldn't be blaming M$ for everything --however tempting it  
may be ;-)
All I can say is that the other renderers all use the same set of  
image library wrappers. The RTF renderer currently is the only  
exception (support for external-graphics was reintroduced for RTF  
about a month ago).
AFAICT, in the long run, it's the intention of switching to the same  
set of wrappers for the RTF renderer. Doing so could mean that your  
problem disappears, I'm not sure. What is more than certain is that  
the current code in the RTF lib is not 100% correct, and even seems  
to make the same mistake in interpretation of the related properties  
(height/width) that FOP 0.20.5 made, namely interpreting the value of  
these properties as the dimensions of the image itself instead of  
taking them to be the dimensions of the image's surrounding box.
Looking at the related code in the RTF library, it seems the 'height'  
and 'width' of the external-graphic are interpreted as 'desired  
height' and 'desired width', which is wrong if neither content-height  
nor content-width were specified as 'scale-to-fit'. One can define an  
external-graphic with height=10cm and still have the content take  
up only 3cm.


Roughly, it seems line 952 in the RTFHandler:

newGraphic.setWidth(eg.getWidth().getValue() / 1000f + pt);

is too simplistic, and should at least become something like:

if (eg.getWidth().getEnum() != Constants.EN_AUTO) {
if (eg.getContentWidth().getEnum() == Constants.EN_SCALE_TO_FIT) {
newGraphic.setWidth(eg.getWidth().getValue() / 1000f + pt);
} ...
...
}

So, only if width is not specified as auto *and* content-width is  
specified as scale-to-fit (or is of length equal to the non-auto  
width) does the external-graphic's width become the desired width for  
the image.


If, for instance, width=auto *and* content-width=auto, the  
following could be used (instrinsic width of the image):


newGraphic.setWidth(100%);

I don't think it's all that difficult to tweak the RTFHandler into  
handling these properties correctly, but then again, the question can  
be asked whether it's all worth it. If the RTF renderer is going to  
switch to the default image lib wrappers anyway, this effort would  
perhaps be completely in vain.


Anyone?

Cheers,

Andreas

40 matches

Mail list logo