Seeking review: Named Destinations

2007-03-06 Thread Jay Bryant

Hi, folks,

I have finished my named destinations project (I've been done for a couple 
weeks, actually).


As the new kid on the block, I am leary of just checking it in, but I gather 
that that's the normal process.


So, shall I check it in or post the new and changed files somewhere for you 
folks to inspect and test?


Thanks.

Jay Bryant
Bryant Communication Services 





Re: Seeking review: Named Destinations

2007-03-06 Thread Andreas L Delmelle

On Mar 6, 2007, at 18:36, Jay Bryant wrote:

Hi Jay,

I have finished my named destinations project (I've been done for a  
couple weeks, actually).


That's good news.

As the new kid on the block, I am leary of just checking it in, but  
I gather that that's the normal process.


So, shall I check it in or post the new and changed files somewhere  
for you folks to inspect and test?


If you're really uncertain, then I guess you could always enter a  
patch proposal in Bugzilla first, and attach the diff of the related  
files, so that we can have a look first.


OTOH, if you're sure all junit tests pass, you might as well commit  
the changes. If anything does not agree with one of us, you'll get a  
response soon enough.



Cheers,

Andreas