Re: svn commit: r761554 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/render/print/PrintRenderer.java status.xml

2009-04-03 Thread Vincent Hennebert
Hi, Author: jeremias Date: Fri Apr 3 07:44:09 2009 New Revision: 761554 URL: http://svn.apache.org/viewvc?rev=761554view=rev Log: Fixed a bug that left the PrintRenderer unconfigured even if a configuration was specified for application/X-fop-print. snip/ +/** {...@inheritdoc}

Re: svn commit: r761554 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/render/print/PrintRenderer.java status.xml

2009-04-03 Thread Adrian Cumiskey
Your suggestion sounds sensible enough to me (without having found time to take a look at the code), +1. Adrian. Vincent Hennebert wrote: Hi, Author: jeremias Date: Fri Apr 3 07:44:09 2009 New Revision: 761554 URL: http://svn.apache.org/viewvc?rev=761554view=rev Log: Fixed a bug that

Re: svn commit: r761554 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/render/print/PrintRenderer.java status.xml

2009-04-03 Thread Jeremias Maerki
Hi Vincent, Removing getMimeType() on AbstractRenderer is ok although that could break someone else's renderer (risk very slim). But I'd rather move the getMimeType() implementation from PrintRenderer to PageableRenderer. That alone doesn't solve Rey's problem but get one step closer. I'll do

Re: svn commit: r761554 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/render/print/PrintRenderer.java status.xml

2009-04-03 Thread Vincent Hennebert
Hi Jeremias, Jeremias Maerki wrote: Hi Vincent, Removing getMimeType() on AbstractRenderer is ok although that could break someone else's renderer (risk very slim). But I'd rather move the getMimeType() implementation from PrintRenderer to PageableRenderer. That alone doesn't solve Rey's

Re: svn commit: r761554 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/render/print/PrintRenderer.java status.xml

2009-04-03 Thread Jeremias Maerki
Hi Vincent, well, the print renderer doesn't really have an official MIME type. The result could be paper, PDF, PostScript or whatever. I've given it a pseudo MIME type application/X-fop-print just so configuration works for this renderer, too. So it really depends how you look at it. But I've