Re: [PATCH] Support for percentages and table-units

2004-02-24 Thread Finn Bock
[Finn Bock] I don't understand how you propose to solve any of this, but I hope it would be Ok to commit the straight forward solution I propose. [J.Pietschmann] Whatever works. I just want to note that given the almost one- to-one correspondence between FOs and LMs both in classes and

Re: [PATCH] Support for percentages and table-units

2004-02-24 Thread J.Pietschmann
Finn Bock wrote: That is not correct. Temporarily storing the area dimension in the FO tree just long enough for the getNextBreakPoss() to return does *not* in any way prevent reusing the FO tree or the LM tree for an other rendering run. It prevents overlapping/concurrent runs. Whether these

RE: [PATCH] Support for percentages and table-units

2004-02-23 Thread Andreas L. Delmelle
-Original Message- From: Peter B. West [mailto:[EMAIL PROTECTED] Some babbling about trees and ladders ... snip / There's a lot of subjective judgement in making such calls, which is why it's useful to have a number of different opinions kicking ideas around. Yeah.. it probably is

Re: [PATCH] Support for percentages and table-units

2004-02-23 Thread J.Pietschmann
Finn Bock wrote: I don't understand how you propose to solve any of this, but I hope it would be Ok to commit the straight forward solution I propose. Whatever works. I just want to note that given the almost one- to-one correspondence between FOs and LMs both in classes and instances (with the

RE: [PATCH] Support for percentages and table-units

2004-02-22 Thread Andreas L. Delmelle
-Original Message- From: Peter B. West [mailto:[EMAIL PROTECTED] snip / The borderline cases may be very much in the minority (and must be, judging by the degree of usage that FOP gets now) but they must be taken into account in the design of the solution. If we go for the

Re: [PATCH] Support for percentages and table-units

2004-02-22 Thread Peter B. West
Andreas L. Delmelle wrote: -Original Message- From: Peter B. West [mailto:[EMAIL PROTECTED] snip / The borderline cases may be very much in the minority (and must be, judging by the degree of usage that FOP gets now) but they must be taken into account in the design of the solution. If

Re: [PATCH] Support for percentages and table-units

2004-02-21 Thread Finn Bock
If an expression reference another expression in a parent fo, the parent fo expression must be evaluated against the LayoutContext that was in effect for the parent fo and *not* against the child fo LayoutContext. fo:block id=a border-start-width=10% fo:block id=b border-start-width=inherit

Re: [PATCH] Support for percentages and table-units

2004-02-21 Thread Finn Bock
[Peter B. West] Finn, When I apply your most recent patch (10366) against a cvs updated HEAD tree and attempt to compile, I get the following: [javac] /usr/local/src/fop-HEAD-finn/src/java/org/apache/fop/fo/properties/LinearCombinationLength.java:60: After applying the patch (10366), the

Re: [PATCH] Support for percentages and table-units

2004-02-21 Thread Simon Pepping
On Sat, Feb 21, 2004 at 12:24:24PM +0100, Finn Bock wrote: Question: What to do if I insert a fo:wrapper between fo:flow and fo:block? That makes it the parent of fo:block, but it has no layout manager corresponding to it. Override getLayoutDimension on it? I don't think so, but perhaps I

RE: [PATCH] Support for percentages and table-units

2004-02-21 Thread Andreas L. Delmelle
-Original Message- From: Peter B. West [mailto:[EMAIL PROTECTED] Thanks Andreas. Yes, I disagree, but then, so does the spec. What information *should* do is not terribly relevant. We need to work out and express what information *must* do to get this thing working. Voila!

Re: [PATCH] Support for percentages and table-units

2004-02-21 Thread Peter B. West
Andreas L. Delmelle wrote: -Original Message- From: Peter B. West [mailto:[EMAIL PROTECTED] Thanks Andreas. Yes, I disagree, but then, so does the spec. What information *should* do is not terribly relevant. We need to work out and express what information *must* do to get this

Re: [PATCH] Support for percentages and table-units

2004-02-21 Thread Peter B. West
Finn Bock wrote: [Peter B. West] Finn, When I apply your most recent patch (10366) against a cvs updated HEAD tree and attempt to compile, I get the following: [javac] /usr/local/src/fop-HEAD-finn/src/java/org/apache/fop/fo/properties/LinearCombinationLength.java:60: After applying the

Re: [PATCH] Support for percentages and table-units

2004-02-20 Thread Finn Bock
[me] If an expression reference another expression in a parent fo, the parent fo expression must be evaluated against the LayoutContext that was in effect for the parent fo and *not* against the child fo LayoutContext. fo:block id=a border-start-width=10% fo:block id=b

Re: [PATCH] Support for percentages and table-units

2004-02-20 Thread J.Pietschmann
Finn Bock wrote: If it is evaluated already where would the evaluated value be stored? The layout context for the child LM could be an appropriate place. And then the value should be reverted to the expression when the base value changes due to breaks. No problem, this is known at the place

Re: [PATCH] Support for percentages and table-units

2004-02-20 Thread Finn Bock
If it is evaluated already where would the evaluated value be stored? [J.Pietschmann] The layout context for the child LM could be an appropriate place. The resolved property values of the parents should be stored in the layout context? I must be missing something here! And then the value

Re: [PATCH] Support for percentages and table-units

2004-02-20 Thread Simon Pepping
On Thu, Feb 19, 2004 at 08:52:41AM +0100, Finn Bock wrote: If an expression reference another expression in a parent fo, the parent fo expression must be evaluated against the LayoutContext that was in effect for the parent fo and *not* against the child fo LayoutContext. fo:block id=a

Re: [PATCH] Support for percentages and table-units

2004-02-20 Thread Simon Pepping
On Wed, Feb 18, 2004 at 04:00:26PM -0800, Glen Mazza wrote: In general, yes, but not as 100%. We had this debate for months, with Victor holding fast to your view on the issue. We've done more spec research since then (I encourage you to read the parts of the spec I indicated in my posting)

Re: [PATCH] Support for percentages and table-units

2004-02-20 Thread Peter B. West
Re-sending due to mailer problems. Peter Original Message Subject: Re: [PATCH] Support for percentages and table-units Date: Thu, 19 Feb 2004 12:48:59 +1000 Andreas L. Delmelle wrote: -Original Message- From: Simon Pepping [mailto:[EMAIL PROTECTED] In my view FOP

Re: [PATCH] Support for percentages and table-units

2004-02-20 Thread Peter B. West
Re-resending... Original Message Subject: Re: [PATCH] Support for percentages and table-units Date: Fri, 20 Feb 2004 19:07:06 +1000 Finn Bock wrote: [me] If an expression reference another expression in a parent fo, the parent fo expression must be evaluated against

Re: [PATCH] Support for percentages and table-units

2004-02-20 Thread Peter B. West
Re-resending... Original Message Subject: Re: [PATCH] Support for percentages and table-units Date: Fri, 20 Feb 2004 21:20:52 +1000 Finn, When I apply your most recent patch (10366) against a cvs updated HEAD tree and attempt to compile, I get the following: [javac] /usr

Re: [PATCH] Support for percentages and table-units

2004-02-19 Thread J.Pietschmann
Finn Bock wrote: If an expression reference another expression in a parent fo, the parent fo expression must be evaluated against the LayoutContext that was in effect for the parent fo and *not* against the child fo LayoutContext. fo:block id=a border-start-width=10% fo:block id=b

Re: [PATCH] Support for percentages and table-units

2004-02-18 Thread Simon Pepping
On Tue, Feb 17, 2004 at 09:31:52PM +0100, Finn Bock wrote: [J.Pietschmann] The layout context has the actual IPD MinOptMax. There is no inherent reason it should have a link to a parent context or the property subsystem, it's only necessary to have a method to resolve a property

Re: [PATCH] Support for percentages and table-units

2004-02-18 Thread Simon Pepping
On Tue, Feb 17, 2004 at 04:52:10PM -0800, Glen Mazza wrote: --- Finn Bock [EMAIL PROTECTED] wrote: The layout dimension that is stored in the FO tree is constantly updated during discovery of BreakPoss'es and is never reused, not even when a block is split over a break where new

RE: [PATCH] Support for percentages and table-units

2004-02-18 Thread Andreas L. Delmelle
-Original Message- From: Simon Pepping [mailto:[EMAIL PROTECTED] In my view FOP consists of a number of subsystems that are ordered from upstream to downstream. The FO tree is the most upstream system, the area tree (or objects that are constructed by a renderer) is the most

RE: [PATCH] Support for percentages and table-units

2004-02-18 Thread Andreas L. Delmelle
snip / is being interrogated/perceived/discussed... Sorry, it's late here... You are IMO very correct by stating that 'if the Layout info can be reused, so can the AT and the renderer', however, if I interpret correctly, the latter two are designed to dispose of their created objects

Re: [PATCH] Support for percentages and table-units

2004-02-18 Thread Glen Mazza
--- Simon Pepping [EMAIL PROTECTED] wrote: In my view FOP consists of a number of subsystems that are ordered from upstream to downstream. The FO tree is the most upstream system, the area tree (or objects that are constructed by a renderer) is the most downstream system. Information

Re: [PATCH] Support for percentages and table-units

2004-02-18 Thread Finn Bock
[J.Pietschmann] The layout context has the actual IPD MinOptMax. There is no inherent reason it should have a link to a parent context or the property subsystem, it's only necessary to have a method to resolve a property expression given a set of MinOptMax for the various traits which can be used

Re: [PATCH] Support for percentages and table-units

2004-02-17 Thread Finn Bock
Somehow, in our current design, the information must be stored in an object that exists: [J.Pietschmann] IIRC that's what the layout context was meant for. Perhaps, but I doubt it. If they was change to always get a reference to the parent layout context when they are created, and if they had a

Re: [PATCH] Support for percentages and table-units

2004-02-17 Thread Finn Bock
[Simon Pepping] If in the re-use the layout would not change, the area tree could be reused. OTOH, if the layout would change, e.g. because another renderer would use a font with a different font metric, the layout information in the FO tree cannot be reused. The layout dimension that is stored

Re: [PATCH] Support for percentages and table-units

2004-02-17 Thread J.Pietschmann
Finn Bock wrote: Perhaps, but I doubt it. If they was change to always get a reference to the parent layout context when they are created, and if they had a reference to the FObj, and if they was made available to the property subsystem, then they could properly be used for it. The layout

Re: [PATCH] Support for percentages and table-units

2004-02-17 Thread Finn Bock
Perhaps, but I doubt it. If they was change to always get a reference to the parent layout context when they are created, and if they had a reference to the FObj, and if they was made available to the property subsystem, then they could properly be used for it. [J.Pietschmann] The layout

Re: [PATCH] Support for percentages and table-units

2004-02-17 Thread Glen Mazza
--- Finn Bock [EMAIL PROTECTED] wrote: The layout dimension that is stored in the FO tree is constantly updated during discovery of BreakPoss'es and is never reused, not even when a block is split over a break where new values are assigned. I don't know enough to comment too much on

RE: [PATCH] Support for percentages and table-units

2004-02-16 Thread Andreas L. Delmelle
-Original Message- From: Finn Bock [mailto:[EMAIL PROTECTED] [Simon Pepping] snip / However, I am not happy with your solution. During the layout process, you feed the page dimensions back into the FO tree, in PageLayoutManager.createPageAreas. Yes, and in BlockLayoutManager

Re: [PATCH] Support for percentages and table-units

2004-02-16 Thread Simon Pepping
On Sun, Feb 15, 2004 at 10:43:12PM +0100, Finn Bock wrote: [Simon Pepping] Finn, I think it would be a better design if, in order to resolve the percent-based properties, you would not climb the FO tree but the Area tree. That avoids feeding back results from the Area tree into the FO

Re: [PATCH] Support for percentages and table-units

2004-02-16 Thread Simon Pepping
On Mon, Feb 16, 2004 at 08:22:31PM +0100, Andreas L. Delmelle wrote: -Original Message- From: Finn Bock [mailto:[EMAIL PROTECTED] [Simon Pepping] snip / However, I am not happy with your solution. During the layout process, you feed the page dimensions back into the FO

Re: [PATCH] Support for percentages and table-units

2004-02-16 Thread Simon Pepping
On Sun, Feb 15, 2004 at 10:43:12PM +0100, Finn Bock wrote: [Simon Pepping] I initially had a separate PropertyContext object where the length was stored. The FO element then had a reference to the PropertyContext and there was a PropertyContext for every FO. But since there was a

RE: [PATCH] Support for percentages and table-units

2004-02-16 Thread Andreas L. Delmelle
-Original Message- From: Simon Pepping [mailto:[EMAIL PROTECTED] snip / If in the re-use the layout would not change, the area tree could be reused. OTOH, if the layout would change, e.g. because another renderer would use a font with a different font metric, the layout information

Re: [PATCH] Support for percentages and table-units

2004-02-16 Thread J.Pietschmann
Finn Bock wrote: Somehow, in our current design, the information must be stored in an object that exists: IIRC that's what the layout context was meant for. J.Pietschmann