DO NOT REPLY [Bug 25272] - [PATCH] FNF thrown formatting test/resources/fop/image/align.fo

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25272

[PATCH] FNF thrown formatting test/resources/fop/image/align.fo





--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 17:43 ---
On further examination, the command line application uses FOFileHandler to
read FO from a file but embedded apps can use something like the following:

File pdfFile = new File( namePart + ".pdf" );

Driver driver = new Driver();
Logger logger = new ConsoleLogger( ConsoleLogger.LEVEL_INFO ); 
//driver.setLogger( logger );
driver.setRenderer( Driver.RENDER_PDF );
try {
driver.setOutputStream( new java.io.FileOutputStream( pdfFile ) );
Result res = new SAXResult(driver.getContentHandler());
trans2.transform( xmlSource2, res );
}

And Driver sets the ContentHandler to an instance of FOTreeBuilder. So I'll need 
to crawl through some more innards to complete a fix.

New Year's resolution:

To learn as much every day, as I did after making yesterday's tactless remark.
WITHOUT being tactless.

DO NOT REPLY [Bug 25272] - [PATCH] FNF thrown formatting test/resources/fop/image/align.fo

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25272

[PATCH] FNF thrown formatting test/resources/fop/image/align.fo





--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 14:05 ---
Feedback accepted.

The only place that needs to change to fix this problem, is the
ImageFactory method:
protected static InputStream openStream(String href, FOUserAgent ua)

The current state of the input stream is set in the constructors of
FOFileHandler which is called normally from CommandLineOptions and 
a couple of other less critical places.

Also, FOUserAgent hold a reference to a logger and there is a bit of code that 
needs to have logging support added. So I shall amend my suggested fix.

DO NOT REPLY [Bug 25272] - [PATCH] FNF thrown formatting test/resources/fop/image/align.fo

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25272

[PATCH] FNF thrown formatting test/resources/fop/image/align.fo





--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 11:54 ---
Singleton was selected because the state needs a place to live. If there is
a logical home for the state information that is thread-safe, that is the place
to put it. I'll have a look at that on the weekend. 

As to the use of the commons or avalon resolvers, I don't mind either approach
but it brings the phrase 'not invented here' to mind. They probably work better
than 
the core Java class but they add to the learning curve.

("Lucky we didn’t say anything about the dirty knife.").

DO NOT REPLY [Bug 25272] - [PATCH] FNF thrown formatting test/resources/fop/image/align.fo

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25272

[PATCH] FNF thrown formatting test/resources/fop/image/align.fo





--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 07:18 ---
Sorry to come in late on this but I see a problem with the proposed changes: 
They don't work in a multi-threaded environment. One of the goals in the 
transition from the old maintenance branch to the redesign is get rid of as 
many statics as possible to avoid any multi-threading problems.

URL resolution would better be done through the Document class (there's one 
for each currently rendered document) or through the FOUserAgent although the 
latter is configuration-dependant and not "run"-dependant (as Document is).

Another important thing to respect in this context is the proper resolution of 
URIs. We should be able to make use of an XML Resolver 
(http://xml.apache.org/commons/components/resolver/index.html) and the whole 
thing should be easily pluggable into Cocoon (which uses Avalon's 
SourceResolver concept, http://avalon.apache.org/excalibur/sourceresolve-
index.html).

DO NOT REPLY [Bug 25272] - [PATCH] FNF thrown formatting test/resources/fop/image/align.fo

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25272

[PATCH] FNF thrown formatting test/resources/fop/image/align.fo

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|FNF thrown formatting   |[PATCH] FNF thrown
   |test/resources/fop/image/ali|formatting
   |gn.fo   |test/resources/fop/image/ali
   ||gn.fo



--- Additional Comments From [EMAIL PROTECTED]  2003-12-19 02:04 ---
John,

Please stop rushing the committers.  This is not a trivial task.  The problem 
domain has to be fully explored, then your work vs. what we already have in 
FOP's Ant Task has to be checked, then we (probably) have to compare your work 
vs. what is already done by Batik and Xalan to see if anything has been 
missed.  

In the meantime, you may wish to redo your code patches:  use no tabs, 4 spaces 
only, and follow the coding conventions, particularily in spacing, given on our 
web site and based on the Sun guidelines.  CurrentSourceManager in particular 
needs several changes--you should not have sent this to us in its current state.

Thanks,
Glen