DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-24 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-24 13:54 ---
Created an attachment (id=9697)
A slightly diffrent test that also checks for the bug in 25743.

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-24 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-24 13:53 ---
Created an attachment (id=9696)
A new unified patch against HEAD that overrides the previous patch.

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-24 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-24 13:52 ---
A new patch, that doesn't introduce new vrbls but uses the existing test for a 
new line.

The patch also ensure that a child InlineStackingLM always uses the parent LM 
value for SUPPRESS_LEADING_SPACES. As it were, the parent value was only used 
when the InlineStackingLM started a new area.

This patch also fixes bug 25743.

Thank you Simon and Glen for your help.

regards,
finn

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-24 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-24 12:30 ---
The use of 'first' is to indicate that space suppression should only happen at 
the very first flow object in a block. But Simon and Glen's comments have made 
me realize that that is probably wrong. Space suppression should occur for each 
flow object until a bp is added. So the test 
   vecInlineBreaks.size() == iPrevLineEnd
is enough and the badly named 'first' vrbl can be removed.

Unfortunately this triggers a different bug where setting space suppression on 
a InlineStackingLM cause space suppression to occurs for each of the LM's 
children.

I'll take a look at that problem, and until I come up with something, this 
patch should be suspended.

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-23 22:31 ---
Finn, I can add the comments in, but, apologies for my slowness here--what 
does "first" precisely indicate within the processing of the document?  First 
line after a preceding line-break or block or what?

Thanks,
Glen

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-23 21:33 ---
We need code comments, also a more descriptive variable name so people 
understand X months from now what it is for--what does the boolean "first" 
variable refer to -- first line?

Thanks,
Glen

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-23 21:21 ---
Simon, your patch is certainly too simple. When vecInlineBreaks happens to be 
empty, then we are not allowed to access the vecInlineBreaks()-1 'th element.
So there have to be at least a check for that.

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-23 21:00 ---
I think the new boolean first is equivalent to vecInlineBreaks.isEmpty(), so
that the patch could be:

   inlineLC.setFlags(LayoutContext.SUPPRESS_LEADING_SPACE,
   (vecInlineBreaks.size() == iPrevLineEnd
-   && !vecInlineBreaks.isEmpty()
&& ((BreakPoss)
vecInlineBreaks.get(vecInlineBreaks.size() - 1)).
isForcedBreak() == false));

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-23 19:26 ---
Created an attachment (id=9688)
A test .fo that illustrate the problem.

DO NOT REPLY [Bug 25732] - [PATCH] Supress leading spaces after a line-break.

2003-12-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25732

[PATCH] Supress leading spaces after a line-break.





--- Additional Comments From [EMAIL PROTECTED]  2003-12-23 19:24 ---
Created an attachment (id=9687)
The patch against HEAD