DO NOT REPLY [Bug 28431] - Hyphenation of words with punctuation marks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28431. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28431 Hyphenation of words with punctuation marks --- Additional Comments From [EMAIL PROTECTED] 2004-04-19 10:30 --- Simon, concernig names, unnecessary if, etc. , I agree with you. It seems to me that your change concerning hyphenation exceptions works, otherwise the hyphenation points would appear in the wrong place because of the punctuation marks. The strange pdf generated is due, IMO, to a couple of problems: -1- In the last test case the text is (quite oddly) divided among 3 TextLM **[...]** (philanthrop ic). Specifying the property linefeed-treatment=ignore, the text is all in a TLM. Removing from the test file the linefeed after (philanthropic)., the text is still split in two parts: *** *** (philanthropic). So, it seems there is an irksome bug affecting text splitting. -2- The last line in a justified paragraph is sometimes justified too (bug 28314). The phantom linefeed is by default treated as a space, and so it is adjusted. Anyway, I was pleased to notice that, although shattered, the word is correctly collected and hyphenated. Regards Luca
DO NOT REPLY [Bug 28431] - Hyphenation of words with punctuation marks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28431. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28431 Hyphenation of words with punctuation marks --- Additional Comments From [EMAIL PROTECTED] 2004-04-16 13:29 --- Created an attachment (id=11258) proposed patch to HyphenationTree
DO NOT REPLY [Bug 28431] - Hyphenation of words with punctuation marks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28431. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28431 Hyphenation of words with punctuation marks --- Additional Comments From [EMAIL PROTECTED] 2004-04-16 13:30 --- Created an attachment (id=11259) test fo file: words with punctuation marks and parenthesis
DO NOT REPLY [Bug 28431] - Hyphenation of words with punctuation marks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28431. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28431 Hyphenation of words with punctuation marks --- Additional Comments From [EMAIL PROTECTED] 2004-04-16 19:44 --- Luca, The patch works well. I do not find the name bAfterLetter very clear. It really is bNonLetterAfterLetters, but that is too long. I find bEndOfLetters a reasonable choice. The 'else if (!bAfterLetter)' might as well be just 'else'. The venom is in the tail. I do not know the details of this part of hyphenation. Your addition of 'iIgnoreAtBeginning' seems OK. I think you should also add 'iIgnoreAtBeginning' in the if branch (hyphenation exceptions), but the results of a test fo are not quite in favour. Perhaps you can have a look into this. I added a long comment explaining various features, perhaps most to myself. I added cases to the test fo showing a word that is too short (when one adds debug logging, one sees the effect), and 4 cases with a hyphenation exception word. Regards, Simon
DO NOT REPLY [Bug 28431] - Hyphenation of words with punctuation marks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28431. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28431 Hyphenation of words with punctuation marks --- Additional Comments From [EMAIL PROTECTED] 2004-04-16 19:45 --- Created an attachment (id=11264) An expanded test fo file
DO NOT REPLY [Bug 28431] - Hyphenation of words with punctuation marks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28431. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28431 Hyphenation of words with punctuation marks --- Additional Comments From [EMAIL PROTECTED] 2004-04-16 19:46 --- Created an attachment (id=11265) A slightly modified patch
DO NOT REPLY [Bug 28431] - Hyphenation of words with punctuation marks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28431. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28431 Hyphenation of words with punctuation marks --- Additional Comments From [EMAIL PROTECTED] 2004-04-17 05:17 --- Your assumptions appear correct, I checked the Washington Post newspaper and saw that hyphenation does indeed occur with words that have a period or comma at the end of them. Glen
