The BasicLink does now extend Inline.
All makers should only extend FObj.Maker.
Removing parts that are yet to be implemented properly should wait until we
have a better understanding of how the properties are going to be used.

On Fri, 28 Sep 2001 00:17:30 Enrico Schnepel wrote:
> Hello,
> 
> About one month ago I've send a patch to extend Basiclink from Inline and
> not 
> from FObjMixed. There wasn't any reaction. The original email body was:
> 
> I have the problem that I want to specify other inline related properties
> 
> than color ( like text-decoration="underline" ) to basic-link. These are 
> currently not supported by BasicLink. BasicLink currently extends
> FObjMixed. 
> I have changed BasicLink to "extends Inline" and removed double code.
> This 
> results in visual properties handled by Inline and the LinkSet is set up
> by 
> BasicLink.
> 
> I have attached the patch
> 
> Enrico
> 
> The patch follows now
> 
> SNIP
> 
> Index: src/org/apache/fop/fo/flow/BasicLink.java
> ===================================================================
> RCS file: /home/cvspublic/xml-fop/src/org/apache/fop/fo/flow/BasicLink.java,v
> retrieving revision 1.8
> diff -r1.8 BasicLink.java
> 23c23
> <     public static class Maker extends FObj.Maker {
> ---
> >     public static class Maker extends Inline.Maker {
> 44,78d43
> <
> <         // Common Accessibility Properties
> <         AccessibilityProps mAccProps = propMgr.getAccessibilityProps();
> <
> <         // Common Aural Properties
> <         AuralProps mAurProps = propMgr.getAuralProps();
> <
> <         // Common Border, Padding, and Background Properties
> <         BorderAndPadding bap = propMgr.getBorderAndPadding();
> <         BackgroundProps bProps = propMgr.getBackgroundProps();
> <
> <         // Common Margin Properties-Inline
> <         MarginInlineProps mProps = propMgr.getMarginInlineProps();
> <
> <         // Common Relative Position Properties
> <         RelativePositionProps mRelProps = 
> propMgr.getRelativePositionProps();
> <
> <         // this.properties.get("alignment-adjust");
> <         // this.properties.get("alignment-baseline");
> <         // this.properties.get("baseline-shift");
> <         // this.properties.get("destination-place-offset");
> <         // this.properties.get("dominant-baseline");
> <         // this.properties.get("external-destination");
> <         // this.properties.get("id");
> <         // this.properties.get("indicate-destination");
> <         // this.properties.get("internal-destination");
> <         // this.properties.get("keep-together");
> <         // this.properties.get("keep-with-next");
> <         // this.properties.get("keep-with-previous");
> <         // this.properties.get("line-height");
> <         // this.properties.get("line-height-shift-adjustment");
> <         // this.properties.get("show-destination");
> <         // this.properties.get("target-processing-context");
> <         // this.properties.get("target-presentation-context");
> <         // this.properties.get("target-stylesheet");
> 
> SNIP
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, email: [EMAIL PROTECTED]
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]

Reply via email to