Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination/bookmarks Bookmark.java BookmarkTitle.java BookmarkTree.java

2005-01-11 Thread Simon Pepping
On Tue, Jan 11, 2005 at 12:07:53AM -, [EMAIL PROTECTED] wrote:
 gmazza  2005/01/10 16:07:53
 
   Modified:src/java/org/apache/fop/fo Constants.java
 FOPropertyMapping.java PropertySets.java
src/java/org/apache/fop/fo/flow MultiCase.java
src/java/org/apache/fop/fo/pagination/bookmarks
 Bookmark.java BookmarkTitle.java BookmarkTree.java
   Log:
   2.) Switch from makeEnumProperty to slightly more intuitive 
 getEnumProperty in FOPropertyMapping.

It does really make a property value, which is held as in the member
enums in the property maker:

private Property makeEnumProperty(int enumValue, String text) {
if (enums == null) {
enums = new Property[ENUM_COUNT+1];
}
if (enums[enumValue] == null) {
== enums[enumValue] = new EnumProperty(enumValue, text); ===
}
return enums[enumValue];
}

Regards, Simon

-- 
Simon Pepping
home page: http://www.leverkruid.nl



Re: cvs commit: xml-fop/src/java/org/apache/fop/fo/pagination/bookmarks Bookmark.java BookmarkTitle.java BookmarkTree.java

2005-01-11 Thread Glen Mazza
True, but for all times save the first, it ends up
being a cached-value get.  Repeated across all the
FO's, the ratio would appear to be about 90% get/10%
original make.  I wanted to stress in the code that we
are not necessarily making a brand-new property
object each time it is applicable for an FO.

Ultimately, whether a property needs to be maked
(made) or is cached is just an internal implementation
issue with that get() method.  (e.g., we could choose
to create all the properties up-front, and then
implement the get() as 100% retrieval instead of
90/10.)

Glen

--- Simon Pepping [EMAIL PROTECTED] wrote:

 On Tue, Jan 11, 2005 at 12:07:53AM -,
 [EMAIL PROTECTED] wrote:
  gmazza  2005/01/10 16:07:53
  
Modified:src/java/org/apache/fop/fo
 Constants.java
  FOPropertyMapping.java
 PropertySets.java
 src/java/org/apache/fop/fo/flow
 MultiCase.java

 src/java/org/apache/fop/fo/pagination/bookmarks
  Bookmark.java
 BookmarkTitle.java BookmarkTree.java
Log:
2.) Switch from makeEnumProperty to slightly
 more intuitive getEnumProperty in
 FOPropertyMapping.
 
 It does really make a property value, which is held
 as in the member
 enums in the property maker:
 
 private Property makeEnumProperty(int enumValue,
 String text) {
 if (enums == null) {
 enums = new Property[ENUM_COUNT+1];
 }
 if (enums[enumValue] == null) {
 == enums[enumValue] = new
 EnumProperty(enumValue, text); ===
 }
 return enums[enumValue];
 }
 
 Regards, Simon
 
 -- 
 Simon Pepping
 home page: http://www.leverkruid.nl