Re: uncommitted patches

2002-01-11 Thread Christian Geisert

Keiron Liddle wrote:
 
 Hi Christian,
 
 I agree that it is good to get patches in, the problem has been that in
 many cases these patches are altering messy code (eg. LineArea.java) and

I had the same thoughts while looking at the patches... but I think it's ok
for the maintenance branch.

 its a case of fix one problem and create others or it is not clear if it
 works properly. This problem is best solved by better design and testing
 (and more resources).

Absolutly agreed. The most important (and hardest) part is the to make a good
new design (and I hope I can contribute a bit).

 I will commit the ones you propose and hope for the best.

Thanx! 

 Regards,
 Keiron.

Christian

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]




Re: uncommitted patches

2002-01-10 Thread Peter S. Housel

 while browsing the archives I found the following uncomitted patches,
 and as it is quite frustrating if your patch gets not noticed (and you
 worked hard for it..) we should try to commit all (if possible).

 * improved font-encoding by Peter S. Housel
 (see http://marc.theaimsgroup.com/?l=fop-devm=100559770232644w=2)
 To build with this patch you need optional.jar from ant 1.3
 (download

http://jakarta.apache.org/builds/jakarta-ant/release/v1.3/bin/jakarta-ant-1.
3-optional.jar
 and copy it to lib/optional.jar) and add it to build.bat (build.sh has it
two
 times ;-)
 I noticed the same problems as Rainer Garus
 (see http://marc.theaimsgroup.com/?l=fop-devm=100790930100949w=2)
 Peter, what do you think?

I'll fix the problems and come up with a revised patch by this weekend.

Cheers,
-Peter S. Housel-   [EMAIL PROTECTED]   http://members.home.com/housel/



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]