Re: XSL-FO 2.0 workshop in Heidelberg next week

2006-10-11 Thread Nicol Bolas
Oh, I found a good one in the 1.1 spec. Remove page-position=last/only; there is no way to guarentee that it can work. There is no algorithm that can make it work in the general case. Sure, if the last page and the page that would have been there had it not been the last page used the same

Re: svn commit: r462726 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/MultiByteFont.java fonts/truetype/TTFFile.java pdf/PDFToUnicodeCMap.java

2006-10-11 Thread Bertrand Delacretaz
On 10/11/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: URL: http://svn.apache.org/viewvc?view=revrev=462726 Log: code style TAB characters license headers... Sorry about that - sloppy work from me here. I must admit that I hate checkstyle's rigid rules when they get in the way sometimes

DO NOT REPLY [Bug 40676] - png graphics are expanded/uncompressed in pdf causing massive file size increase

2006-10-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40676. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 5335] - Text with embedded CID fonts not retrievable from pdf

2006-10-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=5335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: svn commit: r462726 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/MultiByteFont.java fonts/truetype/TTFFile.java pdf/PDFToUnicodeCMap.java

2006-10-11 Thread Jeremias Maerki
On 11.10.2006 10:11:41 Bertrand Delacretaz wrote: On 10/11/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: URL: http://svn.apache.org/viewvc?view=revrev=462726 Log: code style TAB characters license headers... Sorry about that - sloppy work from me here. No problem. Caught and

[VOTE] Vincent Hennebert as new committer

2006-10-11 Thread Jeremias Maerki
Simon and I were able too meet Vincent Hennebert in person in Amsterdam last week. He has already made an impression with his excellent work for the GSoC. He's a very nice and intelligent guy, eager to learn and to work on FOP. Another guy who's not afraid to jump into the depths of the layout

DO NOT REPLY [Bug 5335] - Text with embedded CID fonts not retrievable from pdf

2006-10-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=5335. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

RE: Including an sRGB color profile?

2006-10-11 Thread Peter
I ran the unit tests and I am getting a failure in StandardTestSuite - testEquals. The reason for the failure is a change in ColorUtil (see 4/ lower). Would changing the test to no longer check for unequality between two returned Color objects be an option? Thanks, Peter -Original

Re: Including an sRGB color profile?

2006-10-11 Thread Jeremias Maerki
On 10.10.2006 21:31:49 Peter Coppens wrote: I finished(?) working on the somewhat modified items (1), (2) and (4) of Jerememias' list. I plan to clean up to code a bit and then try to submit a patch (there should be a first time for everything I guess :)) It's not that difficult. :-)

Re: Including an sRGB color profile?

2006-10-11 Thread Jeremias Maerki
I think the test is fine. Can you tell why the two Color instances cannot be compared anymore? Do you have to override the equals() method of your Color subclasses? On 11.10.2006 11:22:13 Peter wrote: I ran the unit tests and I am getting a failure in StandardTestSuite - testEquals. The

RE: Including an sRGB color profile?

2006-10-11 Thread Peter
The test fails on assertTrue(col1 != col2); Before the change I made that was ok as the Color object was cloned just before being returned The code in ColorUtil was // TODO: Check if this is really necessary return new Color(parsedColor.getRed(),

RE: Including an sRGB color profile?

2006-10-11 Thread Peter
Would you please try to run URI resolution through FOUserAgent.resolveURI()? That way we'll have a uniform URI resolution everywhere. I understand your concern. I will look into it but the issue is that ColorUtil is really a bunch of static methods that at this stage have no access to any

DO NOT REPLY [Bug 40724] New: - Kerning does not work for user-specified CID fonts

2006-10-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40724. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 40464] - Improve handling of OpenType fonts

2006-10-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40464. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 40724] - Kerning does not work for user-specified CID fonts

2006-10-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40724. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Kerning for CID fonts, use unicode indexes in kerning?

2006-10-11 Thread Bertrand Delacretaz
Hi FOPpers, See http://issues.apache.org/bugzilla/show_bug.cgi?id=40724 , kerning doesn't work for me with user-specified CID fonts at the moment. IIUC the code, org.apache.fop.layoutmgr.inline.TextLayoutManager expects unicode indexes for kerning pairs, but currently the TTFReader writes glyph

Re: Including an sRGB color profile?

2006-10-11 Thread Jeremias Maerki
Ah, ok. In your message you talked about unequality which is not the same as identity. The first test (!=) test for identity. This can be removed. The second tests for equality (equals()). On 11.10.2006 11:42:56 Peter wrote: The test fails on assertTrue(col1 != col2); Before the

Re: Including an sRGB color profile?

2006-10-11 Thread Jeremias Maerki
Ok for me, as long as we track the outstanding issues. On 11.10.2006 12:01:19 Peter wrote: Would you please try to run URI resolution through FOUserAgent.resolveURI()? That way we'll have a uniform URI resolution everywhere. I understand your concern. I will look into it but the issue

Re: Kerning for CID fonts, use unicode indexes in kerning?

2006-10-11 Thread Jeremias Maerki
I wonder where this got broken. I believe this used to work. If this change has an effect on the XML files generated, then we should be careful because people might not recreate their metric files and subsequently run into problems. On 11.10.2006 13:15:54 Bertrand Delacretaz wrote: Hi FOPpers,

RE: Including an sRGB color profile?

2006-10-11 Thread Peter
Some more informationfound during the last few hoursand finished typing in just before your reply came in. I have been trying to figure out whether it would help to add an instance of ColorUtil to the FOUserAgent (and changing some of its methods and members to instance level) Skipping

Re: Including an sRGB color profile?

2006-10-11 Thread Jeremias Maerki
ColorUtil, as the name implies, is a utility class and it doesn't feel right to put an instance of it in FOUserAgent. I would extract the profile caching into a separate class and put that there (or rather in the FopFactory so multiple rendering runs can use the cache). The ColorUtil methods

RE: Including an sRGB color profile?

2006-10-11 Thread Peter
Would you please try to run URI resolution through FOUserAgent.resolveURI()? That way we'll have a uniform URI resolution everywhere. I am trying, but have a question - does that mean a new base uri config setting has to be introduced, equivalent to e.g. the fontBaseURL ?

Re: Including an sRGB color profile?

2006-10-11 Thread Jeremias Maerki
No, not as long as a special base URL for that is requested by anybody. The normal base URL should be used in this case. Too many different base URLs only causes confusion. On 11.10.2006 16:48:38 Peter wrote: Would you please try to run URI resolution through FOUserAgent.resolveURI()? That

Re: svn commit: r462814 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFToUnicodeCMap.java

2006-10-11 Thread Vincent Hennebert
Grmblbmlbbllbll. Forgot to change my Eclipse settings. Sorry, won't happen again :-\ Vincent Author: jeremias Date: Wed Oct 11 07:30:34 2006 New Revision: 462814 URL: http://svn.apache.org/viewvc?view=revrev=462814 Log: Tabs again. :-)

RE: Including an sRGB color profile?

2006-10-11 Thread Peter
So I think I have it working but not without substantial changes A summary 1)FopFactory *) Added a synchronized Map, colorSpaceMap to cache ...ColorSpace objects(life can be easy). Don't know whether this has to be synchronized. Have not looked into the details of FOP MT features.

Re: Including an sRGB color profile?

2006-10-11 Thread Jeremias Maerki
Without seeing the code, no objections here. It's good to be on the safe side by using a synchronized Map. I'll look into the base parameter for getColorSpace() when I see the code. When you submit the first patch, please don't expect a fast turn-around, since right now I can't tell when I will

Re: Kerning for CID fonts, use unicode indexes in kerning?

2006-10-11 Thread Bertrand Delacretaz
On 10/11/06, Jeremias Maerki [EMAIL PROTECTED] wrote: ...If this change has an effect on the XML files generated, then we should be careful because people might not recreate their metric files and subsequently run into problems... How about adding a version number to the XML metrics files?

Re: Kerning for CID fonts, use unicode indexes in kerning?

2006-10-11 Thread Jeremias Maerki
Sure. However, as we discussed in Amsterdam, the goal should be that we don't rely on those XML files much longer, so I wonder how much should be invested in versioning of those files. But if you don't see a way around it... I still don't understand why exactly this change is necessary. On

DO NOT REPLY [Bug 40729] New: - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

2006-10-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40729. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

2006-10-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40729. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

RE: Including an sRGB color profile?

2006-10-11 Thread Peter
I filed it (http://issues.apache.org/bugzilla/show_bug.cgi?id=40729) Thanks for your patience and support. Would not have worked without it. Next is svg I guessbut I am not sure that will be immediately. I have only a day or so left for now. Peter -Original Message- From: