Re: svn commit: r674484 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/xml/AbstractXMLRenderer.java

2008-07-08 Thread Adrian Cumiskey
As it is, I have a class in the Temp_AreaTreeRedesign branch that extends AbstractXMLRenderer. I thought it useful to provide the class in trunk for anyone else who may wish to create their own XML based renderer for whatever purposes. However, IMO you can never have enough abstract classes,

Re: DO NOT REPLY [Bug 40798] page-position=last doesn' t work for 1 page document

2008-07-08 Thread Peter B. West
[EMAIL PROTECTED] wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=40798 ... I haven't gone back to the spec or the code, but assuming 1) that an only page is also both first and last, and 2) that isOnlyPage tells the truth about the page being tested, the problem seems to be with

Re: DO NOT REPLY [Bug 40798] page-position=last doesn' t work for 1 page document

2008-07-08 Thread David Gerdt
I would agree with premise 1, but 2 is incorrect I believe. I don't have my proper development environment in front of me at the moment, but I believe you can trace the calls used to reach isValid back to PageProvider.cacheNextPage where you will find code like: SimplePageMaster spm =

Re: DO NOT REPLY [Bug 40798] page-position=last doesn' t work for 1 page document

2008-07-08 Thread Peter B. West
Ok. In that case, isOnlyPage is equivalent to (startPageOfPageSequence == index) isLastPage and then either replace the 'false' in the getSimplePageMaster call with that expression, or replace if (isOnlyPage) with if (isFirstPage isLastPage) Will either of these work with the rest of