Re: FIleChannel accessible BufferedOutputStream

2008-11-10 Thread Adrian Cumiskey
Max, I understand what you are saying, but I am trying not to change too much code or FOP's API with this change. Currently the BufferedOutputStream is passed as an OutputStream reference all the way down the calling chain during rendering. So although your suggestion would result in a much

Re: FIleChannel accessible BufferedOutputStream

2008-11-10 Thread Adrian Cumiskey
Jeremias, To be honest I was just guessing and hoping it would be better, I would have expected some improvement.. but alas I've just done some testing and its actually slower.. so I think I'll scrap this idea and we'll stick with plain old BufferedOutputStream. Thanks for the feedback and

Re: FIleChannel accessible BufferedOutputStream

2008-11-10 Thread Jeremias Maerki
So what will happen if there's no FileChannel available (for example, in a servlet)? Will the AFP output stop working? In additional to what Max wrote (preserving compatibility with output targets that are not nio-compatible), I'd say that bit of potential performance improvement is totally irrele

Re: FIleChannel accessible BufferedOutputStream

2008-11-10 Thread Adrian Cumiskey
Jeremias Maerki wrote: So what will happen if there's no FileChannel available (for example, in a servlet)? Will the AFP output stop working? Of course there would have been provision for plain old OutputStream handling, this really goes without saying doesn't it? In additional to what Max

FIleChannel accessible BufferedOutputStream

2008-11-10 Thread Adrian Cumiskey
When FOP is started in Main.startFOP() a java.io.BufferedOutputStream is instantiated and wrapped around an instantiated java.io.FileOutputStream. By wrapping the initial java.io.FileOutputStream with a java.io.BufferedOutputStream, FOP is not able to potentially make use of the nio FileChannel

DO NOT REPLY [Bug 46176] New: colspan in HTML tables produces incorrect table rendering

2008-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46176 Summary: colspan in HTML tables produces incorrect table rendering Product: Fop Version: 0.95 Platform: PC OS/Version: Windows Vista Status: NEW Sev

Re: FIleChannel accessible BufferedOutputStream

2008-11-10 Thread Max Berger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adrian, when doing this you need to be very careful that either the BufferedOutputStream OR the FileChannel methods are used. If you start mixing both you will get very strange effects. So for safety I would prefer to pass either a stream or a channe

DO NOT REPLY [Bug 37108] Patch for 0.20.5 to work with jdk1.5

2008-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=37108 --- Comment #2 from Arpit Sen <[EMAIL PROTECTED]> 2008-11-10 15:28:32 PST --- Created an attachment (id=22850) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22850) build.xml file As per the patch given above, the attached

DO NOT REPLY [Bug 37108] Patch for 0.20.5 to work with jdk1.5

2008-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=37108 --- Comment #3 from Arpit Sen <[EMAIL PROTECTED]> 2008-11-10 15:30:54 PST --- Created an attachment (id=22851) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22851) PDFGraphics2D.java As per the patch file given above, the

DO NOT REPLY [Bug 37108] Patch for 0.20.5 to work with jdk1.5

2008-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=37108 Jeremias Maerki <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED