Bug report for Fop [2009/09/27]

2009-09-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Re: Best Interface for reading OpenType Files

2009-09-28 Thread Vincent Hennebert
Hi Alexander, Alexander Kiel wrote: Hi Vincent, I had a look at SeekableStream and I can imagine how the needs resulted in the ImageInputStream interface. I haven't decided yet if I should use ImageInputStream directly. Maybe someone else can throw it's two cents in here. Here are my two

Re: Unit Tests in Intellij Idea

2009-09-28 Thread Vincent Hennebert
Hi Alexander, Alexander Kiel wrote: Hi Jeremias, thanks for that. I just changed the Idea output dirs to match that from Ant and now almost all tests run. The test/layoutengine/disabled-testcases.xml file lists tests that don’t currently pass. You have to set the fop.layoutengine.disabled

Re: Checkstyle RedundantThrowsCheck

2009-09-28 Thread Vincent Hennebert
Hi, Jeremias Maerki wrote: On 27.09.2009 13:27:35 Alexander Kiel wrote: Hi Jeremias, Makes sense. I stumbled over that myself from time to time but it didn't really bother me so much to take action. Okay. Can you please modify the checkstyle XML files to reflect that? Sure, but only

Re: Checkstyle RedundantThrowsCheck

2009-09-28 Thread Max Berger
Alex, The checkstyle checks are historically grown, and are therefore incomplete. I personally would turn on much more checks for certain style issues I like. IMO every option set helps deciding a certain factor. So more the more checks the better :) (in short: +1 to your changes). Right now we

Re: Confused about checkstyle use

2009-09-28 Thread Vincent Hennebert
Hi Guys, Maybe a bit late, but you may find the following page interesting: http://wiki.apache.org/xmlgraphics-fop/FOPIntelliJSetup Feel free to make any additions or corrections to this document. As to the use of checkstyle: I think the rules were set up long after the project was created. So

Re: omit first table header/last footer

2009-09-28 Thread Vincent Hennebert
Hi Carlos, Carlos Villegas wrote: Hi, I searched the mailing lists and it seems that although some people had worked at several times at trying to implement retrieve-table-marker, it's not yet done. Is somebody working on this? What's the status? It’s not being worked on at the moment.

Re: Questionable whether font-shorthand grammar LL(1)

2009-09-28 Thread Vincent Hennebert
Hi Jonathan, Interesting stuff! Jonathan Levinson wrote: Hi Vincent, snip/ Because font-variant font-style and font-weight can occur in any order, I could not (currently) come up with a grammar in which the directing sets were disjoint for each non-terminal. So I was unable to come up

DO NOT REPLY [Bug 46883] AFP/GOCA: Performance Hot Spot in AbstractGraphicsDrawingOrderContainer.getDataLength()

2009-09-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46883 Jeremias Maerki jerem...@apache.org changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: omit first table header/last footer

2009-09-28 Thread Carlos Villegas
Thanks for the pointers. I agree that implementing retrieve-table-marker is not only a more generic solution but also what the spec requires. However, I'm short on time and this seems easier so I'll give it a try first. Regards, Carlos Vincent Hennebert wrote: Hi Carlos, Carlos Villegas

Re: When must the structure tree be output in the PDF file?

2009-09-28 Thread Vincent Hennebert
Hi Jeremias, Jeremias Maerki wrote: snip/ IFParser is also still missing the parse code for the structure tree. I guess I would defer the call to startPageSequence in the IFParser, then parse the reduced FO tree using a ContentHandler delegate, set that on the user agent and then call

Re: Confused about checkstyle use

2009-09-28 Thread Alexander Kiel
Hi Vincent, However, new committed code is not supposed to break any rule, neither warnings nor errors. Really? That means commenting every public method even simple Getters and Setters? Commenting equals(), hashCode() and toString()? I think, this would be only clutter. Best Regards Alex

RE: Confused about checkstyle use

2009-09-28 Thread Alexander Kiel
Hi Jonathan, However, I notice there are still warnings. BlockStackingLayoutManager.java: 16 items Missing a Javadoc comment. (58:5) 'parentArea' hides a field. (115:47) 'parentArea' hides a field. (145:50) Method length is 185 lines (max allowed is 150) (372:5) Etc., At

Re: Best Interface for reading OpenType Files

2009-09-28 Thread Alexander Kiel
Hi Vincent, Here are my two cents: if you make use of classes in javax.imagio at only one place in your font library, then there’s no need to worry about creating a more neutral layer. If OTOH you need to use those classes everywhere, then it makes sense to use a simplified abstraction

Re: Confused about checkstyle use

2009-09-28 Thread Max Berger
Alex, 2009/9/28 Alexander Kiel alexanderk...@gmx.net: Hi Vincent, However, new committed code is not supposed to break any rule, neither warnings nor errors. Really? That means commenting every public method even simple Getters and Setters? Yes. Simple Getter and Setters are the only