Re: junit tests in nightly builds [was: Re: Solving FindBugs issue]

2011-02-23 Thread Glenn Adams
OK, understand on the junit headless issue. For checkstyle/findbugs it would be useful to fail the nightly build if they do not pass. I will investigate the necessary changes to enable this option, which I hope can be adopted. G. On Wed, Feb 23, 2011 at 12:55 AM, Simon Pepping

Re: junit tests in nightly builds [was: Re: Solving FindBugs issue]

2011-02-23 Thread Glenn Adams
BTW, if someone would bother to nominate me as a committer, I would be happy to do this work directly. I don't like depending on the other committers to make progress in this area any more than you like having to address it. G. On Wed, Feb 23, 2011 at 1:15 AM, Glenn Adams gl...@skynav.com wrote:

DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts

2011-02-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 --- Comment #7 from Mehdi Houshmand med1...@gmail.com 2011-02-23 03:45:29 EST --- I've added a bit of testing to the o.a.f.fonts.truetype package, some of which would be of use here, but my patch is to be applied to the

Re: junit tests in nightly builds

2011-02-23 Thread Simon Pepping
On Wed, Feb 23, 2011 at 01:15:34AM -0700, Glenn Adams wrote: OK, understand on the junit headless issue. For checkstyle/findbugs it would be useful to fail the nightly build if they do not pass. I will investigate the necessary changes to enable this option, which I hope can be adopted. I

Re: junit tests in nightly builds

2011-02-23 Thread Glenn Adams
I guess we disagree, since I believe application quality and code quality are related. And, further, I believe findbugs at least can identify real, functional bugs (as opposed to checkstyle). G. On Wed, Feb 23, 2011 at 2:01 AM, Simon Pepping spepp...@leverkruid.euwrote: On Wed, Feb 23, 2011 at

Re: junit tests in nightly builds

2011-02-23 Thread Vincent Hennebert
On 23/02/11 14:42, Glenn Adams wrote: I guess we disagree, since I believe application quality and code quality are related. And, further, I believe findbugs at least can identify real, functional bugs (as opposed to checkstyle). While I agree with the above, I’m with Simon on this. Tests

Re: junit tests in nightly builds

2011-02-23 Thread Glenn Adams
Right now the nightly build is our CI process. On Wednesday, February 23, 2011, Vincent Hennebert vhenneb...@gmail.com wrote: On 23/02/11 14:42, Glenn Adams wrote: I guess we disagree, since I believe application quality and code quality are related. And, further, I believe findbugs at least

Re: Solving FindBugs issues

2011-02-23 Thread Vincent Hennebert
Hi Simon, On 23/02/11 07:51, Simon Pepping wrote: On Tue, Feb 22, 2011 at 07:15:17PM +, Vincent Hennebert wrote: On 22/02/11 07:24, Simon Pepping wrote: Not all FOP developers are willing to use findbugs. I hid the findbugs errors as a courtesy to those FOP developers who do use findbugs,

Re: junit tests in nightly builds

2011-02-23 Thread Jeremias Maerki
Well, not quite: http://vmgump.apache.org/gump/public/xml-fop/ Basics work but it needs some love apparently. On 23.02.2011 21:10:10 Glenn Adams wrote: Right now the nightly build is our CI process. On Wednesday, February 23, 2011, Vincent Hennebert vhenneb...@gmail.com wrote: On 23/02/11

Re: junit tests in nightly builds

2011-02-23 Thread Simon Pepping
On Wed, Feb 23, 2011 at 01:10:10PM -0700, Glenn Adams wrote: Right now the nightly build is our CI process. That is a development-centric point of view. The nightly build is definitely not a CI process. It is a service to the users, which must not be interrupted by development concerns. If a