Exception handling in org.apache.fop.apps.FOURIResolver

2007-01-17 Thread Adrian Cumiskey
I am new to the FOP code so please bear with me... but have a quick question about the revolve method in FOURIResolver. It appears to catch all exceptions, log errors, silently return null and doesn't seem to ever throw a TransformerException. public Source resolve(String href, String

Re: Exception handling in org.apache.fop.apps.FOURIResolver

2007-01-17 Thread Adrian Cumiskey
thrown. Many thanks, Adrian. Adrian Cumiskey wrote: I am new to the FOP code so please bear with me... but have a quick question about the revolve method in FOURIResolver. It appears to catch all exceptions, log errors, silently return null and doesn't seem to ever throw a TransformerException

rendering pdf with examples/fo/advanced/cid-fonts.fo gives SEVERE: Could not create block pointers. FOText w/o Block ancestor

2007-01-18 Thread Adrian Cumiskey
Just tried rendering a pdf using examples/fo/advanced/cid-fonts.fo on the fop latest trunk (0.93) and got the following exception/errors :- 18-Jan-2007 17:50:27 org.apache.fop.fo.FObjMixed flushText SEVERE: Could not create block pointers. FOText w/o Block ancestor. 18-Jan-2007 17:50:27

Re: rendering pdf with examples/fo/advanced/cid-fonts.fo gives SEVERE: Could not create block pointers. FOText w/o Block ancestor

2007-01-19 Thread Adrian Cumiskey
This not my FO document, but is a *standard one* in the examples folder provided with the fop distribution. I tried removing the enclosing fo:wrapper from the example fo document and it generated a pdf without problems. The following patch file seems to fix the ClassCastException and a pdf

Re: SVG in PDF : KEY_AVOID_TILE_PAINTING Exception

2007-01-23 Thread Adrian Cumiskey
Hi Didier, You could try launching Tomcat with -verbose option on your JVM to make sure that the batik-awt-util.jar is being picked up. I use JDK 1.4.2 for all my development. Maybe your Batik libraries were compiled with a different JDK than FOP and there is some incompatibility. If so

[Fwd: Re: Error: Content is not allowed in prolog]

2007-01-29 Thread Adrian Cumiskey
Hi Jeff, Please take a look at Jeremias's reply to your posting on fop-users. All the best, Adrian. ---BeginMessage--- On 26.01.2007 15:42:49 Jeff Vannest wrote: I've embedded FOP 0.93 successfully am able to process XML+XSLFO=PDF. However, when I try embed fonts I get this error message:

Re: DO NOT REPLY [Bug 41514] - [PATCH] Strict url validation of user config

2007-02-07 Thread Adrian Cumiskey
-configuration == true then FOP will immediately raise an exception and will not continue trying to configure itself. I have attached a new patch file containing these changes (this includes related documentation changes). This new patch file superceeds the previous one. Kind regards, Adrian Cumiskey.

Re: DO NOT REPLY [Bug 41514] - [PATCH] Strict url validation of user config

2007-02-08 Thread Adrian Cumiskey
Vincent Hennebert wrote: Yes, the patch doesn't seem to break anything. We could even go a bit further: the cfg parameter is no longer used in the FOUserAgent.configure() method, it might be removed. Also, would the FopFactory.getUserConfig() method not be public, I would even remove it, and

fop.bat needs patching

2007-03-07 Thread Adrian Cumiskey
This is a quicky.. Our fop.bat is currently broken, someone needs to update fop.bat to reflect the recently added new xmlgraphics-commons-1.2svn.jar on the trunk. I have added this patch to the patch list (http://issues.apache.org/bugzilla/show_bug.cgi?id=41778). --- fop.bat Wed Mar 07

Re: Is that correct jar in SVN: xmlgraphics-commons-1.2svn.jar?

2007-03-13 Thread Adrian Cumiskey
I believe this might probably be an Apache naming convention... but it may not be such a grand reason... :-) Andrejus Chaliapinas wrote: Hi, Just wonder if that svn suffix in jar name for xmlgraphics-commons-1.2svn.jar is correct. I could see it under trunk lib directory. I think that

Re: PDF internal links re-implementation - advice sought

2007-03-21 Thread Adrian Cumiskey
Hi Paul, Paul Vinkenoog wrote: Hi all, I've recently re-implemented the full internal links behaviour in the PDF renderer. (I produce documentation for the Firebird project. FOP 0.93 solved a lot of our problems but we make use of links extensively, and having them land on the top of the page

startPageSequence() in Renderer interface

2007-04-02 Thread Adrian Cumiskey
the PageSequence itself (which contains the title). I would think that the PageSequence object itself would be much more useful to the renderer. Am I missing something? Is there a good reason which I have missed as to why it is implemented in this way? Adrian Cumiskey.

Re: startPageSequence() in Renderer interface

2007-04-04 Thread Adrian Cumiskey
Hi all, Jeremias Maerki wrote: Hi Adrian On 02.04.2007 11:05:03 Adrian Cumiskey wrote: Of course this would mean a change in a low level interface but would be a trivial change for all our renderers. our renderers, yes. You also need to consider custom renderer developed outside of FOP

update 0.20 and 0.93 xdocs index pages?

2007-06-07 Thread Adrian Cumiskey
Hi all, I have just stumbles upon the FOP main xdocs index pages :- 0.20.5 http://xmlgraphics.apache.org/fop/0.20.5/index.html 0.93http://xmlgraphics.apache.org/fop/0.93/index.html I believe that these 'About' descriptions no longer reflect the current state of the project and suggest

Re: update 0.20 and 0.93 xdocs index pages?

2007-06-07 Thread Adrian Cumiskey
Thanks Clay, Hopefully from now on we will start to see more user questions related to 0.93/trunk and less from 0.20.5 :-). Adrian. The Web Maestro wrote: On 6/7/07, Adrian Cumiskey [EMAIL PROTECTED] wrote: I have attached a patch file to update the descriptions to something which maybe

Re: Anyone heard from Andreas?

2007-06-25 Thread Adrian Cumiskey
Andreas L Delmelle wrote: On Jun 19, 2007, at 02:12, Peter B. West wrote: Hi Peter all, I haven't seen anything from Andreas for some time now, and I was wondering if anyone had heard from him privately. Rumors of my death etc. :) Glad to see you alive, I was thinking you were probably

Re: Row backgrounds vs table background

2007-06-29 Thread Adrian Cumiskey
I suppose when the spec is unclear common sense should prevail. So no disagreements. Adrian. Jeremias Maerki wrote: Hmm, I don't find anything in XSL 1.1 or CSS 2 that would be clear enough for either solution. So I can't say it's either left or right, but my personal preference would be the

junit-layout-standard test broken

2007-07-12 Thread Adrian Cumiskey
The junit-layout-standard target seems to broken on trunk... [junit] Testcase: markers_4.xml(org.apache.fop.layoutengine.LayoutEngineTestSuite$1): Caused an ERROR [junit] Expected XPath expression to evaluate to '0', but got '' (XPath: //regionBefore/block[2]/lineArea/text)

Re: junit-layout-standard test broken

2007-07-12 Thread Adrian Cumiskey
I thought for a moment it was my font detection patch until I sanity checked myself and built a fresh trunk :-) Adrian. Andreas L Delmelle wrote: On Jul 12, 2007, at 15:49, Vincent Hennebert wrote: Adrian Cumiskey a écrit : The junit-layout-standard target seems to broken on trunk... My

FontSources

2007-07-16 Thread Adrian Cumiskey
Hi all, In the process of looking at this bug (http://issues.apache.org/bugzilla/show_bug.cgi?id=42861) I came to the conclusion that I´m not really happy with the current font handling implementation. There is quite a bit of duplicated effort between the renderers with regards to font

AFP default font character set

2007-07-19 Thread Adrian Cumiskey
Hi all, I have been looking at adding a new No Operation or afp:no-operation/ extension to the AFP renderer. I noticed that by default (in the absence of any configuration) the AFPRenderer sets up some base fonts which use the CZH200 character set. This character set was not available on

Re: OutOfMemoryError in current Trunk

2007-07-20 Thread Adrian Cumiskey
Fixed my patch and attached it. Adrian. Chris Bowditch wrote: Jeremias Maerki wrote: On 20.07.2007 12:51:33 Chris Bowditch wrote: Jeremias Maerki wrote: On 20.07.2007 11:52:15 Andreas L Delmelle wrote: snip/ In addition to that there was a bug in FixedLength.equals() that made the

Re: OutOfMemoryError in current Trunk

2007-07-20 Thread Adrian Cumiskey
Attached revised fix. Jeremias Maerki wrote: Adrian, you forgot to account for the case where the GC removes the instance in the worst possible moment and WeakReference.get() returns null. On 20.07.2007 16:33:34 Adrian Cumiskey wrote: Index: src/java/org/apache/fop/fo/properties

Subversion update problems

2007-07-23 Thread Adrian Cumiskey
Hi all, I realise this isn't a FOP question but when I try to update my trunk sandbox with subversion I get svn: Delta source ended unexpectedly. Does anyone else experiencing this problem? svn up -N (non-recursive update works fine) and so does a fresh checkout of svn co

Re: Subversion update problems

2007-07-23 Thread Adrian Cumiskey
folder again and copying my files across to get it working again, was pretty annoying though.. it seems subversion is far from perfect :-[ Adrian. On 23/07/07, Andreas L Delmelle [EMAIL PROTECTED] wrote: On Jul 23, 2007, at 15:37, Vincent Hennebert wrote: Adrian Cumiskey a écrit : Hi all, I

Re: Cannot build with JDK 1.3

2007-08-14 Thread Adrian Cumiskey
Hi Vincent, I spent a couple of hours yesterday trying to get it working on my system (Feisty Ubuntu and using Sun Java 1.3.1_20-b03). Initially I had a little bit of tweaking to do as ant seems to want to use org.apache.xml.serializer.SerializerTrace which isn't bundled with the default

Re: embedding font Bundesbahn-Pi at FOP

2007-08-16 Thread Adrian Cumiskey
and everyone, I have sent it to you for you to take a look at it (font and FO). if there's something that is useful for me/others to know, please do tell me. Otherwise, does anyone has any idea where else I can look for software solution that might accommodate this ? William. Adrian Cumiskey wrote

Re: Cannot build with JDK 1.3

2007-08-17 Thread Adrian Cumiskey
Hi Vincent, Just to confirm with you, I experienced *exactly* the same nonsensical NoSuchMethodError(s) when running the junit tests. Its a strange one... Adrian. Vincent Hennebert wrote: Hi Andreas, Sorry for the delay. Andreas L Delmelle a écrit : On Aug 14, 2007, at 15:50, Vincent

Re: Cannot build with JDK 1.3

2007-08-17 Thread Adrian Cumiskey
will now try and work my way through the rest of them and submit a patch. Adrian. Christian Geisert wrote: Adrian Cumiskey schrieb: Hi Vincent, Just to confirm with you, I experienced *exactly* the same nonsensical NoSuchMethodError(s) when running the junit tests. Its a strange one... Same

Re: Cannot build with JDK 1.3

2007-08-17 Thread Adrian Cumiskey
Guys, Please review/try out the patch I just submitted (http://issues.apache.org/bugzilla/show_bug.cgi?id=43156) and let me know if it fixes the MethodNotFoundError(s) on your ant junit target on the fop-0_94 branch when using jdk1.3. Cheers, Adrian. Christian Geisert wrote: Vincent

Re: Cannot build with JDK 1.3

2007-08-18 Thread Adrian Cumiskey
On 18/08/07, Vincent Hennebert [EMAIL PROTECTED] wrote: Hi Andreas, Thanks for chiming in! That's exactly the comment I was needing :-) Andreas L Delmelle a écrit : On Aug 17, 2007, at 18:33, Adrian Cumiskey wrote: Hi Adrian, Please review/try out the patch I just submitted (http

Re: Cannot build with JDK 1.3

2007-08-18 Thread Adrian Cumiskey
Hi all, I believe it was the introduction of the property getInstance() refactoring which inadvertently introduced this incompatibility. I say this because all 1.3 because the unit tests all pass fine with 0.93. I totally agree with and understand your thinking on this Andreas, but on balance I

Re: embedding font Bundesbahn-Pi at FOP

2007-08-20 Thread Adrian Cumiskey
should I do since I've never followed fop-dev before. Thanks. Adrian Cumiskey wrote: Hi William (and all), This did turn out to be an encoding problem after all. Unfortunately I do not have the time at the moment to provide a fix for this problem. but I have provided a patch which provides

Re: Fonts page?

2007-09-07 Thread Adrian Cumiskey
(revision 573539) +++ src/documentation/content/xdocs/trunk/fonts.xml (working copy) @@ -24,6 +24,7 @@ authors person name=Jeremias Märki email=/ person name=Tore Engvig email=/ + person name=Adrian Cumiskey email=/ /authors /header body @@ -129,8 +130,7 @@ More

fop site publish

2007-10-26 Thread Adrian Cumiskey
Hi all, Having updated the team page today I thought I would try and publish the updated page. So I followed the instructions on http://xmlgraphics.apache.org/fop/dev/doc.html, created a deploy.svn.settings configuration file in the project parent folder with my authentication details and

Re: fop site publish

2007-10-26 Thread Adrian Cumiskey
Many thanks for your help Jeremias, it worked now :-) Adrian. Jeremias Maerki wrote: Please retry. I've fixed the permissions so non-PMCers can also update the website. Jeremias Maerki On 26.10.2007 16:58:31 Adrian Cumiskey wrote: Hi all, Having updated the team page today I thought I

Re: [VOTE] Max Berger for Committer

2007-10-26 Thread Adrian Cumiskey
Well deserved Max, keep up the good work. Unfortunately being non-pmc my vote won´t count - but a big thumbs up (+1) from me :). Adrian. On 26/10/2007, Chris Bowditch [EMAIL PROTECTED] wrote: Fellow Committers, As you all know Max Berger is heavily involved with the JEuclid MathML project.

Re: Applying patches (was: Re: svn commit: r588858.....)

2007-10-27 Thread Adrian Cumiskey
Okay guys, I will try to keep those points in mind next time :) Adrian. On 27/10/2007, Andreas L Delmelle [EMAIL PROTECTED] wrote: On Oct 27, 2007, at 09:25, Jeremias Maerki wrote: Hi Just would like to add a small one: when applying patches from someone else I consider it important to

Re: Creating New org.apache.fop.fo.flow.table Package

2007-11-02 Thread Adrian Cumiskey
Hi Vincent, You certainly have more knowledge in this area than I, so I'm quite happy to go along with your suggestion :). Adrian. Vincent Hennebert wrote: Hi Guys, this proposal will be based on lazy consensus. I think that table-related FObj descendants are numerous enough to deserve

Re: svn commit: r595297 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/type1/PFMFile.java

2007-11-16 Thread Adrian Cumiskey
Hi Jeremias, As far as I know any parsed PFM file (Type 1 font) with a dfCharset=2 is using ExpertSubset encoding and similarly dfCharset=1 is Expert encoding). The problem before was that FOP was only able to detect Expert and ExpertSubset encoding types but was not able to provide the

Re: svn commit: r595297 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/type1/PFMFile.java

2007-11-17 Thread Adrian Cumiskey
support, yet. The AFM often contains the name of the encoding. In the case of FontSpecific encodings, the PFA or PFB file has to be parsed to extract the custom encoding. Jeremias Maerki On 16.11.2007 18:45:34 Adrian Cumiskey wrote: Hi Jeremias, As far as I know any parsed PFM file (Type 1

Re: Cleaning bug list

2007-11-20 Thread Adrian Cumiskey
Great and much needed work Pascal, your efforts are really appreciated. Adrian. Pascal Sancho wrote: Hi there, I've closed some bugs related to 0.20.x season, since they have been fixed in recent releases (or trunk). Hope that will help FOP team. Some of them are in WORKSFORME state.

Re: AFP Renderer problems (Re: svn commit: r603590)

2007-12-14 Thread Adrian Cumiskey
Jeremias Maerki wrote: I only have the IE plugin. No AFP hardware to test with. snif. Basically, it was just a: fo:block fo:external-graphic src=test/resources/images/img-w-size.svg/ /fo:block No special configuration (i.e. the defaults). Really the simplest of possible cases and it came

Re: AFP Renderer problems (Re: svn commit: r603590)

2007-12-14 Thread Adrian Cumiskey
Jeremias, Jeremias Maerki wrote: Adrian, I wanted to plug in the new image package into the AFPRenderer in the branch and found out that I cannot even render the simplest of SVGs (like [1]) after the addition of the Graphics2D implementation here. The image is painted but much too small and in

Re: truetype font support for AFP

2008-01-03 Thread Adrian Cumiskey
As I said in my previous response, FOP doesn't currently support truetype fonts for AFP output. Your question doesn't sound like it is XSL FO or FOP related so this is probably the wrong forum. I suggest you contact IBM directly. Adrian. falchionli wrote: Adrian Cumiskey, I'm studying

Re: Reverting changes in AFP Renderer

2008-02-25 Thread Adrian Cumiskey
Hi Jeremias, I started to do this but if you prefer then be all means go ahead and revert yourself. The approach I took was to take a trunk checkout and then apply svn merge -r603590:603589 . This should give you all the changes between commits (as 603589 works ok, but 603590 is broken) and

Re: Reverting changes in AFP Renderer

2008-02-26 Thread Adrian Cumiskey
the adjustment for the changed CTM behaviour in BlockViewports. On 25.02.2008 14:27:27 Adrian Cumiskey wrote: Hi Jeremias, I started to do this but if you prefer then be all means go ahead and revert yourself. The approach I took was to take a trunk checkout and then apply svn merge -r603590:603589

Re: Reverting changes in AFP Renderer

2008-02-26 Thread Adrian Cumiskey
:45:17 Adrian Cumiskey wrote: Hi Jeremias, Yes I noticed this too in the AFP renderer and I am looking at trying to reuse more of AbstractPathOrientedRenderer and bring it more into line with the state/breakout approach of the PDF/PS renderers in the Temp_AFPAffineTransform branch. Also looking

Re: Reverting changes in AFP Renderer

2008-02-27 Thread Adrian Cumiskey
Reply below.. Jeremias Maerki wrote: I'm not sure I follow you. Do you mean that you'd always maintain the transformation stack in the renderer? That's certainly something that needs to be done in a uniform way. Yes, a base renderer/painter could maintain both the transformation stack and

GUI Configuration Tool

2008-03-12 Thread Adrian Cumiskey
Even though FOP configuration is quite well documented (http://xmlgraphics.apache.org/fop/0.94/configuration.html), I think there is a need for a FOP configuration tool. It would help new users get up and running quickly and allow existing users to easily manage their existing configurations.

Re: [VOTE] Merge Temp_ProcessingFeedback branch into Trunk

2008-04-07 Thread Adrian Cumiskey
Voting on this feels a little bit like shooting myself in the foot as I'm sure it will cause me some merge work on the branch I'm working on... but +1 :). Adrian. On 07/04/2008, Christian Geisert [EMAIL PROTECTED] wrote: Jeremias Maerki schrieb: As announced three days ago, I'd like to call

Re: [VOTE:RESULTS] Merge Temp_ProcessingFeedback branch into Trunk

2008-04-14 Thread Adrian Cumiskey
Hi Jeremias, I couldn't find event-model.xml anywhere.. have I missed something? Exception in thread main java.lang.ExceptionInInitializerError at org.apache.fop.apps.FOUserAgent.init(FOUserAgent.java:98) at org.apache.fop.apps.FopFactory.newFOUserAgent(FopFactory.java:177)

Re: Merge Temp_ProcessingFeedback branch into Trunk

2008-04-15 Thread Adrian Cumiskey
Thanks that now works fine for me :). Jeremias Maerki wrote: You need to run the build at least to target resourcegen, i.e. ant resourcegen. That generated the event-model.xml. On 14.04.2008 17:09:49 Adrian Cumiskey wrote: Hi Jeremias, I couldn't find event-model.xml anywhere.. have I

Re: svn commit: r648381 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/fo/flow/table/ src/java/org/apache/fop/layoutmgr/ src/java/org/apache/fop/layoutmgr/inline/ src/java/org/apache/fop/layo

2008-04-19 Thread Adrian Cumiskey
We each have different ideas about what quality software means and the compromises we make with the costs associated with it. Its important to try and be tolerant and respectful and give positive reinforcement to everyone who contributes to the project. I don't think it would harm if *all* FOP

Re: Mapping font references to a base 14 font

2008-04-24 Thread Adrian Cumiskey
choose a different name. ;-) WDYT? If you don't get any feedback from any user here I think it's better to move this to fop-dev as it becomes a design discussion. On 23.04.2008 14:28:21 Adrian Cumiskey wrote: Hi all, As most of you probably already know, you are currently able to map font

Re: svn commit: r651544 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/expr/RelativeNumericProperty.java

2008-04-25 Thread Adrian Cumiskey
Better luck next time guys... ;-) Jeremias Maerki wrote: Me, too. Had a conflict when I tried to commit. Hehe. On 25.04.2008 11:07:24 Andreas Delmelle wrote: On Apr 25, 2008, at 11:04, [EMAIL PROTECTED] wrote: Author: acumiskey Date: Fri Apr 25 02:04:06 2008 New Revision: 651544 URL:

Re: svn commit: r651551 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/pagination/PageSequence.java

2008-04-25 Thread Adrian Cumiskey
Looks fine to me. Andreas Delmelle wrote: On Apr 25, 2008, at 11:30, [EMAIL PROTECTED] wrote: Author: adelmelle Date: Fri Apr 25 02:30:09 2008 New Revision: 651551 URL: http://svn.apache.org/viewvc?rev=651551view=rev Log: Cleanup: removal of commented block/methods + some javadoc updates

Re: Font auto-detection and font referencing

2008-04-29 Thread Adrian Cumiskey
Jeremias, I think we may have some crossed wires here as I communicated that I'd be working in this area and have been working on a matching mechanism following your suggested font-substitution-catalog configuration. I very much hope I don't feel the need to throw anything away as my

Re: Font auto-detection and font referencing

2008-04-30 Thread Adrian Cumiskey
. I just thought I'd share what I came up with. After all this is nothing big and it's very easy for me to go a different route if necessary. My main work was in areas where you won't have to change anything. But WDYT about my proposal? Useful? Stupid? On 29.04.2008 19:02:13 Adrian Cumiskey wrote

Re: Font auto-detection and font referencing

2008-04-30 Thread Adrian Cumiskey
in peace and I'll integrate mine later. But of course, I can post my changes once I've finished testing. Should be later today. Still looking for feedback for my proposal ;-) On 30.04.2008 11:10:42 Adrian Cumiskey wrote: I'm not angry, well maybe a little bit annoyed initially... ;-) - I know

Re: svn commit: r652673 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/events/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/fo/flow/ src/java/org/apache/fop/layoutmgr/ test/fotree/testcas

2008-05-02 Thread Adrian Cumiskey
Hi Andreas, I'm guessing by flaws and dirt you are referring to the broken junit test in FOTreeTestSuite due to fo:retrieve-table-marker being a child of fo:block in test/fotree/testcases/table_retrieve-table-marker.fo. Spec states: An fo:retrieve-table-marker is only permitted as the

Re: svn commit: r653106 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBaseLayoutManager.java

2008-05-03 Thread Adrian Cumiskey
Hi Andreas, The member variable fobj was assigned via the super(node) constructor call. Since a correct assigment is made in a super constructor call to AbstractBaseLayoutManager, a better fix (if you want to keep the final status of the variable) would be to simply remove the second ssignment in

Re: Q: Font-cache refresh warning?

2008-05-07 Thread Adrian Cumiskey
Hi Andreas, If you update your local sandbox it should now fix itself the next time you compile and run. Cheers, Adrian. 2008/5/7 Andreas Delmelle [EMAIL PROTECTED]: Hi, One for Adrian, I presume: after updating my local sandbox, I got warnings about the FontCache being refreshed. At

Re: svn commit: r653826 [1/3] - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/trunk/ src/java/org/apache/fop/apps/ src/java/org/apache/fop/fonts/ src/java/org/apache/fop/fonts/autodete

2008-05-09 Thread Adrian Cumiskey
Andreas Delmelle wrote: On May 9, 2008, at 16:25, Vincent Hennebert wrote: Nice job! Two nits: I second this, and have an additional consideration: +/** + * Returns the font manager + * @return the font manager + */ +public FontManager getFontManager() { +if

Re: svn commit: r653826 [1/3] - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/trunk/ src/java/org/apache/fop/apps/ src/java/org/apache/fop/fonts/ src/java/org/apache/fop/fonts/autodete

2008-05-09 Thread Adrian Cumiskey
Hi Andreas, I've thought about it and made your suggested change, also keeps the code in line with the existing instantiation scheme in the constructor :). Thanks for the feedback, Adrian. Andreas Delmelle wrote: On May 9, 2008, at 17:22, Adrian Cumiskey wrote: Andreas Delmelle wrote

Re: svn commit: r653826 [1/3] - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/trunk/ src/java/org/apache/fop/apps/ src/java/org/apache/fop/fonts/ src/java/org/apache/fop/fonts/autodete

2008-05-09 Thread Adrian Cumiskey
Hi Vincent, Thanks a lot for taking the time to comb through my large patch :). Vincent Hennebert wrote: Hi Adrian, Nice job! Two nits: Author: acumiskey Date: Tue May 6 09:14:09 2008 New Revision: 653826 snip/ Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/apps/FopFactory.java

8 Unit Tests Broken

2008-05-13 Thread Adrian Cumiskey
Hi all, When merging across, I discovered that my fresh checked out sandbox of trunk is showing 8 unit tests broken at the moment (mostly in the layout engine). We shouldn't really commit any code that breaks unit tests, any chance we could try and fix these? :) Adrian.

Re: 8 Unit Tests Broken

2008-05-13 Thread Adrian Cumiskey
(LayoutEngineTestSuite.java:219) at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193) Andreas Delmelle wrote: On May 13, 2008, at 10:55, Adrian Cumiskey wrote: Hi Adrian When merging across, I discovered that my fresh checked out sandbox of trunk is showing 8 unit tests

Re: 8 Unit Tests Broken

2008-05-13 Thread Adrian Cumiskey
The following test still fails as part of the LayoutEngineTestSuite :- wrapper_block.xml Error Expected w=14400 at position 0 but got: 0 (element-list category=breaker) java.lang.RuntimeException: Expected w=14400 at position 0 but got: 0 (element-list category=breaker) at

Re: Can not check out Trunk with SVN

2008-05-23 Thread Adrian Cumiskey
Hi bonekrusher, It sounds like you have already checked out (partially or otherwise) http://svn.apache.org/repos/asf/xmlgraphics/fop/trunk. Its probably best to start again by deleting your c:\fop_Home directory and make a fresh clean checkout as J.Pietschmann suggested :- svn co

Re: svn commit: r662448 - in /xmlgraphics/fop/branches/Temp_AFPGOCAResources: conf/ src/documentation/content/xdocs/trunk/ src/java/org/apache/fop/events/ src/java/org/apache/fop/image/loader/batik/ s

2008-06-02 Thread Adrian Cumiskey
Hi Jeremias, Ok, I will look into trying to use the AFPState/RendererContext interface instead. Adrian. Jeremias Maerki wrote: Hi Adrian, I'm not happy with the change of the Graphics2DImagePainter interface in XGCommons that you seem to have done locally. This interface is targeted at

[VOTE] AFP GOCA and Resource Group Leveling

2008-06-03 Thread Adrian Cumiskey
I would like to propose the merging of the AFP branch [1] back into trunk. This branch [1] contains a major rewrite of much of the old AFP MO:DCA package and new functionality for the rendering of SVG instream-foreign-object/external-graphic as AFP GOCA. This branch also contains data object

Re: Switching to Java 1.5

2008-06-05 Thread Adrian Cumiskey
I would imagine that the availability of binary 1.4 compatibility should be enough for most users. I don't see how there should be any problems so long as we continue to try and use the Java 1.4 libraries and the generics features of 1.5. I have tested out Retroweaver briefly in the past and

Re: Switching to Java 1.5

2008-06-06 Thread Adrian Cumiskey
Hi all, I have attached a patch file which provides support for Retroweaver at compilation time in FOP's ant build script. You can grab the latest Retroweaver from http://downloads.sourceforge.net/retroweaver/retroweaver-2.0.5.zip. There is already quite some generics comments which could be

Re: Switching to Java 1.5

2008-06-06 Thread Adrian Cumiskey
Just stumbled upon this... http://en.wikipedia.org/wiki/Comparison_of_backporting_tools Retrotranslator looks to have a more fully implemented feature set. Maybe we should try both. Adrian. Max Berger wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear Fop-devs, Jess Holle schrieb:

Re: Switching to Java 1.5

2008-06-09 Thread Adrian Cumiskey
Just to clarify in case anyone isn't quite following what Vincent is proposing. All 1.4 deployment environments could remain as is without any change. For those that need 1.4 in their deployment environment, there would be provision in the FOP build script for the production of 1.4 compliant

Re: svn commit: r665699 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fo/flow/table/ layoutmgr/ layoutmgr/inline/ layoutmgr/list/ layoutmgr/table/

2008-06-09 Thread Adrian Cumiskey
After looking more closely at this I think I may have been a little hasty in my praise and Jeremias has a point, but Max's sentiment is a right one. On the subject of readability, there is much cleaning up and refactoring that needs to be done to make the code base more simple and easy to

Re: svn commit: r670217 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fo/ fo/flow/table/ layoutmgr/table/ render/rtf/

2008-06-21 Thread Adrian Cumiskey
Hi Andreas, Not sure, maybe because I renamed TableBody to TablePart and then created a new TableBody class in Eclipse. So I'm guessing behind the scenes it did an svn remove on TableBody and then an svn add when I created the new class :-S. Sorry for any inconvenience. Adrian. 2008/6/21

Re: svn commit: r674269 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: area/AreaTreeParser.java area/inline/Character.java render/AbstractRenderer.java

2008-07-06 Thread Adrian Cumiskey
Hi Andreas, This commit looks to undo some changes I made to AbstractRenderer in r674056. Was wondering if this was intentional? r674056 took the null port variable test out of renderRegionViewPort() so there would be one less method call in the case when there is no RegionViewport and

Re: svn commit: r674484 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/xml/AbstractXMLRenderer.java

2008-07-07 Thread Adrian Cumiskey
Hi Jeremias, You'll see in a moments time when the recent svn commit on XMLRenderer arrives... :). Just thought I would put these small changes planned in the Temp_AreaTreeNewDesign into trunk as they do no harm and may actually be useful for someone else who may wish to write their own

Re: svn commit: r674484 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/xml/AbstractXMLRenderer.java

2008-07-08 Thread Adrian Cumiskey
As it is, I have a class in the Temp_AreaTreeRedesign branch that extends AbstractXMLRenderer. I thought it useful to provide the class in trunk for anyone else who may wish to create their own XML based renderer for whatever purposes. However, IMO you can never have enough abstract classes,

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-09 Thread Adrian Cumiskey
Sounds like a fine approach, +1 from me. Adrian. Jeremias Maerki wrote: On 09.07.2008 10:45:35 Max Berger wrote: Jeremias, Jeremias Maerki schrieb: Am I the only one concerned about backwards-compatibility here? No. I am also concerned about backwards-compatibility, but in a different way:

Re: Building FOP Trunk with Any - BUILD FAILED

2008-07-09 Thread Adrian Cumiskey
Looks like your generated file URL has been somehow escaped incorrectly, not sure that would work file:\C:\fop_trunk\trunk\build\gensrc\org\apache\fop\events\event-model.xml Which version of Java are you using and on which Windows platform? Adrian. bonekrusher wrote: I downloaded the

Re: svn commit: r677648 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FOPropertyMapping.java

2008-07-17 Thread Adrian Cumiskey
Hi Andreas, Just realised that this change broke some units tests... will look at fixing this. Adrian. Andreas Delmelle wrote: On Jul 17, 2008, at 19:39, [EMAIL PROTECTED] wrote: Hi Adrian, Author: acumiskey Date: Thu Jul 17 10:39:14 2008 New Revision: 677648 URL:

Re: svn commit: r677648 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FOPropertyMapping.java

2008-07-18 Thread Adrian Cumiskey
Hi Max, The problem with AFP is that there is no concept of a default set of base fonts. You have to purchase your fonts as a pack from IBM and I'm not too sure about the availability of Symbol and Zapfdingbats - they seem have their own way of doing things :). FOP does however provide a

Re: svn commit: r678394 - in /xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp: ./ modca/

2008-07-21 Thread Adrian Cumiskey
Jeremias, Yes you are right, I'll look at amending this. Adrian. Jeremias Maerki wrote: Adrian, what's the point in registering arbitrary image formats which are not even directly supported by AFP and are converted to bitmaps or graphics by the AFPRenderer? AFAICT, the modca package simply

Re: svn commit: r679326 [1/33] - in /xmlgraphics/fop/trunk: examples/embedding/java/embedding/ examples/embedding/java/embedding/events/ examples/embedding/java/embedding/intermediate/ examples/embedd

2008-07-25 Thread Adrian Cumiskey
That is a useful option, thanks for the useful tip Jeremias, I have just this moment changed my Eclipse preferences even though I am away on holiday at the moment :) Adrian. 2008/7/25 Vincent Hennebert [EMAIL PROTECTED] Jeremias Maerki wrote: Depends on every single committer. ;-) For

Re: AFP: Data object located at '...' of type 'image/tiff' cannot be reference with an include...

2008-07-30 Thread Adrian Cumiskey
Hi Jeremias, Jeremias Maerki wrote: Adrian, I'm seeing the warning in the subject when rendering some of the external-graphic-* test cases to AFP. I've got a few questions: - Why is this warning? This is because TIFF images are currently set to be not includable in the Registry. - Isn't

Re: Website: Areas of Expertise

2008-08-03 Thread Adrian Cumiskey
Yes I'm fine with you going ahead and removing it Vincent, +1. Adrian. 2008/8/3 The Web Maestro [EMAIL PROTECTED] +1 to removing it since it's not maintained... On Thu, Jul 31, 2008 at 3:58 AM, Vincent Hennebert [EMAIL PROTECTED] wrote: While checking the website for the 0.95 release I

Re: svn commit: r687323 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: afp/AFPRenderer.java pcl/PCLRenderer.java

2008-08-20 Thread Adrian Cumiskey
I don't think it is Max... looks like @since 1.4. /** * Returns a ttBoolean/tt instance representing the specified * ttboolean/tt value. If the specified ttboolean/tt value * is tttrue/tt, this method returns ttBoolean.TRUE/tt; * if it is ttfalse/tt, this method returns

Re: svn commit: r687323 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: afp/AFPRenderer.java pcl/PCLRenderer.java

2008-08-20 Thread Adrian Cumiskey
, and purely optional? Max Max Berger schrieb: Adrian, Adrian Cumiskey schrieb: I don't think it is Max... looks like @since 1.4. you're right - looks like the other valueOf methods (for integer, etc.) where introduced in 1.5, and this one was indeed introduced in 1.4. I've reverted

Re: (Re)moving without deprecating?

2008-08-26 Thread Adrian Cumiskey
Jeremias, My intentions and motivations were simple really, I was making use of the FOP UnitConv class in the branch work and noticed an identical class (in every way apart from package name) existing in xmlgraphics commons. So I simply spent 10 mins removing the duplication. I have now

Re: URIResolutionTestCase is disabled

2008-08-26 Thread Adrian Cumiskey
Hi Max, I don't know of any reason, I guess maybe it was broken at some point in time? It certainly makes sense that we have a working and enabled unit test for this. So please do so by all means, +1 from me. Adrian. Max Berger wrote: Dear Fop-devs, is there a specific reason why

Re: svn commit: r708134 [1/6] - in /xmlgraphics/fop/branches/Temp_AFPGOCAResources: ./ src/java/org/apache/fop/ src/java/org/apache/fop/afp/ src/java/org/apache/fop/afp/fonts/ src/java/org/apache/fop/

2008-10-28 Thread Adrian Cumiskey
As you know Jeremias, this AFP library and an AFPRenderer was originally donated to the Apache Foundation in 2006 [1]. It was donated as a prototype AFP library and renderer all mixed up together. From the work I have done in the Temp_AFPGOCAResources branch, the original AFP code is no longer

Re: svn commit: r708134 [1/6] - in /xmlgraphics/fop/branches/Temp_AFPGOCAResources: ./ src/java/org/apache/fop/ src/java/org/apache/fop/afp/ src/java/org/apache/fop/afp/fonts/ src/java/org/apache/fop/

2008-10-29 Thread Adrian Cumiskey
Jeremias Maerki wrote: On 28.10.2008 18:55:39 Adrian Cumiskey wrote: As you know Jeremias, this AFP library and an AFPRenderer was originally donated to the Apache Foundation in 2006 [1]. It was donated as a prototype AFP library and renderer all mixed up together. From the work I have done

Re: svn commit: r706226 - in /xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop: image/loader/batik/ render/afp/ render/afp/goca/

2008-10-29 Thread Adrian Cumiskey
Thanks for spotting this, I will investigate. Adrian. Jeremias Maerki wrote: Adrian, this change (r706226) introduced a problem with image handling in AFP. AFPImageGraphics2DFactory assumes that all Graphics2DImagePainters passed in are GenericGraphics2DImagePainters (the subclass you made

Re: svn commit: r709373 - in /xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop: ./ afp/ pdf/ render/ render/afp/ render/pdf/

2008-10-31 Thread Adrian Cumiskey
Hi Jeremias, I understand what you are saying, its not ideal that it resides in org.apache.fop. I'm trying to keep it away separate from the render package as it could be plugged into any engine (painter etc) which uses the libraries. I guess we can move it to org.apache.fop.util for now,

Re: Problem upgrading from 0.94 to 0.95

2008-11-05 Thread Adrian Cumiskey
Hi Paul, The NullPointerException is coming from the ImageInputStream being null. This looks like one for Max as I suspect it may be a problem with the JEuclid PreloaderMathML class when it constructs its ImageInputStreamAdapter. Could you host your source document somewhere and I'll take a

Re: Problem upgrading from 0.94 to 0.95

2008-11-05 Thread Adrian Cumiskey
Also it may be helpful if you are able to tell us which version of JEuclid you are using. Adrian. Adrian Cumiskey wrote: Hi Paul, The NullPointerException is coming from the ImageInputStream being null. This looks like one for Max as I suspect it may be a problem with the JEuclid

Re: FIleChannel accessible BufferedOutputStream

2008-11-10 Thread Adrian Cumiskey
a wrapper class similar to the idea of org.xml.sax.InputSource would do the trick? Max Adrian Cumiskey schrieb: When FOP is started in Main.startFOP() a java.io.BufferedOutputStream is instantiated and wrapped around an instantiated java.io.FileOutputStream. By wrapping the initial

  1   2   >