Re: What to do with the XML JARs?

2008-01-30 Thread Andreas Delmelle
On Jan 30, 2008, at 14:46, Jeremias Maerki wrote: Vincent's feedback reminded me about something else we probably should look at. Vincent proposed to add a dependency on the Xerces/Xalan XML serializer. As noted, I'd prefer to stick to plain JAXP. But yes, with Java 1.4 JAXP is built in so the

Re: Feedback on Processing Feedback

2008-01-30 Thread Andreas Delmelle
On Jan 30, 2008, at 13:01, Jeremias Maerki wrote: Hi Jeremias, Vincent, snip / However, there's one thing in this context that is still on my list and that I want to change eventually: We have multiple places where we create a new TransformerFactory. It's always the platform default that is

Re: Feedback on Processing Feedback

2008-01-31 Thread Andreas Delmelle
On Jan 31, 2008, at 08:50, Jeremias Maerki wrote: I'm not sure, yet, if it's so easily possible to get the TransformerFactory from the FopFactory as it's not available everywhere. This could take some additional wiring. At first I was simply thinking about a classloader-wide setting (i.e.

Re: What to do with the XML JARs?

2008-01-31 Thread Andreas Delmelle
On Jan 31, 2008, at 16:25, Vincent Hennebert wrote: snip / Which means for today that we remove the no longer necessary serializer.jar and xercesImpl.jar and we keep the other ones. Solution 1, amended. I hope I’m clear. WDYT? This also sounds good enough for me. As long as we can't safely

Re: What to do with the XML JARs?

2008-02-01 Thread Andreas Delmelle
On Jan 31, 2008, at 22:20, Jeremias Maerki wrote: Can you two please explain to me what you mean by that? Heh, now that you ask that, it does not seem so intuitive as I thought... at least, what I had in mind last night, has changed somewhat. I guess what I mean --also in relation to

Re: What to do with the XML JARs?

2008-02-01 Thread Andreas Delmelle
On Jan 31, 2008, at 12:49, Vincent Hennebert wrote: (Noticed this fragment in an earlier post, and just wanted to point out that...) snip / Note that by removing the 4 aforementioned jars and using a 1.5 jdk I have unresolved import errors in the org.apache.fop.layoutengine.EvalCheck class.

Failing transcoder test?

2008-02-01 Thread Andreas Delmelle
Hi people Earlier tonight, I updated my local sandbox, and just noticed that the junit-transcoder test is failing, due to: java.lang.NoClassDefFoundError: org/apache/fop/util/ColorProfileUtil The class is definitely there, so I suspect it is referenced somehow (maybe indirectly) by the

Re: svn commit: r617812 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: flow/ properties/

2008-02-02 Thread Andreas Delmelle
On Feb 2, 2008, at 16:13, [EMAIL PROTECTED] wrote: Author: adelmelle Date: Sat Feb 2 07:13:40 2008 New Revision: 617812 URL: http://svn.apache.org/viewvc?rev=617812view=rev Log: Further cleanup/refinement of FixedLength: * improve consistency in use of the PropertyCache remove public

Re: Test case maintenance

2008-02-04 Thread Andreas Delmelle
On Feb 4, 2008, at 02:26, Manuel Mall wrote: Hi Manuel Just wondering if it is only me but observing the patches over the last months it appears that the appetite for maintaining and enhancing the set of test cases seems to have reduced. There was a time in the past when most bugs fixed

Re: Error in test case color_1.xml

2008-02-08 Thread Andreas Delmelle
On Feb 8, 2008, at 20:16, Simon Pepping wrote: Hi Simon I get an error in test case color_1.xml. Yep, I'm still working on that (see my message from Tuesday), but got sidetracked a bit. Will be fixed by the end of the weekend. Sorry for the inconvenience. Cheers Andreas

Re: Q: Interpretation of decimal values in background-position-*

2008-02-08 Thread Andreas Delmelle
On Feb 8, 2008, at 18:32, Andreas Delmelle wrote: Now while going over it again, and trying to do the same for background-position, I noticed that there is currently a testcase -- IIRC, one I added myself when implementing the background-position shorthand-- where a specified value of 0.5

Re: DO NOT REPLY [Bug 41631] - Percentages in proportional-column-width() not supported

2008-02-10 Thread Andreas Delmelle
On Feb 10, 2008, at 14:44, [EMAIL PROTECTED] wrote: --- Additional Comments From [EMAIL PROTECTED] 2008-02-10 05:44 --- Fixed in FOP Trunk. see: http://svn.apache.org/viewvc?rev=620283view=rev Oops, wrong revision number: should be 620285.

Re: DO NOT REPLY [Bug 43705] - use of rgb-icc inside of simple-page-master results in null pointer exeption

2008-02-10 Thread Andreas Delmelle
On Feb 4, 2008, at 22:15, Andreas Delmelle wrote: Small *grin* update: Looking into a fix now. The issue arises in ColorUtil.parseColorString(). After my changes, percentages get passed into fop-rgb-icc() as percentages instead of decimals, which leads to a rather peculiar error message

Re: svn commit: r620277 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/NumberProperty.java

2008-02-11 Thread Andreas Delmelle
On Feb 11, 2008, at 19:26, Andreas Delmelle wrote: Err... Math.floor(-2.0) == Math.ceil(-2.0) == Math.rint(-2.0) == -2.0 Did you actually check that? In that case, your JVM would not be compliant, I think... The API docs say: Math.floor(-2.3) = -3 Math.ceil(-2.3) = -2 Math.rint(-2.3

Re: svn commit: r620277 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/NumberProperty.java

2008-02-11 Thread Andreas Delmelle
On Feb 11, 2008, at 19:26, Andreas Delmelle wrote: snip / So, Math.floor(-2.3) = -3 Math.ceil(-2.3) = -2 Math.rint(-2.3) = -2 rint() has the additional side-effect of returning just the closest even integer, so: Math.rint(-3.3) == Math.floor(-3.3) != Math.ceil(-3.3) Correction

Re: svn commit: r620277 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/NumberProperty.java

2008-02-11 Thread Andreas Delmelle
On Feb 11, 2008, at 18:05, Vincent Hennebert wrote: Hi Andreas Delmelle wrote: On Feb 11, 2008, at 11:23, Vincent Hennebert wrote: +if ((num = 0 num == Math.floor(num)) +|| num == Math.ceil(num)) { Isn’t that the same as if (num == Math.floor(num)) Yes

Re: Missing PropertyException constructor

2008-02-11 Thread Andreas Delmelle
On Feb 11, 2008, at 19:05, Vincent Hennebert wrote: Am I the only one to get the following error message when upgrading my local copy to the latest trunk? In ColorUtil.java: “The constructor PropertyException(Exception) is undefined” Sorry, my mistake. Forgot to commit that file. I'll rectify

Re: Q: Interpretation of decimal values in background-position-*

2008-02-11 Thread Andreas Delmelle
On Feb 11, 2008, at 11:44, Vincent Hennebert wrote: Andreas Delmelle wrote: snip/ Now while going over it again, and trying to do the same for background-position, I noticed that there is currently a testcase --IIRC, one I added myself when implementing the background-position shorthand

Re: svn commit: r620277 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/NumberProperty.java

2008-02-11 Thread Andreas Delmelle
On Feb 11, 2008, at 11:23, Vincent Hennebert wrote: Hi Vincent Hi Andreas, Author: adelmelle Date: Sun Feb 10 05:01:07 2008 New Revision: 620277 snip/ +private NumberProperty(double num) { +//Store the number as an int or a long, +//if possible +if ((num = 0

Re: Repository properties?

2008-02-12 Thread Andreas Delmelle
On Feb 12, 2008, at 17:55, Max Berger wrote: Dear Fop devs, I'd like to make some property changes in svn: On all java files: - set svn:eol-style native This should ideally already be the case. At least, I know I have configured SVN locally to force this (as do a lot of the committers,

Re: Remove deprecated methods in outer API for 0.95?

2008-02-14 Thread andreas . delmelle
- Oorspronkelijk bericht - Van: Jeremias Maerki [mailto:[EMAIL PROTECTED] For some time now we have a number of methods in our outer API that are deprecated. I think we should remove them now. Anyone against my doing that as part of the preparations for the release? Absolutely no

FYI: NPE in a personal table-test

2008-02-15 Thread Andreas Delmelle
Hi all To whom it may concern: the following small test ends in a NullPointerException on my end (latest Trunk, with some local differences) ?xml version=1.0 encoding=UTF-8? fo:root xmlns:fo=http://www.w3.org/1999/XSL/Format; fo:layout-master-set fo:simple-page-master

Q: What should happen when an image is not found?

2008-02-16 Thread Andreas Delmelle
Hi all Reason for this question is I'm trying out a test-suite that was shared by Kumar Puppala (see a recent thread on fop-users). The image formats are the same (PNG), and they are never present. Mostly, when the images are not available, I simply see an error in the log, but the

Re: Update: XML JARs

2008-02-20 Thread andreas . delmelle
- Oorspronkelijk bericht - Van: Vincent Hennebert [mailto:[EMAIL PROTECTED] snip / I guess the simplest is to keep with the status quo, or with your solution #2 if you feel like implementing it. However, I would put only serializer and xercesImpl in the endorsed/ directory, since like

Re: background-position-horizontal/vertical vs background-repeat

2008-02-25 Thread Andreas Delmelle
On Feb 25, 2008, at 18:15, Vincent Hennebert wrote: Hi Vincent, In o.a.f.layoutmgr.TraitSetter.addBackground, why is background-position-horizontal/vertical taken into account only if the corresponding repeat is set to no? I have no idea, honestly... From what I read in the spec both

Re: More ideas for configuration/extension?

2008-02-27 Thread Andreas Delmelle
On Feb 27, 2008, at 16:21, Adrian Cumiskey wrote: For either my suggestion or Andreas' further proposal we would certainly need to do a little bit of refactoring, abstracting out all those member config variables in FopFactory into a base configuration object. This base configuration

Re: Next release - when?

2008-03-05 Thread Andreas Delmelle
On Mar 1, 2008, at 09:01, The Web Maestro wrote: Hi Just noticed this: On Fri, Feb 29, 2008 at 2:18 AM, Vincent Hennebert Also, have you looked at disabling the menu auto-rolling feature? If not, I will ;-) Fixing that should be as easy as adding this to the bottom of the extra-css block

Re: inline and fo:list-block

2008-03-06 Thread Andreas Delmelle
On Mar 6, 2008, at 10:26, Jeremias Maerki wrote: Hi Jeremias First things first: Andreas, have you, by chance, started on this one already? I want to avoid that two people are working on the same problem. Not yet. In my experiments with fo:inline-container, I did stumble upon a similar

Re: What to convert to events and what not...

2008-03-07 Thread Andreas Delmelle
On Mar 7, 2008, at 15:20, Jeremias Maerki wrote: Hi Jeremias I'm almost finished event-izing the FO tree. I've stumbled over the following: In RetrieveMarker.java: public void bindMarker(Marker marker) { if (marker.getChildNodes() != null) { try {

Q: failing tests in trunk...?

2008-03-23 Thread Andreas Delmelle
Hi people After updating my local copy, I've just stumbled upon two failing tests with current FOP Trunk: marker_percentage-resolution.xml table_in_marker_bug39560.xml Both tests contain tables in markers, and both rely on the implicit collapsing border model. If I change the tables in

Re: Q: failing tests in trunk...?

2008-03-23 Thread Andreas Delmelle
On Mar 23, 2008, at 15:45, Andreas Delmelle wrote: Now, the obvious question: Do I have to look for the cause in changes I made locally, or does anyone else get these failures too? (In the latter case, I do hope these have in the meantime been eliminated from the 0.95 branch...) Sorry

FOP 0.95 vs. 0.20.5

2008-04-04 Thread Andreas Delmelle
Hi people, As a message of general interest: I had an off-list conversation with Daniel Marchese, a fop-user who profiled a run of a document containing one large page-sequence of +400 pages with a lot of tables. He showed heap snapshots of FOP 0.20.5 on several JVMs, and it always

Re: [VOTE] Merge Temp_ProcessingFeedback branch into Trunk

2008-04-06 Thread Andreas Delmelle
On Apr 5, 2008, at 16:33, Jeremias Maerki wrote: As announced three days ago, I'd like to call for a vote to merge the processing feedback branch [1] into Trunk. This will add the new per-processing-run event subsystem to FOP that has been described on:

FYI: NullPointerException when building FOP trunk on Mac?

2008-04-18 Thread Andreas Delmelle
Hi I updated my sandbox to include the processing-feedback changes, and after running 'ant clean', I got the following when running target resourcegen: resourcegen: [mkdir] Created dir: /Developer/javatools/xml-fop/build/codegen-classes [javac] Compiling 3 source files to

Re: svn commit: r648381 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/fo/flow/table/ src/java/org/apache/fop/layoutmgr/ src/java/org/apache/fop/layoutmgr/inline/ src/java/org/apache/fop/layo

2008-04-19 Thread Andreas Delmelle
On Apr 18, 2008, at 21:52, Simon Pepping wrote: Easy please. Vincent has a preference. Jeremias is OK with it, but he is not hot about it, so he is not going to do it. Vincent did not add the new utilities, so he is not going to do it. That leaves Andreas to do it, or me, or ..., or it remains

Re: svn commit: r648381 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/fo/flow/table/ src/java/org/apache/fop/layoutmgr/ src/java/org/apache/fop/layoutmgr/inline/ src/java/org/apache/fop/layo

2008-04-21 Thread Andreas Delmelle
On Apr 21, 2008, at 12:22, Vincent Hennebert wrote: My reaction was not so much triggered by this (indeed) minor issue, as by the fact that once again I was being answered “feel free to improve” when asking for cleanup/documentation, and I got tired of it. Each time, they were small issues

Re: svn commit: r651544 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/expr/RelativeNumericProperty.java

2008-04-25 Thread Andreas Delmelle
On Apr 25, 2008, at 11:04, [EMAIL PROTECTED] wrote: Author: acumiskey Date: Fri Apr 25 02:04:06 2008 New Revision: 651544 URL: http://svn.apache.org/viewvc?rev=651544view=rev Log: Removed the tab characters that were causing a big moan from eclipse Heh, was just about to do the same, but you

Re: [Bug 44885] New: fo:inline-container implementation

2008-04-28 Thread Andreas Delmelle
On Apr 28, 2008, at 21:36, Simon Pepping wrote: On Sun, Apr 27, 2008 at 05:03:07PM -0700, [EMAIL PROTECTED] wrote: This Bugzilla entry will be used for the moment to keep track of the progress of an implementation for fo:inline-container. The related changes are restricted to a handful of

Re: about nested tables

2008-04-30 Thread Andreas Delmelle
On Apr 30, 2008, at 07:40, HLeonardi wrote: Hi Which version are you using? - Fop 0.95b crashes. Here is the reason : org.apache.fop.fo.ValidationException: Error(64/33374): column- number or number of cells in the row overflows the number of fo:table-column specified for the table.

Re: svn commit: r652467 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/BlockContainer.java

2008-05-01 Thread Andreas Delmelle
On May 1, 2008, at 12:01, [EMAIL PROTECTED] wrote: Author: adelmelle Date: Thu May 1 03:01:51 2008 New Revision: 652467 URL: http://svn.apache.org/viewvc?rev=652467view=rev Log: Minor cleanup: remove height/width members and unused getHeight()/ getWidth() accessors Just noticed that these

Re: svn commit: r652673 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/events/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/fo/flow/ src/java/org/apache/fop/layoutmgr/ test/fotree/testcas

2008-05-02 Thread Andreas Delmelle
On May 1, 2008, at 23:34, [EMAIL PROTECTED] wrote: Author: adelmelle Date: Thu May 1 14:34:19 2008 New Revision: 652673 URL: http://svn.apache.org/viewvc?rev=652673view=rev Log: First steps towards fo:retrieve-table-marker FWIW: I decided to finally look into this, as I've been noticing

Re: svn commit: r652673 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/events/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/fo/flow/ src/java/org/apache/fop/layoutmgr/ test/fotree/testcas

2008-05-02 Thread Andreas Delmelle
On May 2, 2008, at 18:47, Adrian Cumiskey wrote: I'm guessing by flaws and dirt you are referring to the broken junit test in FOTreeTestSuite due to fo:retrieve-table-marker being a child of fo:block in test/fotree/testcases/table_retrieve-table- marker.fo. Indeed. The reason is I forgot

Re: svn commit: r649657 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FOPropertyMapping.java flow/table/TableFObj.java properties/NumberProperty.java

2008-05-03 Thread Andreas Delmelle
On Apr 18, 2008, at 21:08, [EMAIL PROTECTED] wrote: Author: spepping Date: Fri Apr 18 12:07:57 2008 New Revision: 649657 URL: http://svn.apache.org/viewvc?rev=649657view=rev Log: An implementation of a positive integer property maker. It implements convertProperty, which is the correct method

Re: svn commit: r653106 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBaseLayoutManager.java

2008-05-03 Thread Andreas Delmelle
On May 3, 2008, at 21:07, [EMAIL PROTECTED] wrote: Author: acumiskey Date: Sat May 3 12:07:18 2008 New Revision: 653106 URL: http://svn.apache.org/viewvc?rev=653106view=rev Log: Fixed the build. Assignment on final variable fobj. Quid? Where is the variable assigned, apart from in the

Re: svn commit: r653106 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/AbstractBaseLayoutManager.java

2008-05-03 Thread Andreas Delmelle
On May 3, 2008, at 23:28, Adrian Cumiskey wrote: The member variable fobj was assigned via the super(node) constructor call. Since a correct assigment is made in a super constructor call to AbstractBaseLayoutManager, a better fix (if you want to keep the final status of the variable)

Re: think I found a bug

2008-05-05 Thread Andreas Delmelle
On May 5, 2008, at 10:55, Andreas Schröder wrote: Hi I already posted in the user group, but they only wonder about my error and can't help. So I think that it is a bug. I use Apache FOP 0.95beta but the same error also occured in 0.94 stable version: When trying to make a new instance of

Re: svn commit: r653202 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java

2008-05-05 Thread Andreas Delmelle
On May 5, 2008, at 21:15, J.Pietschmann wrote: [EMAIL PROTECTED] wrote: kern = font.getKernValue (previous, c) * font.getFontSize() / 1000; -} +} if (kern != 0) { Uh, oh.

Re: Question about FOP 0.94 and 0.20.5

2008-05-06 Thread Andreas Delmelle
On May 6, 2008, at 18:00, Juanjo Alejandro wrote: I try to run in a seem application the two versions of fop 0.94 and 0.20.5. I rebuild version FOP 0.94 changing the names of folders (org.apache.fop by org.jcom.fop) and jars to let de ClassLoader upload both librarys. As a result I get an

Re: think I found a bug

2008-05-07 Thread Andreas Delmelle
On May 5, 2008, at 16:55, Andreas Delmelle wrote: On May 5, 2008, at 10:55, Andreas Schröder wrote: I already posted in the user group, but they only wonder about my error and can't help. So I think that it is a bug. I use Apache FOP 0.95beta but the same error also occured in 0.94 stable

Re: svn commit: r649657 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FOPropertyMapping.java flow/table/TableFObj.java properties/NumberProperty.java

2008-05-07 Thread Andreas Delmelle
On May 7, 2008, at 22:00, Simon Pepping wrote: snip / The new PositiveIntegerMaker always returns a property with value of 1 if the specified value is negative or zero. Now, for column-number, it used to be so that those values were replaced by the next free column- number. After the

Q: Font-cache refresh warning?

2008-05-07 Thread Andreas Delmelle
Hi, One for Adrian, I presume: after updating my local sandbox, I got warnings about the FontCache being refreshed. At first, I thought this was due to the updates, but they re-occur every run. [junit] WARNING: I/O exception while reading font cache (org.apache.fop.fonts.FontCache;

Re: svn commit: r649657 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FOPropertyMapping.java flow/table/TableFObj.java properties/NumberProperty.java

2008-05-07 Thread Andreas Delmelle
On May 7, 2008, at 22:34, Andreas Delmelle wrote: On May 7, 2008, at 22:00, Simon Pepping wrote: [junit] - Standard Output --- [junit] Test: column-number_non-integer.fo [junit] [FATAL] fo:table overlaps in column 2. [junit] [ERROR] Invalid property

Re: svn commit: r649657 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FOPropertyMapping.java flow/table/TableFObj.java properties/NumberProperty.java

2008-05-07 Thread Andreas Delmelle
On May 8, 2008, at 00:03, Andreas Delmelle wrote: [junit] - Standard Output --- [junit] Test: column-number_non-integer.fo [junit] [FATAL] fo:table overlaps in column 2. [junit] [ERROR] Invalid property value encountered in column-number=-1

Re: Q: Font-cache refresh warning?

2008-05-07 Thread Andreas Delmelle
On May 8, 2008, at 02:35, Adrian Cumiskey wrote: If you update your local sandbox it should now fix itself the next time you compile and run. Yep, already done. Thanks for the quick intervention! Cheers Andreas

Re: svn commit: r653826 [1/3] - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/trunk/ src/java/org/apache/fop/apps/ src/java/org/apache/fop/fonts/ src/java/org/apache/fop/fonts/autodete

2008-05-09 Thread Andreas Delmelle
On May 9, 2008, at 16:25, Vincent Hennebert wrote: Nice job! Two nits: I second this, and have an additional consideration: +/** + * Returns the font manager + * @return the font manager + */ +public FontManager getFontManager() { +if (fontManager == null) { +

Re: svn commit: r653826 [1/3] - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/trunk/ src/java/org/apache/fop/apps/ src/java/org/apache/fop/fonts/ src/java/org/apache/fop/fonts/autodete

2008-05-09 Thread Andreas Delmelle
On May 9, 2008, at 16:40, Andreas Delmelle wrote: snip / That is, unless there is a specific reason to wait until getFontManager() is called before initializing (?) (Haven't checked whether the fontManager needs a fully initialized FopFactory to work properly...) I did a quick check

Re: svn commit: r653826 [1/3] - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/trunk/ src/java/org/apache/fop/apps/ src/java/org/apache/fop/fonts/ src/java/org/apache/fop/fonts/autodete

2008-05-09 Thread Andreas Delmelle
On May 9, 2008, at 17:22, Adrian Cumiskey wrote: Andreas Delmelle wrote: Maybe a matter of style, but if see this, I usually move the assignment to the member initialization, i.e. class FopFactory { ... private FontManager fontManager = new FontManager(this); ... That is, unless

Re: [Xmlgraphics-fop Wiki] Update of PropertyHandling/PropertyCache by AndreasDelmelle

2008-05-11 Thread Andreas Delmelle
On May 11, 2008, at 15:06, Vincent Hennebert wrote: snip / To my knowledge an object is always created in the heap, never on the stack. The PropertyCache is efficient not because it avoids to move instances to the heap, but because references to newly created instances are immediately

Re: svn commit: r655309 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fo/FObj.java layoutmgr/AbstractLayoutManager.java

2008-05-11 Thread Andreas Delmelle
On May 11, 2008, at 14:22, [EMAIL PROTECTED] wrote: Author: adelmelle Date: Sun May 11 05:22:22 2008 New Revision: 655309 URL: http://svn.apache.org/viewvc?rev=655309view=rev Log: Make the LM clean up on end-of-layout, if possible. Added clearChildNodes() method to FObj to release the reference

Re: svn commit: r655281 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/fo/FOPropertyMapping.java src/java/org/apache/fop/layoutmgr/inline/CharacterLayoutManager.java status.xml

2008-05-11 Thread Andreas Delmelle
On May 11, 2008, at 11:01, [EMAIL PROTECTED] wrote: Hi Max Author: maxberger Date: Sun May 11 02:01:31 2008 New Revision: 655281 URL: http://svn.apache.org/viewvc?rev=655281view=rev Log: Support character-by-character font-selection strategy on fo:character element Good thinking! FWIW,

Re: svn commit: r655500 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties: CommonBorderPaddingBackground.java CondLengthProperty.java PropertyCache.java

2008-05-12 Thread Andreas Delmelle
On May 12, 2008, at 15:42, [EMAIL PROTECTED] wrote: URL: http://svn.apache.org/viewvc?rev=655500view=rev Log: Extended caching to CondLengthProperty CommonBorderPaddingBackground.BorderInfo and CommonBorderPaddingBackground. This /did/ have quite some effect... For a FO document with

Re: [g...@vmgump]: Project xml-fop (in module xml-fop) failed

2008-05-12 Thread Andreas Delmelle
My bad :( Fix committed in the meantime. Cheers Andreas On May 12, 2008, at 16:23, Jeremias Maerki wrote: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at

Re: Font-Selection strategies (Re: svn commit: r655281 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/fo/FOPropertyMapping.java src/java/org/apache/fop/layoutmgr/inline/CharacterLayoutManager.ja

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 07:32, Max Berger wrote: Hi Max snip / +private Font selectFontForCharacter(Character fobj) { Now that we have a FontManager, what if we add something to it like: public Font selectFontForCharacter(FontTriplet[] triplets, char, int) +1, what would be the int be

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 10:59, Andreas Delmelle wrote: On May 13, 2008, at 10:55, Adrian Cumiskey wrote: Which tests are failing on your end exactly? I've updated my sandbox yesterday evening, and all tests still passed... but that could also mean that some of my local changes haven't found

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 10:55, Adrian Cumiskey wrote: Hi Adrian When merging across, I discovered that my fresh checked out sandbox of trunk is showing 8 unit tests broken at the moment (mostly in the layout engine). We shouldn't really commit any code that breaks unit tests, any chance we

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 11:59, Andreas Delmelle wrote: background-position-shorthand-test.fo Error file:/home/acumiskey/ workspace/tru/test/fotree/testcases/background-position-shorthand- test.fo Property 'background-position-vertical' expected to evaluate to '0mpt' but got '0.0%' (test:assert

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 11:39, Adrian Cumiskey wrote: Hi Andreas, Without more thorough investigation, at a guess I would say it looks like the new id generation stuff may be contributing to some of the test failures (see NullPointerExceptions). Here are the test failures... Yep, reverting

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 12:20, Andreas Delmelle wrote: On May 13, 2008, at 11:59, Andreas Delmelle wrote: background-position-shorthand-test.fo Error file:/home/acumiskey/ workspace/tru/test/fotree/testcases/background-position-shorthand- test.fo Property 'background-position-vertical' expected

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 13:18, Adrian Cumiskey wrote: The following test still fails as part of the LayoutEngineTestSuite :- wrapper_block.xml Error Expected w=14400 at position 0 but got: 0 (element-list category=breaker) java.lang.RuntimeException: Expected w=14400 at position 0 but got: 0

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 13:44, Andreas Delmelle wrote: On May 13, 2008, at 13:18, Adrian Cumiskey wrote: The following test still fails as part of the LayoutEngineTestSuite :- wrapper_block.xml Error Expected w=14400 at position 0 but got: 0 (element-list category=breaker

Re: Changing IPD, aka Interleaved Page- and Line-breaking

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 12:06, Vincent Hennebert wrote: Just to let you know that I’m starting my next big task: make it possible to specify pages of different widths. Cool! You have our full support. ;-) I spent some much useful time with Simon during the ApacheCon where he gave me detailed

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 16:01, Andreas Delmelle wrote: Before the changes I made, this sequence would also result in an Inline area, which would cause a ClassCastException during the addAreas() phase. Instead, the check in FlowLM was put there to filter the InlineKnuthSequence out, and signal

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 15:24, Vincent Hennebert wrote: FWIW: The test should pass now. I'm not 100% certain whether the change is correct, but the element-list we get has the box we're looking for at position 3 (index 2), so I simply skipped the first two elements in the list... I can’t

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
FWIW: On May 13, 2008, at 15:24, Vincent Hennebert wrote: SEVERE: Could not create block pointers. FOText w/o Block ancestor. The first word scares me a bit ;-) No need to fear any longer. ;-) Deactivated this error message for ignorable white-space in the meantime. The only time

Re: DO NOT REPLY [Bug 44412] Missing border-after when break-after set on a block

2008-05-15 Thread Andreas Delmelle
On May 15, 2008, at 12:53, [EMAIL PROTECTED] wrote: --- Comment #25 from Vincent Hennebert [EMAIL PROTECTED] tech.com 2008-05-15 03:53:03 PST --- (In reply to comment #18) page, along with the inner block, in attachment #21531 [details]. I think our best bet is to ask for clarification on

Re: Adding Table Continuation Label support

2008-05-19 Thread Andreas Delmelle
On May 19, 2008, at 17:08, Vincent Hennebert wrote: Hi bonekrusher wrote: Hi, Since FOP 0.94 and 0.95 Beta do not have support for Table Continuation Labels, I would like to see if I can possible work on this for the project. To implement this feature, 4 steps basically need to be

Re: ZapfDingbats and Symbol not found whereas they are not needed

2008-05-29 Thread Andreas Delmelle
On May 29, 2008, at 12:03, Vincent Hennebert wrote: Max Berger wrote: Andreas, indeed. To support proper character auto-selection I've modified the default to include the symbol and zapf-dingbats fonts, as they contain many characters normally not found in the default fonts. I hope I'll

Re: svn commit: r660998 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/fo/ src/java/org/apache/fop/fonts/ src/java/org/apache/fop/layoutmgr/inline/ test/layoutengine/standard-testcases/

2008-05-29 Thread Andreas Delmelle
On May 29, 2008, at 13:47, Max Berger wrote: Hi Max Just some comments on this work: - it implements a word-by-word selection as the auto font-selection strategy. It will always pick the first font, which is able to display the most characters in a word. This behavior needs to be documented

Re: try without catch in BlockStackingLM.getNextKnuthElements

2008-05-31 Thread Andreas Delmelle
On May 29, 2008, at 18:23, Vincent Hennebert wrote: Could anybody explain me what is the purpose of the following piece of code: if (!breakBeforeServed) { try { if (addKnuthElementsForBreakBefore(returnList, context)) { return returnList; }

Re: try without catch in BlockStackingLM.getNextKnuthElements

2008-06-01 Thread Andreas Delmelle
On Jun 1, 2008, at 03:40, Peter B. West wrote: Andreas Delmelle wrote: On May 29, 2008, at 18:23, Vincent Hennebert wrote: Could anybody explain me what is the purpose of the following piece of code: if (!breakBeforeServed) { try { if (addKnuthElementsForBreakBefore

Re: Switching to Java 1.5

2008-06-05 Thread Andreas Delmelle
On Jun 5, 2008, at 17:46, Vincent Hennebert wrote: Hi Guys, I would like to raise this topic again: what about switching to Java 1.5 as a minimum requirement? No objection from me. +1 on moving forward with this in the trunk. Andreas

Re: StaticContentLM breaks its content?

2008-06-05 Thread Andreas Delmelle
On Jun 5, 2008, at 13:27, Vincent Hennebert wrote: Does anyone know why does StaticContentLM implement its own breaker (StaticContentBreaker) and breaks its content using the PageBreakingAlgorithm? AFAIK descendants of a static-content element are not supposed to be broken over several

Re: Switching to Java 1.5

2008-06-06 Thread Andreas Delmelle
On Jun 5, 2008, at 19:26, Andreas Delmelle wrote: On Jun 5, 2008, at 17:46, Vincent Hennebert wrote: Hi Guys, I would like to raise this topic again: what about switching to Java 1.5 as a minimum requirement? No objection from me. +1 on moving forward with this in the trunk. Just

Re: svn commit: r665699 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fo/flow/table/ layoutmgr/ layoutmgr/inline/ layoutmgr/list/ layoutmgr/table/

2008-06-09 Thread Andreas Delmelle
On Jun 9, 2008, at 16:40, Jeremias Maerki wrote: Frankly, I'm less than thrilled. I appreciate the good will behind this but I'd have appreciated some advance warning, too. My concern is that: -ListElement last = (ListElement)contentList.getLast(); is much easier to read and write

Re: svn commit: r665699 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fo/flow/table/ layoutmgr/ layoutmgr/inline/ layoutmgr/list/ layoutmgr/table/

2008-06-09 Thread Andreas Delmelle
On Jun 9, 2008, at 18:46, Adrian Cumiskey wrote: After looking more closely at this I think I may have been a little hasty in my praise and Jeremias has a point, but Max's sentiment is a right one. On the subject of readability, there is much cleaning up and refactoring that needs to be

Re: Code Quality Metrics

2008-06-10 Thread Andreas Delmelle
On Jun 10, 2008, at 12:26, Vincent Hennebert wrote: By all means, go for it. I second this. That can’t hurt, IMO, and this will probably be quite helpful (or scary, maybe ;-) ). Of course, just setting them up will not be enough. Their suggestions will also have to be followed. Given that

Re: svn commit: r665793 [1/2] - in /xmlgraphics/fop/trunk/src: co degen/unicode/data/LineBreakPairTable.txt codegen/unicode/java/org/apache /fop/text/linebreak/GenerateLineBreakUtils.java java/org/apa

2008-06-10 Thread Andreas Delmelle
On Jun 10, 2008, at 01:18, Manuel Mall wrote: Just as a background. The reason LineBreakPairTable.txt had this 'funny' format is that it was a straight unmodified copy of the table from the UAX#14 specification. Just open the UAX#14 spec in a browser, select and copy the table, paste it

Re: List vs. LinkedList

2008-06-10 Thread Andreas Delmelle
On Jun 10, 2008, at 09:54, Max Berger wrote: as far as I can tell, there where two issues with my cleanups yesterday: Readablility and Performance. I've just submitted a patch which adds a ListUtil class, to make the code more readable again. I've replaced (hopefully) all occurrences of

Non-applicable properties? (was: ClassCastException when using Table Cells in FOP 0.95B)

2008-06-13 Thread Andreas Delmelle
- Oorspronkelijk bericht - Van: Andreas Delmelle [mailto:[EMAIL PROTECTED] Verzonden: vrijdag, juni 13, 2008 01:18 PM - Oorspronkelijk bericht - Van: Vincent Hennebert [mailto:[EMAIL PROTECTED] Verzonden: vrijdag, juni 13, 2008 12:17 PM snip / FOP lacks of robustness here since

Re: Code Quality Metrics

2008-06-13 Thread Andreas Delmelle
- Oorspronkelijk bericht - Van: Max Berger [mailto:[EMAIL PROTECTED] Verzonden: vrijdag, juni 13, 2008 01:11 PM +1 I must say, I’ve never really grasped the benefit of doing this. I’d be happy to be enlightened, though. Sure: Declaring a parameter / variable as final makes it

Re: Non-applicable properties? (was: ClassCastException when using Table Cells in FOP 0.95B)

2008-06-13 Thread Andreas Delmelle
- Oorspronkelijk bericht - Van: Andreas Delmelle [mailto:[EMAIL PROTECTED] Verzonden: vrijdag, juni 13, 2008 03:56 PM snip / In this case, all it takes is one look at the property definition (*) to find out that the behavior is only defined for fo:table-cell and fo:table-column

Re: Print JPEG HeadlessException - Please Help

2008-06-13 Thread Andreas Delmelle
- Oorspronkelijk bericht - Van: Surj [mailto:[EMAIL PROTECTED] Verzonden: vrijdag, juni 13, 2008 05:07 PM Oh by the way i am using Java 1.4.2.8 if that makes a diff or not. Surj wrote: Ok i am using fop-0.20.5 and all I am trying to do is get a jpeg images and send it to a postscript

Re: Code Quality Metrics

2008-06-13 Thread Andreas Delmelle
- Oorspronkelijk bericht - Van: Vincent Hennebert [mailto:[EMAIL PROTECTED] Verzonden: vrijdag, juni 13, 2008 08:31 PM snip / FWIW, I do re-assign local variables sometimes (rarely). When the new value serves the same purpose, and creating a new variable with another name would actually

Re: Print JPEG HeadlessException - Please Help

2008-06-13 Thread Andreas Delmelle
- Oorspronkelijk bericht - Van: Surj [mailto:[EMAIL PROTECTED] Verzonden: vrijdag, juni 13, 2008 09:23 PM Yes the 'java.awt.headless=true' specified as a parameter when starting up the weblogic container, is there any other way of setting this i.e. programmatically during startup. Can

Re: Non-applicable properties? (was: ClassCastException when using Table Cells in FOP 0.95B)

2008-06-13 Thread Andreas Delmelle
- Oorspronkelijk bericht - Van: Vincent Hennebert [mailto:[EMAIL PROTECTED] Verzonden: vrijdag, juni 13, 2008 08:40 PM You’re both right of course. I didn’t have that possibility in mind when writing my post to fop-dev. No warning needed indeed :-) snip / [Me: ] * if it is not a

FOText question

2008-06-15 Thread Andreas Delmelle
Hi fopsters I've just been working on changing FOText to work with a java.nio.CharBuffer (instead of a char[]). So far, while refactoring this, I already noticed that this makes the related code much more compact on our side. Another small improvement is that TextLayoutManager no longer

Re: FOText question

2008-06-15 Thread Andreas Delmelle
- Oorspronkelijk bericht - Van: Max Berger [mailto:[EMAIL PROTECTED] Verzonden: zondag, juni 15, 2008 01:38 PM Hi Max snip / Not at all. I am still working my way through the Layout code, trying to get the alignmentContext to work, so any reduction / simplification in this respect

Re: svn commit: r668570 - /xmlgraphics/fop/branches/fop-0_95/src/java/org/apache/fop/layoutmgr/inline/LineLayoutManager.java

2008-06-17 Thread Andreas Delmelle
On Jun 17, 2008, at 10:54, [EMAIL PROTECTED] wrote: Author: jeremias Date: Tue Jun 17 01:54:07 2008 New Revision: 668570 URL: http://svn.apache.org/viewvc?rev=668570view=rev Log: Wrong line number reported in the case of a line overflow. Too fast for me... :-) Cheers Andreas

Re: FOEventHandler method call sequence

2008-06-19 Thread Andreas Delmelle
On Jun 19, 2008, at 10:01, Jeremias Maerki wrote: I'm coaching a developer implementing an ODFHandler for FOP and during implementation we've stumbled over something: the call sequence of FOEventHandler methods is not correct. Assume the following FO: fo:block Text1 fo:block Text2

Re: Border and padding on page regions

2008-06-19 Thread Andreas Delmelle
On Jun 19, 2008, at 13:26, Luca Furini wrote: snip / So, a couple of questions: - do we still think that supporting borders and padding on regions when relaxed validation is on would be something good (or, at least, not bad)? I think this would be a fine addition. Other implementations have

  1   2   3   4   >