[ https://issues.apache.org/jira/browse/FOP-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823768#comment-13823768 ]
Gonzalo Vasquez edited comment on FOP-2314 at 11/15/13 4:18 PM: ---------------------------------------------------------------- Added sample FO file to test performance improvement was (Author: gvasquez): Sample FO file to test performance improvement > Caching xmlParserClassName in org.apache.fop.svg.SimpleSVGUserAgent > ------------------------------------------------------------------- > > Key: FOP-2314 > URL: https://issues.apache.org/jira/browse/FOP-2314 > Project: Fop > Issue Type: Improvement > Components: svg > Affects Versions: trunk > Environment: Tested on Mac OSX 10.9, Java SE 7 (1.7.0_04) > Reporter: Gonzalo Vasquez > Priority: Minor > Labels: performance > Attachments: sample.fo > > > After having profiled an application I'm coding, and having detected hotspot > methods, I've come across with a few suggestions por performance improvement > which actually have worked in my environment. > Changing the referenced method to the following code makes the small trick: > From: > public String getXMLParserClassName() { > try { > SAXParserFactory factory = SAXParserFactory.newInstance(); > return factory.newSAXParser().getXMLReader().getClass().getName(); > } catch (Exception e) { > return null; > } > } > To: > private static final String xmlParserClassName; > static { > String result; > try { > SAXParserFactory factory = SAXParserFactory.newInstance(); > result = > factory.newSAXParser().getXMLReader().getClass().getName(); > } catch (Exception e) { > result = null; > } > xmlParserClassName = result; > } > public String getXMLParserClassName() { > return xmlParserClassName; > } > Could this be added as a patch to the trunk please? -- This message was sent by Atlassian JIRA (v6.1#6144)