[ 
https://issues.apache.org/jira/browse/FOP-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602187#comment-16602187
 ] 

Chris Bowditch edited comment on FOP-2810 at 9/3/18 3:05 PM:
-------------------------------------------------------------

I have managed to replicate this using a document with a mixture of Western and 
Arabic scripts, but unfortunately its a confidential XSL-FO, so I can't share 
it here. 


was (Author: cbowditch):
I have managed to replicate this using a document with a mixture of Western and 
Arabic scripts, but unfortunately its a confidential XSL-FO, so I can't share 
it here. I also noticed a side issue; The Simulated font styles are reported as 
missing when they shouldn't be cos we are simulating them!

> [PATCH] Incomplete implementation of the simulate-style flag
> ------------------------------------------------------------
>
>                 Key: FOP-2810
>                 URL: https://issues.apache.org/jira/browse/FOP-2810
>             Project: FOP
>          Issue Type: Bug
>          Components: font/unqualified
>    Affects Versions: 2.3
>            Reporter: Dan Caprioara
>            Assignee: Chris Bowditch
>            Priority: Major
>             Fix For: trunk
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CustomFont.getSimulateStyle() is used only in:
> {code:java}
> org.apache.fop.render.pdf.PDFPainter.drawTextWithDX(int, int, String, 
> FontTriplet, int, int, int[])
> {code}
> But not in:
> {code:java}
> org.apache.fop.render.pdf.PDFPainter.drawTextWithDP(int, int, String, 
> FontTriplet, int, int, int[][])
> {code}
> As a result some of the font styling is not applied.
> Modifying the above method with the following patch seem to fix the problem:
> {code:java}
> ...
>            boolean simulateStyle = tf instanceof CustomFont && ((CustomFont) 
> tf).getSimulateStyle();
>             
>             // PATCH START 
>             // Taken from #drawTextWithDX method
>             double shear = 0;
>           
>             if (simulateStyle) {
>                 //Adding this breaks the PDF: generator.add("q\n")
>                 if (triplet.getWeight() == 700) {
>                     generator.add("2 Tr 0.31543 w\n");
>                 }
>                 if (triplet.getStyle().equals("italic")) {
>                     shear = 0.333;
>                 }
>             }
>             // PATCH END
>             tu.writeTextMatrix(new AffineTransform(1, 0, shear, -1, x / 
> 1000f, y / 1000f));
>             tu.updateTf(fk, fsPoints, true);
>            generator.updateCharacterSpacing(letterSpacing / 1000f);
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to