[jira] [Commented] (FOP-1648) [PATCH]internal named destinations
[ https://issues.apache.org/jira/browse/FOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104621#comment-17104621 ] Chris Bowditch commented on FOP-1648: - Subversion: Committed revision 1877589. > [PATCH]internal named destinations > -- > > Key: FOP-1648 > URL: https://issues.apache.org/jira/browse/FOP-1648 > Project: FOP > Issue Type: Improvement > Components: renderer/pdf >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: michaelrichardson89 >Assignee: Chris Bowditch > Labels: PatchAvailable > Attachments: b46980.diff, fop-1648.patch, > internal_named_destinations.diff > > > [PATCH] > I was experiencing an issue where svg graphics would enterpret links of the > format: > > as external web-links opening up a web browser. > I have now fixed this issue (given in the attached patch) so that links in > the above format now properly go to an internal named destinations. > The named destination must be specified with the tag: > > I hope this is helpfull. > -Michael -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FOP-1648) [PATCH]internal named destinations
[ https://issues.apache.org/jira/browse/FOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029574#comment-16029574 ] simon steiner commented on FOP-1648: PDFBox is not a current fop dependency so you shouldnt use it > [PATCH]internal named destinations > -- > > Key: FOP-1648 > URL: https://issues.apache.org/jira/browse/FOP-1648 > Project: FOP > Issue Type: Improvement > Components: renderer/pdf >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: michaelrichardson89 >Assignee: Matthias Reischenbacher > Labels: PatchAvailable > Attachments: b46980.diff, fop-1648.patch, > internal_named_destinations.diff > > > [PATCH] > I was experiencing an issue where svg graphics would enterpret links of the > format: > > as external web-links opening up a web browser. > I have now fixed this issue (given in the attached patch) so that links in > the above format now properly go to an internal named destinations. > The named destination must be specified with the tag: > > I hope this is helpfull. > -Michael -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FOP-1648) [PATCH]internal named destinations
[ https://issues.apache.org/jira/browse/FOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029547#comment-16029547 ] Chris Bowditch commented on FOP-1648: - You can test PDF features using PDFBox library to load and interrogate the PDF. I will assign this back to you as there's no rush to finish it, and it would be wrong of me to take credit for your work. At least your WIP is saved here if you don't get the chance to finish it. > [PATCH]internal named destinations > -- > > Key: FOP-1648 > URL: https://issues.apache.org/jira/browse/FOP-1648 > Project: FOP > Issue Type: Improvement > Components: renderer/pdf >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: michaelrichardson89 >Assignee: Chris Bowditch > Labels: PatchAvailable > Attachments: b46980.diff, fop-1648.patch, > internal_named_destinations.diff > > > [PATCH] > I was experiencing an issue where svg graphics would enterpret links of the > format: > > as external web-links opening up a web browser. > I have now fixed this issue (given in the attached patch) so that links in > the above format now properly go to an internal named destinations. > The named destination must be specified with the tag: > > I hope this is helpfull. > -Michael -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FOP-1648) [PATCH]internal named destinations
[ https://issues.apache.org/jira/browse/FOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029500#comment-16029500 ] Matthias Reischenbacher commented on FOP-1648: -- As you want. I think I'll have some time end of June, if you can wait until then, I can finish it. I'm still not totally sure how I can make SVG/PDF related output features testable. I'll look into adding some test methods to PDFGraphics2DTestCase, please let me know if you have any other/better ideas. Thanks. > [PATCH]internal named destinations > -- > > Key: FOP-1648 > URL: https://issues.apache.org/jira/browse/FOP-1648 > Project: FOP > Issue Type: Improvement > Components: renderer/pdf >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: michaelrichardson89 >Assignee: Chris Bowditch > Labels: PatchAvailable > Attachments: b46980.diff, fop-1648.patch, > internal_named_destinations.diff > > > [PATCH] > I was experiencing an issue where svg graphics would enterpret links of the > format: > > as external web-links opening up a web browser. > I have now fixed this issue (given in the attached patch) so that links in > the above format now properly go to an internal named destinations. > The named destination must be specified with the tag: > > I hope this is helpfull. > -Michael -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FOP-1648) [PATCH]internal named destinations
[ https://issues.apache.org/jira/browse/FOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029467#comment-16029467 ] Chris Bowditch commented on FOP-1648: - Thanks [~matthias8283] I had noticed that the code was totally refactored in this area and also saw that the target was being passed in as an empty string. I can see you've done most of the work. Don't you want to finish it? I'd be happy to assign this to you. > [PATCH]internal named destinations > -- > > Key: FOP-1648 > URL: https://issues.apache.org/jira/browse/FOP-1648 > Project: FOP > Issue Type: Improvement > Components: renderer/pdf >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: michaelrichardson89 >Assignee: Chris Bowditch > Labels: PatchAvailable > Attachments: b46980.diff, fop-1648.patch, > internal_named_destinations.diff > > > [PATCH] > I was experiencing an issue where svg graphics would enterpret links of the > format: > > as external web-links opening up a web browser. > I have now fixed this issue (given in the attached patch) so that links in > the above format now properly go to an internal named destinations. > The named destination must be specified with the tag: > > I hope this is helpfull. > -Michael -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FOP-1648) [PATCH]internal named destinations
[ https://issues.apache.org/jira/browse/FOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029434#comment-16029434 ] Matthias Reischenbacher commented on FOP-1648: -- Chris: I have been working on this ticket some month ago, but didn't get it ready for commit. I'll attach you a patch (based on an older version of FOP), in case you want to use it. > [PATCH]internal named destinations > -- > > Key: FOP-1648 > URL: https://issues.apache.org/jira/browse/FOP-1648 > Project: FOP > Issue Type: Improvement > Components: renderer/pdf >Affects Versions: trunk > Environment: Operating System: All > Platform: All >Reporter: michaelrichardson89 >Assignee: Chris Bowditch > Labels: PatchAvailable > Attachments: b46980.diff, fop-1648.patch, > internal_named_destinations.diff > > > [PATCH] > I was experiencing an issue where svg graphics would enterpret links of the > format: > > as external web-links opening up a web browser. > I have now fixed this issue (given in the attached patch) so that links in > the above format now properly go to an internal named destinations. > The named destination must be specified with the tag: > > I hope this is helpfull. > -Michael -- This message was sent by Atlassian JIRA (v6.3.15#6346)
