[jira] [Commented] (FOP-2724) [PATCH] Shrink text to fit block-container

2017-07-14 Thread simon steiner (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087602#comment-16087602
 ] 

simon steiner commented on FOP-2724:


It has fop/test/layoutengine/standard-testcases/fox_shrink-to-fit.xml

> [PATCH] Shrink text to fit block-container
> --
>
> Key: FOP-2724
> URL: https://issues.apache.org/jira/browse/FOP-2724
> Project: FOP
>  Issue Type: New Feature
>  Components: layout/block
>Affects Versions: trunk
>Reporter: chunlinyao
> Attachments: block-container_no_shrink.fo, 
> block-container_no_shrink.pdf, block-container_shrink.fo, 
> block-container_shrink.pdf, shrink-to-fit.patch
>
>
> In my project I have to fill text in some fixed size area. This patch enable 
> shrink text to fit block-container feature.
> When a block-container is not auto height, and with a 
> fox:shrink-to-fit="true" attribute, If the block overflows It will reduce the 
> font size and line height to fit the block-container.
> I'm not very familiar with the fop layout engine, this is a quick hack 
> implementation, hope some one can improve it.
> I also committed the modified version in GitHub. 
> https://github.com/chunlinyao/fop/tree/b1acf564afc9747546db6c386a0ae339e69f39e9



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (FOP-2724) [PATCH] Shrink text to fit block-container

2017-07-14 Thread Chris Bowditch (JIRA)

[ 
https://issues.apache.org/jira/browse/FOP-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087441#comment-16087441
 ] 

Chris Bowditch commented on FOP-2724:
-

Thanks for the patch. Initial feedback is that it doesn't contain any sort of 
unit tests. I suggest writing Layout tests to verify the output is as expected. 
The patch won't be accept without some form of unit tests

> [PATCH] Shrink text to fit block-container
> --
>
> Key: FOP-2724
> URL: https://issues.apache.org/jira/browse/FOP-2724
> Project: FOP
>  Issue Type: New Feature
>  Components: layout/block
>Affects Versions: trunk
>Reporter: chunlinyao
> Attachments: block-container_no_shrink.fo, 
> block-container_no_shrink.pdf, block-container_shrink.fo, 
> block-container_shrink.pdf, shrink-to-fit.patch
>
>
> In my project I have to fill text in some fixed size area. This patch enable 
> shrink text to fit block-container feature.
> When a block-container is not auto height, and with a 
> fox:shrink-to-fit="true" attribute, If the block overflows It will reduce the 
> font size and line height to fit the block-container.
> I'm not very familiar with the fop layout engine, this is a quick hack 
> implementation, hope some one can improve it.
> I also committed the modified version in GitHub. 
> https://github.com/chunlinyao/fop/tree/b1acf564afc9747546db6c386a0ae339e69f39e9



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)