[jira] [Resolved] (FOP-1840) [PATCH] Region-Body Column balancing incorrect if content is table with header

2012-12-17 Thread Alexis Giotis (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexis Giotis resolved FOP-1840.


   Resolution: Fixed
Fix Version/s: trunk

> [PATCH] Region-Body Column balancing incorrect if content is table with header
> --
>
> Key: FOP-1840
> URL: https://issues.apache.org/jira/browse/FOP-1840
> Project: Fop
>  Issue Type: Improvement
>  Components: page-master/layout
>Affects Versions: 1.0
> Environment: Operating System: All
> Platform: PC
>Reporter: a.kovacs
>Assignee: fop-dev
> Fix For: trunk
>
> Attachments: b49801_dirty_hack.patch, b49801.fo, 
> balance-2-expected.pdf, balance-2.fo, balance-2.pdf, balance-3.fo.xml, 
> balance-4-edited.fo.xml, balance-4.fo.xml, balance-4-none.fo.xml, 
> balance-4.pdf, balance-5.fo, balancing-fos.zip, fix.diff, fo.xml, 
> output-balance5.pdf, patch.diff, test-after.pdf, test-before.pdf
>
>
> To reproduce bug please do the following:
> Use:
> 
> Fill the region-body with content like :
>  ...(content is table with header) ..
>  ... (one line (summary)) ..
> If the content is made of normal blocks the columns are balanced before the 
> span="all" summary line.
> like:
> 123456456789
> 234567567890
> 345678678901
> Summary: 1234567890
> If the content is a table without headers the columns are balanced correct. 
> like:
> 123456456789
> 234567567890
> 345678678901
> Summary: 1234567890
> If the content is a table with header the columns are not balanced correct. 
> (the right one is shorter.)
> HeaderHeader
> 123456567890
> 234567678901
> 345678
> 456789
> Summary: 1234567890
> The "computeDemerits()" algorithm is wrong in class 
> "BalancingColumnBreakingAlgorithm".
> The "fullLen" value is to short. Exactly the replicated header width is 
> missing. In the "par" list the header is contained only once although the 
> header is displayed in every column. (in the example twice)
> Solution could be to place the header as many times in the "par" list as many 
> columns exist, or to count the existing one header as many times as needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (FOP-1840) [PATCH] Region-Body Column balancing incorrect if content is table with header

2012-12-17 Thread Alexis Giotis (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexis Giotis resolved FOP-1840.


   Resolution: Fixed
Fix Version/s: trunk

> [PATCH] Region-Body Column balancing incorrect if content is table with header
> --
>
> Key: FOP-1840
> URL: https://issues.apache.org/jira/browse/FOP-1840
> Project: Fop
>  Issue Type: Improvement
>  Components: page-master/layout
>Affects Versions: 1.0
> Environment: Operating System: All
> Platform: PC
>Reporter: a.kovacs
>Assignee: fop-dev
> Fix For: trunk
>
> Attachments: b49801_dirty_hack.patch, b49801.fo, 
> balance-2-expected.pdf, balance-2.fo, balance-2.pdf, balance-3.fo.xml, 
> balance-4-edited.fo.xml, balance-4.fo.xml, balance-4-none.fo.xml, 
> balance-4.pdf, balance-5.fo, balancing-fos.zip, fix.diff, fo.xml, 
> output-balance5.pdf, patch.diff, test-after.pdf, test-before.pdf
>
>
> To reproduce bug please do the following:
> Use:
> 
> Fill the region-body with content like :
>  ...(content is table with header) ..
>  ... (one line (summary)) ..
> If the content is made of normal blocks the columns are balanced before the 
> span="all" summary line.
> like:
> 123456456789
> 234567567890
> 345678678901
> Summary: 1234567890
> If the content is a table without headers the columns are balanced correct. 
> like:
> 123456456789
> 234567567890
> 345678678901
> Summary: 1234567890
> If the content is a table with header the columns are not balanced correct. 
> (the right one is shorter.)
> HeaderHeader
> 123456567890
> 234567678901
> 345678
> 456789
> Summary: 1234567890
> The "computeDemerits()" algorithm is wrong in class 
> "BalancingColumnBreakingAlgorithm".
> The "fullLen" value is to short. Exactly the replicated header width is 
> missing. In the "par" list the header is contained only once although the 
> header is displayed in every column. (in the example twice)
> Solution could be to place the header as many times in the "par" list as many 
> columns exist, or to count the existing one header as many times as needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (FOP-1840) [PATCH] Region-Body Column balancing incorrect if content is table with header

2012-12-14 Thread Alexis Giotis (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexis Giotis resolved FOP-1840.


Resolution: Fixed

All of our tests have finished successfully. Well done to all of you.  

I agree that the issue with balance-5.fo is not related to the column balancing 
algorithm. Next week I will open a new Jira issue for this (unless an easy fix 
is found).

I am resolving and closing this issue on behalf of the reporter who is no 
longer employed here.

> [PATCH] Region-Body Column balancing incorrect if content is table with header
> --
>
> Key: FOP-1840
> URL: https://issues.apache.org/jira/browse/FOP-1840
> Project: Fop
>  Issue Type: Improvement
>  Components: page-master/layout
>Affects Versions: 1.0
> Environment: Operating System: All
> Platform: PC
>Reporter: a.kovacs
>Assignee: fop-dev
> Attachments: b49801_dirty_hack.patch, b49801.fo, 
> balance-2-expected.pdf, balance-2.fo, balance-2.pdf, balance-3.fo.xml, 
> balance-4-edited.fo.xml, balance-4.fo.xml, balance-4-none.fo.xml, 
> balance-4.pdf, balance-5.fo, balancing-fos.zip, fix.diff, fo.xml, 
> output-balance5.pdf, patch.diff, test-after.pdf, test-before.pdf
>
>
> To reproduce bug please do the following:
> Use:
> 
> Fill the region-body with content like :
>  ...(content is table with header) ..
>  ... (one line (summary)) ..
> If the content is made of normal blocks the columns are balanced before the 
> span="all" summary line.
> like:
> 123456456789
> 234567567890
> 345678678901
> Summary: 1234567890
> If the content is a table without headers the columns are balanced correct. 
> like:
> 123456456789
> 234567567890
> 345678678901
> Summary: 1234567890
> If the content is a table with header the columns are not balanced correct. 
> (the right one is shorter.)
> HeaderHeader
> 123456567890
> 234567678901
> 345678
> 456789
> Summary: 1234567890
> The "computeDemerits()" algorithm is wrong in class 
> "BalancingColumnBreakingAlgorithm".
> The "fullLen" value is to short. Exactly the replicated header width is 
> missing. In the "par" list the header is contained only once although the 
> header is displayed in every column. (in the example twice)
> Solution could be to place the header as many times in the "par" list as many 
> columns exist, or to count the existing one header as many times as needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (FOP-1840) [PATCH] Region-Body Column balancing incorrect if content is table with header

2012-12-14 Thread Alexis Giotis (JIRA)

 [ 
https://issues.apache.org/jira/browse/FOP-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexis Giotis resolved FOP-1840.


Resolution: Fixed

All of our tests have finished successfully. Well done to all of you.  

I agree that the issue with balance-5.fo is not related to the column balancing 
algorithm. Next week I will open a new Jira issue for this (unless an easy fix 
is found).

I am resolving and closing this issue on behalf of the reporter who is no 
longer employed here.

> [PATCH] Region-Body Column balancing incorrect if content is table with header
> --
>
> Key: FOP-1840
> URL: https://issues.apache.org/jira/browse/FOP-1840
> Project: Fop
>  Issue Type: Improvement
>  Components: page-master/layout
>Affects Versions: 1.0
> Environment: Operating System: All
> Platform: PC
>Reporter: a.kovacs
>Assignee: fop-dev
> Attachments: b49801_dirty_hack.patch, b49801.fo, 
> balance-2-expected.pdf, balance-2.fo, balance-2.pdf, balance-3.fo.xml, 
> balance-4-edited.fo.xml, balance-4.fo.xml, balance-4-none.fo.xml, 
> balance-4.pdf, balance-5.fo, balancing-fos.zip, fix.diff, fo.xml, 
> output-balance5.pdf, patch.diff, test-after.pdf, test-before.pdf
>
>
> To reproduce bug please do the following:
> Use:
> 
> Fill the region-body with content like :
>  ...(content is table with header) ..
>  ... (one line (summary)) ..
> If the content is made of normal blocks the columns are balanced before the 
> span="all" summary line.
> like:
> 123456456789
> 234567567890
> 345678678901
> Summary: 1234567890
> If the content is a table without headers the columns are balanced correct. 
> like:
> 123456456789
> 234567567890
> 345678678901
> Summary: 1234567890
> If the content is a table with header the columns are not balanced correct. 
> (the right one is shorter.)
> HeaderHeader
> 123456567890
> 234567678901
> 345678
> 456789
> Summary: 1234567890
> The "computeDemerits()" algorithm is wrong in class 
> "BalancingColumnBreakingAlgorithm".
> The "fullLen" value is to short. Exactly the replicated header width is 
> missing. In the "par" list the header is contained only once although the 
> header is displayed in every column. (in the example twice)
> Solution could be to place the header as many times in the "par" list as many 
> columns exist, or to count the existing one header as many times as needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira