8 Unit Tests Broken

2008-05-13 Thread Adrian Cumiskey
Hi all, When merging across, I discovered that my fresh checked out sandbox of trunk is showing 8 unit tests broken at the moment (mostly in the layout engine). We shouldn't really commit any code that breaks unit tests, any chance we could try and fix these? :) Adrian.

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 10:59, Andreas Delmelle wrote: On May 13, 2008, at 10:55, Adrian Cumiskey wrote: Which tests are failing on your end exactly? I've updated my sandbox yesterday evening, and all tests still passed... but that could also mean that some of my local changes haven't found

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 10:55, Adrian Cumiskey wrote: Hi Adrian When merging across, I discovered that my fresh checked out sandbox of trunk is showing 8 unit tests broken at the moment (mostly in the layout engine). We shouldn't really commit any code that breaks unit tests, any chance we

Re: 8 Unit Tests Broken

2008-05-13 Thread Adrian Cumiskey
(LayoutEngineTestSuite.java:219) at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193) Andreas Delmelle wrote: On May 13, 2008, at 10:55, Adrian Cumiskey wrote: Hi Adrian When merging across, I discovered that my fresh checked out sandbox of trunk is showing 8 unit tests

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 11:59, Andreas Delmelle wrote: background-position-shorthand-test.fo Error file:/home/acumiskey/ workspace/tru/test/fotree/testcases/background-position-shorthand- test.fo Property 'background-position-vertical' expected to evaluate to '0mpt' but got '0.0%' (test:assert

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 11:39, Adrian Cumiskey wrote: Hi Andreas, Without more thorough investigation, at a guess I would say it looks like the new id generation stuff may be contributing to some of the test failures (see NullPointerExceptions). Here are the test failures... Yep, reverting

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 12:20, Andreas Delmelle wrote: On May 13, 2008, at 11:59, Andreas Delmelle wrote: background-position-shorthand-test.fo Error file:/home/acumiskey/ workspace/tru/test/fotree/testcases/background-position-shorthand- test.fo Property 'background-position-vertical' expected

Re: 8 Unit Tests Broken

2008-05-13 Thread Adrian Cumiskey
The following test still fails as part of the LayoutEngineTestSuite :- wrapper_block.xml Error Expected w=14400 at position 0 but got: 0 (element-list category=breaker) java.lang.RuntimeException: Expected w=14400 at position 0 but got: 0 (element-list category=breaker) at

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 13:18, Adrian Cumiskey wrote: The following test still fails as part of the LayoutEngineTestSuite :- wrapper_block.xml Error Expected w=14400 at position 0 but got: 0 (element-list category=breaker) java.lang.RuntimeException: Expected w=14400 at position 0 but got: 0

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 13:44, Andreas Delmelle wrote: On May 13, 2008, at 13:18, Adrian Cumiskey wrote: The following test still fails as part of the LayoutEngineTestSuite :- wrapper_block.xml Error Expected w=14400 at position 0 but got: 0 (element-list category=breaker)

Re: 8 Unit Tests Broken

2008-05-13 Thread Vincent Hennebert
Andreas Delmelle wrote: On May 13, 2008, at 13:44, Andreas Delmelle wrote: On May 13, 2008, at 13:18, Adrian Cumiskey wrote: The following test still fails as part of the LayoutEngineTestSuite :- wrapper_block.xmlErrorExpected w=14400 at position 0 but got: 0 (element-list

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 16:01, Andreas Delmelle wrote: Before the changes I made, this sequence would also result in an Inline area, which would cause a ClassCastException during the addAreas() phase. Instead, the check in FlowLM was put there to filter the InlineKnuthSequence out, and signal

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
On May 13, 2008, at 15:24, Vincent Hennebert wrote: FWIW: The test should pass now. I'm not 100% certain whether the change is correct, but the element-list we get has the box we're looking for at position 3 (index 2), so I simply skipped the first two elements in the list... I can’t

Re: 8 Unit Tests Broken

2008-05-13 Thread Andreas Delmelle
FWIW: On May 13, 2008, at 15:24, Vincent Hennebert wrote: SEVERE: Could not create block pointers. FOText w/o Block ancestor. The first word scares me a bit ;-) No need to fear any longer. ;-) Deactivated this error message for ignorable white-space in the meantime. The only time