AW: DO NOT REPLY [Bug 46315] fox:needs-balancing extension
Hi Vincent, If that's the only problem left with my patch, I'll move on to the next extension... Yes it's looking good otherwise. Although we might get back to you about writing a bit of documentation once the fixing of the other bugs makes this extension more widely usable ^^ docwhat? There's a reason it's called code. :-) Mit freundlichen Grüßen Georg Datterl -- Kontakt -- Georg Datterl Geneon media solutions gmbh Gutenstetter Straße 8a 90449 Nürnberg HRB Nürnberg: 17193 Geschäftsführer: Yong-Harry Steiert Tel.: 0911/36 78 88 - 26 Fax: 0911/36 78 88 - 20 www.geneon.de Weitere Mitglieder der Willmy MediaGroup: IRS Integrated Realization Services GmbH:www.irs-nbg.de Willmy PrintMedia GmbH:www.willmy.de Willmy Consult Content GmbH: www.willmycc.de -Ursprüngliche Nachricht- Von: Vincent Hennebert [mailto:vhenneb...@gmail.com] Gesendet: Mittwoch, 14. Januar 2009 13:11 An: fop-dev@xmlgraphics.apache.org Betreff: Re: DO NOT REPLY [Bug 46315] fox:needs-balancing extension Hi Georg, Georg Datterl wrote: Hi Vincent, It appears that bug #46322 is on the way of properly testing this extension, with the 'one line of the spanning block at the bottom of the page' problem. Either the test will need to be tweaked in order to work around the bug, at the risk of not being extensive enough, or it will have to be disabled until bug #46322 is fixed. More in the next episode... If I understand correctly, you worry that a fixing of #46322 will invalidate this test case? How about changing the test case for #46315 after fixing #46322? Yes, that's a possibility. Why not, after all... If that's the only problem left with my patch, I'll move on to the next extension... Yes it's looking good otherwise. Although we might get back to you about writing a bit of documentation once the fixing of the other bugs makes this extension more widely usable ^^ Thanks, Vincent Mit freundlichen Grüßen Georg Datterl -- Kontakt -- Georg Datterl Geneon media solutions gmbh Gutenstetter Straße 8a 90449 Nürnberg HRB Nürnberg: 17193 Geschäftsführer: Yong-Harry Steiert Tel.: 0911/36 78 88 - 26 Fax: 0911/36 78 88 - 20 www.geneon.de Weitere Mitglieder der Willmy MediaGroup: IRS Integrated Realization Services GmbH:www.irs-nbg.de Willmy PrintMedia GmbH:www.willmy.de Willmy Consult Content GmbH: www.willmycc.de -Ursprüngliche Nachricht- Von: bugzi...@apache.org [mailto:bugzi...@apache.org] Gesendet: Dienstag, 13. Januar 2009 12:34 An: fop-dev@xmlgraphics.apache.org Betreff: DO NOT REPLY [Bug 46315] fox:needs-balancing extension https://issues.apache.org/bugzilla/show_bug.cgi?id=46315 --- Comment #5 from Vincent Hennebert vhenneb...@gmail.com 2009-01-13 03:34:11 PST --- (In reply to comment #4) (In reply to comment #3) Created an attachment (id=23098) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=23098) [details] [details] Second try of patch Please review and comment. Hi Georg, Thanks for the patch. It's almost ready to be committed, but I'd like to simplify the test case a bit (remove the inline elements and the Arial font specification). Unfortunately that affects line height so the whole test needs to be re-worked to give to same results as before. I'll probably finish that tomorrow. Vincent Vincent
AW: DO NOT REPLY [Bug 46315] fox:needs-balancing extension
Hi Vincent, It appears that bug #46322 is on the way of properly testing this extension, with the 'one line of the spanning block at the bottom of the page' problem. Either the test will need to be tweaked in order to work around the bug, at the risk of not being extensive enough, or it will have to be disabled until bug #46322 is fixed. More in the next episode... If I understand correctly, you worry that a fixing of #46322 will invalidate this test case? How about changing the test case for #46315 after fixing #46322? If that's the only problem left with my patch, I'll move on to the next extension... Mit freundlichen Grüßen Georg Datterl -- Kontakt -- Georg Datterl Geneon media solutions gmbh Gutenstetter Straße 8a 90449 Nürnberg HRB Nürnberg: 17193 Geschäftsführer: Yong-Harry Steiert Tel.: 0911/36 78 88 - 26 Fax: 0911/36 78 88 - 20 www.geneon.de Weitere Mitglieder der Willmy MediaGroup: IRS Integrated Realization Services GmbH:www.irs-nbg.de Willmy PrintMedia GmbH:www.willmy.de Willmy Consult Content GmbH: www.willmycc.de -Ursprüngliche Nachricht- Von: bugzi...@apache.org [mailto:bugzi...@apache.org] Gesendet: Dienstag, 13. Januar 2009 12:34 An: fop-dev@xmlgraphics.apache.org Betreff: DO NOT REPLY [Bug 46315] fox:needs-balancing extension https://issues.apache.org/bugzilla/show_bug.cgi?id=46315 --- Comment #5 from Vincent Hennebert vhenneb...@gmail.com 2009-01-13 03:34:11 PST --- (In reply to comment #4) (In reply to comment #3) Created an attachment (id=23098) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=23098) [details] [details] Second try of patch Please review and comment. Hi Georg, Thanks for the patch. It's almost ready to be committed, but I'd like to simplify the test case a bit (remove the inline elements and the Arial font specification). Unfortunately that affects line height so the whole test needs to be re-worked to give to same results as before. I'll probably finish that tomorrow. Vincent Vincent -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
AW: DO NOT REPLY [Bug 46315] fox:needs-balancing extension
Hi Vincent, given the fact that nobody else reads our thread, fox:disable-column-balancing it is and I think I made all suggested changes. Now I'm trying to build a testcase and then move on to the next needed extension. I'm running ant target juni-layout-standard but get lots of error messages and warnings from all kinds of tests (Junit and xmlunit are present): Test: block_font-style.xml [ERROR] Invalid property value encountered in font-style=obscure: org.apache.fop.fo.expr.PropertyException: No conversion defined obscure; property:'font-style' (Keine Kontextinformationen verfügbar) [ERROR] Invalid property value encountered in font-style=obscure: org.apache.fop.fo.expr.PropertyException: No conversion defined obscure; property:'font-style' (Keine Kontextinformationen verfügbar) [ERROR] Invalid property value encountered in font-style=obscure: org.apache.fop.fo.expr.PropertyException: No conversion defined obscure; property:'font-style' (Keine Kontextinformationen verfügbar) [WARN ] Font serif,backslant,400 not found. Substituting with serif,normal,400. [WARN ] Font sans-serif,backslant,400 not found. Substituting with sans-serif,normal,400. [WARN ] Font monospace,backslant,400 not found. Substituting with monospace,normal,400. ... Test: table_table-row_empty.xml [INFO ] table-layout=fixed and width=auto, but auto-layout not supported = assuming width=100%. (Keine Kontextinformationen verfügbar) - --- - Standard Error - 09.01.2009 10:18:33 org.apache.fop.layoutengine.LayoutEngineTestSuite$1 runTest SCHWERWIEGEND: Error on block-container_absolute-position_multi-column.xml 09.01.2009 10:18:36 org.apache.fop.layoutengine.LayoutEngineTestSuite$1 runTest SCHWERWIEGEND: Error on block-container_reference-orientation_bug36391.xml 09.01.2009 10:18:47 org.apache.fop.util.ColorSpaceCache get WARNUNG: Color profile 'nonexistent.icc' not found. 09.01.2009 10:18:47 org.apache.fop.util.ColorUtil parseAsFopRgbIcc WARNUNG: Color profile 'nonexistent.icc' not found. Using rgb replacement values. 09.01.2009 10:18:48 org.apache.fop.layoutengine.LayoutEngineTestSuite$1 runTest SCHWERWIEGEND: Error on footnote_changing-page-bpd.xml 09.01.2009 10:18:48 org.apache.fop.layoutengine.LayoutEngineTestSuite$1 runTest ... - --- Testcase: block-container_absolute-position_multi-column.xml(org.apache.fop.layoutengine.LayoutEngineTestSuite$1): Caused an ERROR Expected XPath expression to evaluate to '1', but got '2' (XPath: count(//pageViewport)) java.lang.RuntimeException: Expected XPath expression to evaluate to '1', but got '2' (XPath: count(//pageViewport)) at org.apache.fop.layoutengine.EvalCheck.check(EvalCheck.java:83) at org.apache.fop.layoutengine.LayoutEngineTester.checkAll(LayoutEngineTester.java:235) at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:182) at org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219) at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193) Testcase: block-container_reference-orientation_bug36391.xml(org.apache.fop.layoutengine.LayoutEngineTestSuite$1): Caused an ERROR Expected XPath expression to evaluate to '[0.0 -1.0 1.0 0.0 0.0 31000.0]', but got '[-1.0 -0.0 0.0 -1.0 3.0 15400.0]' (XPath: //mainReference/span/flow[1]/block[4]/block[1]/block[1]/@ctm) java.lang.RuntimeException: Expected XPath expression to evaluate to '[0.0 -1.0 1.0 0.0 0.0 31000.0]', but got '[-1.0 -0.0 0.0 -1.0 3.0 15400.0]' (XPath: //mainReference/span/flow[1]/block[4]/block[1]/block[1]/@ctm) at org.apache.fop.layoutengine.EvalCheck.check(EvalCheck.java:83) at org.apache.fop.layoutengine.LayoutEngineTester.checkAll(LayoutEngineTester.java:235) at org.apache.fop.layoutengine.LayoutEngineTester.runTest(LayoutEngineTester.java:182) at org.apache.fop.layoutengine.LayoutEngineTestSuite$LayoutEngineTestCase.testMain(LayoutEngineTestSuite.java:219) at org.apache.fop.layoutengine.LayoutEngineTestSuite$1.runTest(LayoutEngineTestSuite.java:193) ... Test org.apache.fop.layoutengine.LayoutEngineTestSuite FAILED Am I doing something wrong here or are these testcases not supposed to succeed? Regards, Georg Datterl -- Kontakt -- Georg Datterl Geneon media solutions gmbh Gutenstetter Straße 8a 90449 Nürnberg HRB Nürnberg: 17193 Geschäftsführer: Yong-Harry Steiert Tel.: 0911/36 78 88 - 26 Fax: 0911/36 78 88 - 20 www.geneon.de Weitere Mitglieder der Willmy MediaGroup: IRS Integrated Realization Services GmbH:www.irs-nbg.de Willmy PrintMedia GmbH:www.willmy.de Willmy Consult Content GmbH: www.willmycc.de
Re: AW: DO NOT REPLY [Bug 46315] fox:needs-balancing extension
Hi Georg
No, we haven't documented the area tree format explicitely. I guess we
assume that for people going that deep into FOP the source code is
enough documentation. At any rate, there's no lack of examples once
you've run the whole test suite once. ;-)
What we have is some documentation on how to create layout engine tests:
http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests
On 09.01.2009 12:41:53 Georg Datterl wrote:
Hi Vincent, hi Jeremias,
I made one single minor mistake and 49 tests complained... Anyway,
having fixed that, I'm looking at the eval tag and I guess, the xpath
expression is evaluated against the AreaTree. Is there a documentation
for this Tree or can I only find how I can see it and then find my way
around in it?
Regards
Georg Datterl
-- Kontakt --
Georg Datterl
Geneon media solutions gmbh
Gutenstetter Straße 8a
90449 Nürnberg
HRB Nürnberg: 17193
Geschäftsführer: Yong-Harry Steiert
Tel.: 0911/36 78 88 - 26
Fax: 0911/36 78 88 - 20
www.geneon.de
Weitere Mitglieder der Willmy MediaGroup:
IRS Integrated Realization Services GmbH:www.irs-nbg.de
Willmy PrintMedia GmbH:www.willmy.de
Willmy Consult Content GmbH: www.willmycc.de
-Ursprüngliche Nachricht-
Von: Vincent Hennebert [mailto:vhenneb...@gmail.com]
Gesendet: Freitag, 9. Januar 2009 12:04
An: fop-dev@xmlgraphics.apache.org
Betreff: Re: DO NOT REPLY [Bug 46315] fox:needs-balancing extension
Hi Georg,
You can usually forget about the warnings, as long as you don't have the
message Test org.apache.fop.layoutengine.LayoutEngineTestSuite FAILED
at the end of the output.
Try generating PDF out of the failing testcases and visually check what's
wrong; simply run the following command in the test/layoutengine
directory:
fop -xsl testcase2fo.xsl -xml standard-testcases/{failing-test}.xml -pdf
out.pdf
That may help you figure out what's wrong. You can also run the debugger side
by side, on both a non-modified version of the Trunk and the version with
your changes, and see where it starts to diverge.
If you're stuck you can always attach an updated patch on Bugzilla, so that
we can have a look at it.
Good luck,
Vincent
Georg Datterl wrote:
Hi Vincent,
given the fact that nobody else reads our thread,
fox:disable-column-balancing it is and I think I made all suggested
changes. Now I'm trying to build a testcase and then move on to the next
needed extension. I'm running ant target juni-layout-standard but get lots
of error messages and warnings from all kinds of tests (Junit and xmlunit
are present):
Test: block_font-style.xml
[ERROR] Invalid property value encountered in font-style=obscure:
org.apache.fop.fo.expr.PropertyException: No conversion defined obscure;
property:'font-style' (Keine Kontextinformationen verfügbar)
[ERROR] Invalid property value encountered in font-style=obscure:
org.apache.fop.fo.expr.PropertyException: No conversion defined obscure;
property:'font-style' (Keine Kontextinformationen verfügbar)
[ERROR] Invalid property value encountered in font-style=obscure:
org.apache.fop.fo.expr.PropertyException: No conversion defined obscure;
property:'font-style' (Keine Kontextinformationen verfügbar)
[WARN ] Font serif,backslant,400 not found. Substituting with
serif,normal,400.
[WARN ] Font sans-serif,backslant,400 not found. Substituting with
sans-serif,normal,400.
[WARN ] Font monospace,backslant,400 not found. Substituting with
monospace,normal,400.
...
Test: table_table-row_empty.xml
[INFO ] table-layout=fixed and width=auto, but auto-layout not
supported = assuming width=100%. (Keine Kontextinformationen
verfügbar)
- ---
- Standard Error -
09.01.2009 10:18:33
org.apache.fop.layoutengine.LayoutEngineTestSuite$1 runTest
SCHWERWIEGEND: Error on
block-container_absolute-position_multi-column.xml
09.01.2009 10:18:36
org.apache.fop.layoutengine.LayoutEngineTestSuite$1 runTest
SCHWERWIEGEND: Error on
block-container_reference-orientation_bug36391.xml
09.01.2009 10:18:47 org.apache.fop.util.ColorSpaceCache get
WARNUNG: Color profile 'nonexistent.icc' not found.
09.01.2009 10:18:47 org.apache.fop.util.ColorUtil parseAsFopRgbIcc
WARNUNG: Color profile 'nonexistent.icc' not found. Using rgb replacement
values.
09.01.2009 10:18:48
org.apache.fop.layoutengine.LayoutEngineTestSuite$1 runTest
SCHWERWIEGEND: Error on footnote_changing-page-bpd.xml
09.01.2009 10:18:48
org.apache.fop.layoutengine.LayoutEngineTestSuite$1 runTest
...
- ---
Testcase:
block-container_absolute-position_multi-column.xml(org.apache.fop.layoutengine.LayoutEngineTestSuite$1):
Caused an ERROR
Expected XPath expression
