DO NOT REPLY [Bug 40729] [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=40729

Glenn Adams  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #14 from Glenn Adams  2012-04-01 06:31:38 UTC ---
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-11-13 06:24 ---
Fix committed: http://svn.apache.org/viewvc?view=rev&rev=474327 Thanks!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-11-13 05:43 ---
Sorry, Peter, I didn't want to imply that your patch was of low quality. It was
actually very high quality. Just because I had to touch up the code a little
concerning our code conventions doesn't make your patch bad. I was very happy
with your patch and was only logging my changes to your original patch. If you
can match our Java convention for the next patch, that's of course a good thing
since it will save me time to go over it.

No need to send a patch just to change one line. I'll look at it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-11-13 04:25 ---
The problem is in the PDFColor constructor

Replacing the line 
  if(cs!=null && cs.getType()==ColorSpace.TYPE_CMYK) {
with 
  if(cs!=null && cs instanceof CMYKColorSpace) {

fixes the issue I think.

Not entirely sure this is the most elegant/performant/full proof solution.

Btw, sorry for the low quality of this patch (not having any real sponsors made
me take shortcuts, like not making *any* unit tests). Always wrong.

Anyway, should I submit a "real" fop patch for this or is this entry sufficient?



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-11-13 02:56 ---
Created an attachment (id=19118)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19118&action=view)
Example using CMYK colors with a CMYK color profile

You can get the color profile for color-sandbox.fo here:
http://www.eci.org/eci/en/060_downloads.php
(download ECI_Offset_2004.zip)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-11-13 02:30 ---

> While testing I found that CMYK color referencing an CMYK color profile are
> generated in the DeviceCMYK color space and the ICC profile is not embedded. I
> have yet to take a closer look at that one.

Could you provide the test. I would be happy to take a look at this later this 
week.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-11-13 02:27 ---
Patch applied! Finally. Thanks a lot for your work and patience, Peter.
http://svn.apache.org/viewvc?view=rev&rev=474225

While testing I found that CMYK color referencing an CMYK color profile are
generated in the DeviceCMYK color space and the ICC profile is not embedded. I
have yet to take a closer look at that one.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-11-12 09:58 ---
No, that's not necessary. I just needed confirmation that it's a typo. Thanks.
I'll handle the patch tomorrow.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-11-12 09:34 ---
I guess my handwriting is not so readable

Name is Peter Coppens, email is [EMAIL PROTECTED]

Do I have to resend the document?

(In reply to comment #5)
> (Trying this channel as Peter hasn't replied through direct mail, yet).
> 
> Peter, the ASF's secretary has recorded a new ICAL entry as below. Is this not
> your entry or is it a mistake/typo? In Bugzilla it says your name is "Peter
> Coppens". The mail addresses also don't match.
> 
> notinavail:Peter Coppans:Peter Coppans:pgp.coppans.at.gmail.com:Signed CLA
> 
> 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-11-12 07:47 ---
(Trying this channel as Peter hasn't replied through direct mail, yet).

Peter, the ASF's secretary has recorded a new ICAL entry as below. Is this not
your entry or is it a mistake/typo? In Bugzilla it says your name is "Peter
Coppens". The mail addresses also don't match.

notinavail:Peter Coppans:Peter Coppans:pgp.coppans.at.gmail.com:Signed CLA



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-10-25 12:07 ---
Apologies for the NPE's. Should have added some unit tests I guess.

Concerning the open issues listed. Perhaps I can find some time to look at some
of them (e.g. the PSRenderer) once this patch ends up in the code tree (and I
get the Batik related changes in a state I can post).

Peter

PS As mentioned I faxed the ICLA so I hope it will make it through the process
(whatever that is)


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-10-25 09:21 ---
I finally managed to look into this. The patch looks good after styling the code
to our code conventions. I had to fix an NPE when there were no color-profiles
specified and the rgb-icc() function was used. Furthermore, the fop-rgb-icc()
function did not parse the fallback color values correctly. I now have this
patch ready to be committed in a separate checkout locally. As soon as the ICLA
is registered I'll commit.

What we have to look into when the patch is applied:
- When the PDF/A-1b profile is active, FOP does not check for CMYK colors when
the output intent is sRGB (which is the default). I guess I'll have to look into
this a little deeper. There may be additional things that need to be changed.
- The PSRenderer will need to learn to handle the DeviceCMYK colors correctly.

So, Peter, thanks a lot for the hard work so far. This looks really good. I bet
many people will be extremely happy with the new functionality. Please have a
little patience until the ICLA pops up.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-10-18 12:06 ---
Created an attachment (id=19025)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19025&action=view)
cmyk and rgb-icc support

This is a new version of the previous patch. A new version is needed in order
to make the equivalent changes to batik easier.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40729] - [PATCH] Add support for rgb-icc and proprietary cmyk color functions

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40729





--- Additional Comments From [EMAIL PROTECTED]  2006-10-11 13:19 ---
Created an attachment (id=18990)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18990&action=view)
Patch file


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.