DO NOT REPLY [Bug 43166] unclosed border on nested inlines

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43166

Glenn Adams  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #6 from Glenn Adams  2012-04-01 06:18:00 UTC ---
batch transition to closed; if someone wishes to restore one of these to
resolved in order to perform a verification step, then feel free to do so

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 43166] unclosed border on nested inlines

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43166

Simon Pepping  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #5 from Simon Pepping  2011-01-07 10:48:08 EST 
---
Works OK now, probably due to the improvements in revision 1052561.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 43166] unclosed border on nested inlines

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43166

--- Comment #4 from Matthias Reischenbacher  2010-12-28 
15:16:28 EST ---
(In reply to comment #3)
> The patch works of course, but it looks a bit like magic. I would like to dig
> deeper into this. I am surprised that the actual value of the index makes such
> a difference. It would be helpful if you would indicate:

You're right, the patch only does magic, but doesn't really fix the problem.
Debugging again I discovered, that the letter space is added to an existing
sequence and then the elements of a new sequence are also added to the existing
sequence. See: InlineKnuthSequence.appendSequence(). Since notifyPos() has
already been called for the positions of the new sequence (see
InlineLayoutManager.getNextKnuthElements() --> sequence.wrapPositions()), the
letter space has a higher index than the positions of the new sequence,
although it is added before it. This causes the positions of the final sequence
to be something like that:
-1 (border)
0
2 (letter spacing)
1
-1 (border)

When hyphenation is used and hyphenation opportunities are found this is no
problem because all positions get a new index when
InlineStackingLayoutManager.applyChanges() is executed.

> 1. where in the code the border is added or not added to the result page,
> depending on the value of the index;

This happens inside:
InlineLayoutManager.addAreas()
--> setTraits(areaCreated, lastPos == null || !isLast(lastPos));

> 2. where in the code the knuth element is replaced instead of being added.

That was just no sense of my part. The letter space is added as a new knuth
element and nothing is replaced.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 43166] unclosed border on nested inlines

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43166

--- Comment #3 from Simon Pepping  2010-12-22 13:39:40 EST 
---
The patch works of course, but it looks a bit like magic. I would like to dig
deeper into this. I am surprised that the actual value of the index makes such
a difference. It would be helpful if you would indicate:

1. where in the code the border is added or not added to the result page,
depending on the value of the index;

2. where in the code the knuth element is replaced instead of being added.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 43166] unclosed border on nested inlines

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43166

--- Comment #2 from Matthias Reischenbacher  2010-12-19 
19:04:28 EST ---
Created an attachment (id=26425)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26425)
Patch

The border isn't rendered because InlineLevelLayoutManger fails to detect the
last knuth element due to an incorrect value of the position counter
(lastGeneratedPosition in AbstractLayoutManager). The counter is incremented
when adding letter spacing and actually no new knuth element is added to the
sequence because an existing one is just replaced. Decreasing the counter
before letter spacing is applied fixes this issue.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 43166] - unclosed border on nested inlines

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43166


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 43166] - unclosed border on nested inlines

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43166





--- Additional Comments From [EMAIL PROTECTED]  2007-08-20 02:33 ---
Created an attachment (id=20678)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20678&action=view)
FO to reproduce bug


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.