DO NOT REPLY [Bug 45971] [PATCH] Fop CLI Errors

2012-04-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45971

Glenn Adams gl...@skynav.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #5 from Glenn Adams gl...@skynav.com 2012-04-01 06:45:29 UTC ---
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45971] [PATCH] Fop CLI Errors

2010-11-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45971

--- Comment #4 from Vincent Hennebert vhenneb...@gmail.com 2010-11-08 
07:12:33 EST ---
(In reply to comment #3)
 (In reply to comment #2)
  Patch looks good, Vincent.  Thanks!
  
  -Tom
 
 Vincent, I was disappointed not to see this fix mentioned in the change list
 for the 1.0 release.  I know it's not major, but it did change the CLI 
 response
 to fop.

Hi Tom,

When we commit changes we usually add an entry to the status.xml file at the
root of the project. The changes are then reflected on the website:
http://xmlgraphics.apache.org/fop/1.0/changes_1.0.html

I don't remember back then if I just forgot to add an entry relating to this
issue, or if I judged that that was too small a change to warrant a log. I've
now added one:
http://svn.apache.org/viewvc?view=revisionrevision=1032549

It will appear on the website soon. A bit late I admit but that may help other
users. Was that what you were looking for?

Regards,
Vincent

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45971] [PATCH] Fop CLI Errors

2010-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45971

--- Comment #3 from Tom Browder tom.brow...@gmail.com 2010-11-01 19:27:41 EDT 
---
(In reply to comment #2)
 Patch looks good, Vincent.  Thanks!
 
 -Tom

Vincent, I was disappointed not to see this fix mentioned in the change list
for the 1.0 release.  I know it's not major, but it did change the CLI response
to fop.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45971] [PATCH] Fop CLI Errors

2008-10-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45971


Vincent Hennebert [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
Summary|Fop CLI Errors (Patch to|[PATCH] Fop CLI Errors
   |Correct Included)   |




--- Comment #1 from Vincent Hennebert [EMAIL PROTECTED]  2008-10-13 03:48:58 
PST ---
Hi Tom,

Good thing you created a bug report for this, it was being forgotten. Patch
applied in revision 704008
(http://svn.apache.org/viewvc?view=revrevision=704008). The following
modifications were made:
- minor style fixes (illegal tab characters)
- System.exit is called at only two places: with a return value of 1 when an
unknown argument is given; with a return value of 0 in all other cases. The
rationale is that it's not erroneous to simply run fop without argument, or
with -v or -h.
- the help message is accordingly sent to either stderr or stdout

The semantic of the boolean return value has been changed: false now indicates
that processing should stop normally, not because of an error (there are
exceptions for that).

Ideally this whole part of the code should be re-worked to make use of a common
command-line parsing library (Apache Commons CLI), but this patch is a
reasonable trade-off.

Please re-open the bug if you're not happy with the modifications made.
Thanks Tom!
Vincent


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45971] [PATCH] Fop CLI Errors

2008-10-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45971





--- Comment #2 from Tom Browder [EMAIL PROTECTED]  2008-10-13 18:02:20 PST ---
Patch looks good, Vincent.  Thanks!

-Tom


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.