DO NOT REPLY [Bug 48071] [PATCH] MinOptMax immutable/layoutmgr refactoring
https://issues.apache.org/bugzilla/show_bug.cgi?id=48071 Glenn Adams gl...@skynav.com changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #5 from Glenn Adams gl...@skynav.com 2012-04-01 06:18:59 UTC --- batch transition to closed; if someone wishes to restore one of these to resolved in order to perform a verification step, then feel free to do so -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48071] [PATCH] MinOptMax immutable/layoutmgr refactoring
https://issues.apache.org/bugzilla/show_bug.cgi?id=48071 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added CC||vhenneb...@gmail.com --- Comment #3 from Andreas L. Delmelle adelme...@apache.org 2011-01-08 14:31:05 EST --- *** Bug 46639 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48071] [PATCH] MinOptMax immutable/layoutmgr refactoring
https://issues.apache.org/bugzilla/show_bug.cgi?id=48071 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #4 from Andreas L. Delmelle adelme...@apache.org 2011-01-08 18:13:34 EST --- Cleanup: seems this one was committed, but still marked unresolved. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48071] [PATCH] MinOptMax immutable/layoutmgr refactoring
https://issues.apache.org/bugzilla/show_bug.cgi?id=48071 --- Comment #2 from Vincent Hennebert vhenneb...@gmail.com 2009-12-22 09:24:55 UTC --- I had a chat with Alexander via VOIP yesterday to discuss a few details of his patch. The patch is now in good shape and I've committed it under revision 893238: http://svn.apache.org/viewvc?rev=893238view=rev Sorry about the delay and thanks a lot for your patch. It cleans up quite a few things in the layout engine area. Vincent -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48071] [PATCH] MinOptMax immutable/layoutmgr refactoring
https://issues.apache.org/bugzilla/show_bug.cgi?id=48071 --- Comment #1 from Max Berger m...@berger.name 2009-10-29 06:20:57 UTC --- Alex, just looked at your patch: - I like the basic idea of replacing public field with the corresponding accessors, and making the class immutable. This is much cleaner design. - A speed comparison would be nice - is the new implementation slower or faster? Do you have proof for your claim (e.g. time render a document with and without the patch - any significant difference?) - As another enhancement, the flyweight pattern could be applied to minoptmax (of course, only after your patch is applied) BUT: - This patch has MUCH more content than just the MinOptMax. It contains many reformattings (probably automatically done by your IDE) AND some other renames, cleanups, etc. Although I do believe that what you did makes sense in most cases, this makes this patch very difficult to review. - I also see some diffs in $Id$ lines, which should not happen (looks like we're missing svn props here, will check that) I know it is difficult, but could you please refafctor the patch to address only one issue at a time? (I'll send an email about this to the fop-dev list) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
