DO NOT REPLY [Bug 48334] [PATCH] xml:base
https://issues.apache.org/bugzilla/show_bug.cgi?id=48334 Glenn Adams gl...@skynav.com changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #8 from Glenn Adams gl...@skynav.com 2012-04-01 06:18:22 UTC --- batch transition to closed; if someone wishes to restore one of these to resolved in order to perform a verification step, then feel free to do so -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48334] [PATCH] xml:base
https://issues.apache.org/bugzilla/show_bug.cgi?id=48334 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #7 from Andreas L. Delmelle adelme...@apache.org 2011-02-01 15:28:02 EST --- Patch applied as proposed in r1066190 (http://svn.apache.org/viewvc?rev=1066190view=rev) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48334] [PATCH] xml:base
https://issues.apache.org/bugzilla/show_bug.cgi?id=48334 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Attachment #26500|0 |1 is obsolete|| --- Comment #6 from Andreas L. Delmelle adelme...@apache.org 2011-01-23 05:18:30 EST --- Created an attachment (id=26538) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26538) revised patch New patch, taking into account the feedback. Some unrelated changes to the affected classes have been committed separately, so the patch now only contains changes relevant to this issue. Change wrt previous version: the String constructor for URIProperty has been made private and marked as the alternate constructor rather than the default one. That seemed to make more sense since that constructor was actually only needed for the backward compatibility case. Come to think of it, the only compatibility issues that arose within our own code, appeared in the fotree tests... Something to take a look at later. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48334] [PATCH] xml:base
https://issues.apache.org/bugzilla/show_bug.cgi?id=48334 --- Comment #5 from Andreas L. Delmelle adelme...@apache.org 2011-01-22 13:54:04 EST --- (In reply to comment #4) The idea and your implementation look good. Some code is missing: xml:base should be listed as a valid property in PropertyList.addAttributesToList. Oops! Forgot to add that one... :-( The backward compatibility case causes some complexity, but it seems to work well. I think that the class requires a better explanation of this case: when it applies and how it is handled. Having that explanation in this bug report does not suffice. OK, makes sense. I will post a slightly revised patch for final review. Unless anyone objects, this will find its way into FOP Trunk beginning of next week. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48334] [PATCH] xml:base
https://issues.apache.org/bugzilla/show_bug.cgi?id=48334 --- Comment #4 from Simon Pepping spepp...@apache.org 2011-01-21 10:05:59 EST --- The idea and your implementation look good. Some code is missing: xml:base should be listed as a valid property in PropertyList.addAttributesToList. The backward compatibility case causes some complexity, but it seems to work well. I think that the class requires a better explanation of this case: when it applies and how it is handled. Having that explanation in this bug report does not suffice. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48334] [PATCH] xml:base
https://issues.apache.org/bugzilla/show_bug.cgi?id=48334 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Platform|PC |All Summary|xml:base|[PATCH] xml:base OS/Version|Linux |All -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48334] [PATCH] xml:base
https://issues.apache.org/bugzilla/show_bug.cgi?id=48334 --- Comment #3 from Andreas L. Delmelle adelme...@apache.org 2011-01-17 14:17:51 EST --- Note that, apart from fo:external-graphic, the src property also applies to fo:color-profile and fo:external-document. If xml:base is set on fo:root or fo:declarations, the prototype will work for those cases as well. With only a trivial change (untested), the same could be applied to external-destination. That would allow one to create a document with a fo:block containing images from a specific website, and in the same block, specify relative URIs as external-destinations. If xml:base is set correctly, those links will then point to locations on the website the images are hosted on. Thinking more about it, it does seem like a powerful addition to being able to set a single base URI via the user-config. That case could also easily be covered by setting xml:base on the fo:root. Benefit being that the base-uri is available in the source (instead of only in a configuration that, perhaps, only exists while the source is rendered). Implementing xml:base in the user-config itself is an entirely different story, but there might be interesting use-cases for that as well. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
