DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 --- Comment #10 from Glenn Adams gad...@apache.org 2012-04-24 05:31:53 UTC --- (In reply to comment #9) (In reply to comment #3) Created attachment 26660 [details] The validation of TrueType descenders. Some times TrueTupe contains incorrect OS/2 ascender and descender, but hh metrics is more correct. In this case the OS/2 descender value is positive or equal to zero. We found a several fonts that have such problem. In this patch the validation of descender value is added to function TTFFile.determineAscDesc(). The validation of computed localAscender and localDescender is added to TTFFile.guessVerticalMetricsFromGlyphBBox. May such changes could make FOP more robust of font descenders problems? if you wish to have this patch considered, please provide a patch file, and not an edited source file (for which I have no idea which revision you based it upon) Alexander, I am still awaiting your input as requested above. if I see no further input by April 30, I will close this bug due to lack of requested information. Regards, Glenn -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 Glenn Adams gad...@apache.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #9 from Glenn Adams gad...@apache.org 2012-04-21 05:08:00 UTC --- (In reply to comment #3) Created attachment 26660 [details] The validation of TrueType descenders. Some times TrueTupe contains incorrect OS/2 ascender and descender, but hh metrics is more correct. In this case the OS/2 descender value is positive or equal to zero. We found a several fonts that have such problem. In this patch the validation of descender value is added to function TTFFile.determineAscDesc(). The validation of computed localAscender and localDescender is added to TTFFile.guessVerticalMetricsFromGlyphBBox. May such changes could make FOP more robust of font descenders problems? if you wish to have this patch considered, please provide a patch file, and not an edited source file (for which I have no idea which revision you based it upon) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 Bug 50723 depends on bug 50483, which changed state. Bug 50483 Summary: [PATCH] Full font embedding and Subset embedding in Post Script https://issues.apache.org/bugzilla/show_bug.cgi?id=50483 What|Old Value |New Value Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 --- Comment #8 from Glenn Adams gl...@skynav.com 2012-04-07 01:44:27 UTC --- resetting P2 open bugs to P3 pending further review -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 Glenn Adams gl...@skynav.com changed: What|Removed |Added Priority|P2 |P3 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 --- Comment #7 from Mehdi Houshmand med1...@gmail.com 2011-02-23 03:45:29 EST --- I've added a bit of testing to the o.a.f.fonts.truetype package, some of which would be of use here, but my patch is to be applied to the Temp_TrueTypeInPostScript branch and would require some work to be ported to trunk. (I assume this patch is for trunk, if not, feel free to ignore the above statement) As for testing... That is an area we are sadly complacent on and from my experience with the fonts package, we want both unit tests (which you can plagiarise from my patch) and we want to have more actual font files to test with. The problem with fonts is that it's not always obvious where the bugs are, so we need to test them as exhaustively as we can. In my patch, I've used Droid Sans Mono (a font I liberated from google's Android) to test the behaviour of a mono-spaced font since it was under the Apache license. The unit tests I've added are based on that and DejaVu which was already supplied and would be fairly worthless without their inclusion. In summary, no Andreas, to my knowledge there isn't another way to tests fonts other than the methods you mention. But then, I'm still a little green when it comes to FOP so someone else may have a better idea. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 --- Comment #4 from Peter Coppens pc.subscripti...@gmail.com 2011-02-22 16:44:59 EST --- Wonder whether anyone of the fop community is willing to share viewpoints on the approach taken in the patch. Seems a fairly safe change at first sight. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 --- Comment #5 from Andreas L. Delmelle adelme...@apache.org 2011-02-22 18:15:02 EST --- Looking closer, this indeed seems like a fairly inconsequential (apart from fixing the bug, obviously ;-P). Still, endorsing and committing it would seem to require incorporating such a font (hardcoding?) in the test suite... which would either make it dependent on the font being locally available, or we would have to distribute such a font (?) Or is there another way to check this? Anyone? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Depends on||50483 --- Comment #6 from Andreas L. Delmelle adelme...@apache.org 2011-02-22 19:28:19 EST --- Seems like Mehdi's efforts in bug 50483 may offer an answer to my question. The patch also touches TTFFile and, IIC, adds testing-infrastructure that might be of use here (?) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 --- Comment #3 from Eugene Markovskyi eugene.markovs...@duallab.com 2011-02-15 04:58:34 EST --- Created an attachment (id=26660) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26660) The validation of TrueType descenders. Some times TrueTupe contains incorrect OS/2 ascender and descender, but hh metrics is more correct. In this case the OS/2 descender value is positive or equal to zero. We found a several fonts that have such problem. In this patch the validation of descender value is added to function TTFFile.determineAscDesc(). The validation of computed localAscender and localDescender is added to TTFFile.guessVerticalMetricsFromGlyphBBox. May such changes could make FOP more robust of font descenders problems? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 50723] Incorrect text underlines position for some fonts
https://issues.apache.org/bugzilla/show_bug.cgi?id=50723 --- Comment #1 from Peter Coppens pc.subscripti...@gmail.com 2011-02-10 09:55:56 EST --- Does the FOP community consider this a font issue or a FOP problem? In case it is considered a FOP issue we are willing to contribute a patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
