DO NOT REPLY [Bug 51677] [PATCH] Small logging performance fix for BreakingAlgorithm
https://issues.apache.org/bugzilla/show_bug.cgi?id=51677 Sergey Vladimirov changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||WONTFIX --- Comment #6 from Sergey Vladimirov 2012-04-01 19:55:24 UTC --- (In reply to comment #5) > Sergey, do you expect to provide a test FO file for verifying the impact of > your performance patch? if not, then I will move this bug to resolved+wontfix, > thanks Glenn Glenn, I'm can't provide test file anymore. Sergey -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 51677] [PATCH] Small logging performance fix for BreakingAlgorithm
https://issues.apache.org/bugzilla/show_bug.cgi?id=51677 --- Comment #5 from Glenn Adams 2012-04-01 15:34:27 UTC --- (In reply to comment #3) > Chris, > > It's not a bugfix neither new feature, but a performance patch. So there is no > exception neither unworking code that magically became working after applying > the patch. What kind of test case you want me to create? > > I still can provide example document, but the only different thing is > execution > time. > > Best regards, > Sergey Sergey, do you expect to provide a test FO file for verifying the impact of your performance patch? if not, then I will move this bug to resolved+wontfix, thanks Glenn -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 51677] [PATCH] Small logging performance fix for BreakingAlgorithm
https://issues.apache.org/bugzilla/show_bug.cgi?id=51677 Chris Bowditch changed: What|Removed |Added Status|NEW |NEEDINFO -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 51677] [PATCH] Small logging performance fix for BreakingAlgorithm
https://issues.apache.org/bugzilla/show_bug.cgi?id=51677 --- Comment #4 from Chris Bowditch 2011-08-22 16:11:08 UTC --- Hi Sergey, I understand it is not a bug and the change doesn't fix an error. I simply meant that it is good practice to supply a test file for every code change. Regardless of the affect the change has. If I make up a test file I may get very different results from you, and if I perceive no performance improvement then I would be reluctant to commit the change. If however, we use the same test file, then our results should be aligned. Do you see what I mean? Of course, it would be prudent for any developer to try out multiple test files, not just 1, but I still think it would be useful for you to provide a test XSL-FO. Thanks, Chris -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 51677] [PATCH] Small logging performance fix for BreakingAlgorithm
https://issues.apache.org/bugzilla/show_bug.cgi?id=51677 --- Comment #3 from Sergey Vladimirov 2011-08-22 14:13:39 UTC --- Chris, It's not a bugfix neither new feature, but a performance patch. So there is no exception neither unworking code that magically became working after applying the patch. What kind of test case you want me to create? I still can provide example document, but the only different thing is execution time. Best regards, Sergey -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 51677] [PATCH] Small logging performance fix for BreakingAlgorithm
https://issues.apache.org/bugzilla/show_bug.cgi?id=51677 --- Comment #2 from Chris Bowditch 2011-08-22 13:19:20 UTC --- Hi Sergey, Thanks for the patch. It looks good in principal. Can you also attach some form of test case? If your own XSL-FO is private then please create an artificial example. Obviously I can create my own test case, but it is good practise to submit a test case with any code change. Thanks, Chris -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 51677] [PATCH] Small logging performance fix for BreakingAlgorithm
https://issues.apache.org/bugzilla/show_bug.cgi?id=51677 Chris Bowditch changed: What|Removed |Added Summary|Small logging performance |[PATCH] Small logging |fix for BreakingAlgorithm |performance fix for ||BreakingAlgorithm -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
