DO NOT REPLY [Bug 52257] [PATCH] Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 --- Comment #7 from Glenn Adams gl...@skynav.com 2012-04-08 09:10:54 UTC --- increase priority due to presence of a patch -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH] Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 Glenn Adams gl...@skynav.com changed: What|Removed |Added Priority|P3 |P2 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH] Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 Glenn Adams gl...@skynav.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #8 from Glenn Adams gl...@skynav.com 2012-04-08 21:15:45 UTC --- mehdi, what is the status of this patch? do you intend to commit it? or can it be withdrawn? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH] Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 --- Comment #9 from Mehdi Houshmand med1...@gmail.com 2012-04-08 21:44:58 UTC --- (In reply to comment #8) mehdi, what is the status of this patch? do you intend to commit it? or can it be withdrawn? Can it not be left outstanding?? Basically, we don't use the transcoders here, so I'm reluctant to implement an events system for a feature I don't know anything about. Vincent has given some comments, but again it comes down to a time issue. When I get the time to look into this, then I'll amend and apply the above patch. Sorry for the inconvenience. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH] Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 Glenn Adams gl...@skynav.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||LATER --- Comment #10 from Glenn Adams gl...@skynav.com 2012-04-08 23:08:03 UTC --- resolving as later due to no plans to commit; may be resurrected in the future -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH] Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 Glenn Adams gl...@skynav.com changed: What|Removed |Added Summary|[PATCH]Add events to the|[PATCH] Add events to the |font package|font package -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 --- Comment #6 from Glenn Adams gl...@skynav.com 2012-04-07 01:43:11 UTC --- resetting P2 open bugs to P3 pending further review -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 Glenn Adams gl...@skynav.com changed: What|Removed |Added Priority|P2 |P3 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 --- Comment #4 from Mehdi Houshmand med1...@gmail.com 2011-11-30 14:23:35 UTC --- So I looked into what what the transcoder behaviour is like, the event is swallowed i.e. nothing is output to the command line. However, because this throws an exception (my change does not change the exception being thrown), the following is thrown (in the case of Arial): Exception in thread main java.lang.RuntimeException: TrueType font is not supported: file:///usr/share/fonts/truetype/msttcorefonts/Arial.ttf -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 --- Comment #5 from Vincent Hennebert vhenneb...@gmail.com 2011-11-30 17:16:55 UTC --- I had a quick look at the code and think the creation of a new DefaultEventBroadcaster instance can be avoided in most places: • In TTFReader and TTFFile it’s not necessary, a dedicated FontEventListener that logs events on the standard output would do. • In IFUtil: the setupFonts(IFDocumentHandler) method should be removed and restriction added that the fontInfo be not null. I don’t think that this class is an appropriate place to create new FontInfo instances. Anyway, most callers of this method probably already pass a non-null instance of FontInfo. • In NativeTextHandler, the only class that calls the constructor passes a non-null FontInfo instance, so the setupFontInfo method can be removed. • PDFDocumentGraphics2D and PDFDocumentGraphics2DConfigurator: those classes are only used by the transcoder IIC. An appropriate FontEventListener implementation should be used instead of a FontEventAdapter • In PDFGraphics2D.createPattern: this one is less clear. I’m not sure why a new FontInfo instance is being created while one is already available as a member. This would need to be further investigated, but it doesn’t seem that custom fonts are being configured, only the base 14 ones. So the FontEventListener can be a dedicated implementation that throws an AssertionError whenever an event occurs. Vincent -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 Mehdi Houshmand med1...@gmail.com changed: What|Removed |Added Attachment #27994|0 |1 is obsolete|| --- Comment #2 from Mehdi Houshmand med1...@gmail.com 2011-11-29 13:22:19 UTC --- Created attachment 27998 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27998 font events part deux How would you suggest the event-broadcaster be injected in? Consider the following: - In o.a.f.render.ps.NativeTextHandler, the only way a DefaultEventBroadcaster is used is if the FontInfo object, given in the constructor is null. The only time the constructor is called is in the o.a.f.render.ps.AbstractPsTranscoder, how would you get the event broadcaster when it isn't given? - in o.a.f.render.intermediate.IFUtil, the DefaultEventBroadcaster is used only if the FontInfo object is null. Again, how would you inject the broadcaster when one isn't given? Or should I remove the null check and risk an NPE? - same applies to o.a.f.svg.PDFDocumentGraphics2D, risk NPE? - o.a.f.pdf.PDFFactory, this can be piped in a bit further. This has been amended. As for the error message, I disagree with your interpretation. The most important message to convey to the user is that the font isn't supported, we can't very well create a different message for every situation that a font isn't supported. The error here isn't in the font, it's that FOP doesn't currently support the font for whatever reason. As such I've left the error message as is. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 Mehdi Houshmand med1...@gmail.com changed: What|Removed |Added Attachment #27998|0 |1 is obsolete|| --- Comment #3 from Mehdi Houshmand med1...@gmail.com 2011-11-29 14:56:27 UTC --- Created attachment 28000 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28000 font events Changed fontNotSupported event to unicodeCmapNotFound -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 --- Comment #1 from Vincent Hennebert vhenneb...@gmail.com 2011-11-28 18:31:54 UTC --- IIC those transcoder jars are used by Batik to convert standalone SVG files into PDF. I suppose there's no harm in adding those dependencies to the jars, although it would need to be figured out how events are being processed (output on the command line? Logged? Just swallowed (which would be bad)?). However, there are changes in the patch that are almost certainly problematic: • a new DefaultEventBroadcaster instance is being created in the following classes: o/a/f/render/intermediate/IFUtil.java o/a/f/render/ps/NativeTextHandler.java o/a/f/svg/PDFGraphics2D.java o/a/f/pdf/PDFFactory.java The consequence is that at runtime it will be likely that several EventBroadcaster instances will exist in the same time and be handled inconsistently. For example, only the events from one instance may be caught and displayed in some dialog box. • the message added to the new fontNotSupported event will not be localizable, which defeats one of the purposes of the Event handling sub-system. It's probably best to create a more specific event. Vincent -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
