DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the constructor of Renderers
https://issues.apache.org/bugzilla/show_bug.cgi?id=52513 Mehdi Houshmand changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the constructor of Renderers
https://issues.apache.org/bugzilla/show_bug.cgi?id=52513 Mehdi Houshmand changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Mehdi Houshmand 2012-01-30 09:50:54 UTC --- patch applied in r1237582 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
Re: DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the constructor of Renderers
On 25/01/2012 14:46, Jonathan Levinson wrote: Hi Mehdi, Hi Jonathon, I'm trying to assess the impact on our code if any. It seems we just use the FOPFactory and don't directly construct a renderer so this change will have *no* impact on our code. The factory to get a new Fop already has foUserAgent in the constructor, so nothing has changed in this regard, for example: Fop fop = fopFactory.newFop(MimeConstants.MIME_PDF, foUserAgent, out); I've examined your diff, and unless I'm mistaken nothing in it impacts our client-server that accepts requests for FOP rendering via TCP/IP. You aren't changing how the FOPFactory is instantiated or how the FOP factory is used to instantiate Fops. That's right. Mehdi's change doesn't affect what we consider to be the public API (Although as already noted the classes affected have public modifiers). That is the classes used to embed FOP in a typical application that does FO->PDF or FO->IF->PDF Mehdi is currently writing up a list of classes/packages that we will consider the true public API that we can commit to changing as infrequently as possible. He will publish them here shortly for everyone's review. Thanks, Chris I can't assess the impact on other people's applications but the impact on our application seems non-existent. Best Regards, Jonathan Levinson Senior Software Developer Object Group InterSystems +1 617-621-0600 jonathan.levin...@intersystems.com http://www.intersystems.com/summit2012/ -Original Message- From: bugzi...@apache.org [mailto:bugzi...@apache.org] Sent: Wednesday, January 25, 2012 6:19 AM To: fop-dev@xmlgraphics.apache.org Subject: DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the constructor of Renderers https://issues.apache.org/bugzilla/show_bug.cgi?id=52513 --- Comment #2 from Mehdi Houshmand 2012-01-25 11:19:00 UTC --- Since there doesn't seem to be any strong opposition to this change, I'll start a lazy consensus (i.e. apply the patch in 72hrs henceforth) to allow people to discuss any objections they may have. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
RE: DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the constructor of Renderers
Hi Mehdi, I'm trying to assess the impact on our code if any. It seems we just use the FOPFactory and don't directly construct a renderer so this change will have *no* impact on our code. The factory to get a new Fop already has foUserAgent in the constructor, so nothing has changed in this regard, for example: Fop fop = fopFactory.newFop(MimeConstants.MIME_PDF, foUserAgent, out); I've examined your diff, and unless I'm mistaken nothing in it impacts our client-server that accepts requests for FOP rendering via TCP/IP. You aren't changing how the FOPFactory is instantiated or how the FOP factory is used to instantiate Fops. I can't assess the impact on other people's applications but the impact on our application seems non-existent. Best Regards, Jonathan Levinson Senior Software Developer Object Group InterSystems +1 617-621-0600 jonathan.levin...@intersystems.com http://www.intersystems.com/summit2012/ > -Original Message- > From: bugzi...@apache.org [mailto:bugzi...@apache.org] > Sent: Wednesday, January 25, 2012 6:19 AM > To: fop-dev@xmlgraphics.apache.org > Subject: DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the > constructor of Renderers > > https://issues.apache.org/bugzilla/show_bug.cgi?id=52513 > > --- Comment #2 from Mehdi Houshmand 2012-01-25 > 11:19:00 UTC --- Since there doesn't seem to be any strong opposition to this > change, I'll start a lazy consensus (i.e. apply the patch in 72hrs > henceforth) to > allow people to discuss any objections they may have. > > -- > Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email > --- You are receiving this mail because: --- You are the assignee for > the > bug.
DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the constructor of Renderers
https://issues.apache.org/bugzilla/show_bug.cgi?id=52513 --- Comment #2 from Mehdi Houshmand 2012-01-25 11:19:00 UTC --- Since there doesn't seem to be any strong opposition to this change, I'll start a lazy consensus (i.e. apply the patch in 72hrs henceforth) to allow people to discuss any objections they may have. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the constructor of Renderers
https://issues.apache.org/bugzilla/show_bug.cgi?id=52513 --- Comment #1 from Mehdi Houshmand 2012-01-24 09:52:20 UTC --- Created attachment 28197 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28197 patch -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
